[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017356#comment-17017356
]
Szilard Nemeth commented on YARN-9970:
--
Thanks [~maniraj...@gmail.com],
Committed branch-3.2 patch.
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016580#comment-17016580
]
Hadoop QA commented on YARN-9970:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016521#comment-17016521
]
Manikandan R commented on YARN-9970:
Fixed some checkstyle issues. Junit failures doesn't seem to be
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016202#comment-17016202
]
Hadoop QA commented on YARN-9970:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016114#comment-17016114
]
Manikandan R commented on YARN-9970:
[~pbacsko] Thanks. Attached patch for branch-3.2.
> Refactor
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015742#comment-17015742
]
Hudson commented on YARN-9970:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17864 (See
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015738#comment-17015738
]
Szilard Nemeth commented on YARN-9970:
--
Hi [~maniraj...@gmail.com],
Latest patch LGTM, committed to
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015337#comment-17015337
]
Hadoop QA commented on YARN-9970:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015195#comment-17015195
]
Manikandan R commented on YARN-9970:
[~snemeth] Thanks for your review. Attached .009.patch.
>
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014920#comment-17014920
]
Szilard Nemeth commented on YARN-9970:
--
Hi [~maniraj...@gmail.com],
1. Please remove unused
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014595#comment-17014595
]
Hadoop QA commented on YARN-9970:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014484#comment-17014484
]
Manikandan R commented on YARN-9970:
Rebasing..
> Refactor
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014452#comment-17014452
]
Szilard Nemeth commented on YARN-9970:
--
Hi [~maniraj...@gmail.com]!
Patch does not apply to trunk.
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013554#comment-17013554
]
Hadoop QA commented on YARN-9970:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013531#comment-17013531
]
Manikandan R commented on YARN-9970:
Rebasing..
> Refactor
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013205#comment-17013205
]
Szilard Nemeth commented on YARN-9970:
--
Hi [~maniraj...@gmail.com]!
Could you please rebase to trunk?
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989696#comment-16989696
]
Peter Bacsko commented on YARN-9970:
+1 (non-binding). Checkstyle complains about the method being too
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985658#comment-16985658
]
Hadoop QA commented on YARN-9970:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985629#comment-16985629
]
Manikandan R commented on YARN-9970:
Addressed checkstyle issues in .006.patch. Please check.
>
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984508#comment-16984508
]
Peter Bacsko commented on YARN-9970:
Wow, checkstyle is complaining like crazy. Well, what can we do?
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983894#comment-16983894
]
Hadoop QA commented on YARN-9970:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983746#comment-16983746
]
Manikandan R commented on YARN-9970:
Attached .005.patch.
> Refactor
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983740#comment-16983740
]
Hadoop QA commented on YARN-9970:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983647#comment-16983647
]
Manikandan R commented on YARN-9970:
[~pbacsko] Thanks for your review. Addressed all comments.
I've
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983450#comment-16983450
]
Peter Bacsko commented on YARN-9970:
1. Please write or generate a proper {{hashCode()}} method for
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981783#comment-16981783
]
Hadoop QA commented on YARN-9970:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981654#comment-16981654
]
Manikandan R commented on YARN-9970:
Rebasing..
[~snemeth] Can you review?
> Refactor
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977812#comment-16977812
]
Hadoop QA commented on YARN-9970:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977660#comment-16977660
]
Manikandan R commented on YARN-9970:
Addressed checkstyle, whitespace, license issues etc.
> Refactor
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975234#comment-16975234
]
Hadoop QA commented on YARN-9970:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975118#comment-16975118
]
Manikandan R commented on YARN-9970:
[~snemeth] Attached .001.patch. Can you please take a look?
>
31 matches
Mail list logo