[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-16 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017356#comment-17017356 ] Szilard Nemeth commented on YARN-9970: -- Thanks [~maniraj...@gmail.com], Committed branch-3.2 patch.

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016580#comment-17016580 ] Hadoop QA commented on YARN-9970: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-15 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016521#comment-17016521 ] Manikandan R commented on YARN-9970: Fixed some checkstyle issues. Junit failures doesn't seem to be

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016202#comment-17016202 ] Hadoop QA commented on YARN-9970: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-15 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016114#comment-17016114 ] Manikandan R commented on YARN-9970: [~pbacsko] Thanks. Attached patch for branch-3.2. > Refactor

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015742#comment-17015742 ] Hudson commented on YARN-9970: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17864 (See

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-15 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015738#comment-17015738 ] Szilard Nemeth commented on YARN-9970: -- Hi [~maniraj...@gmail.com], Latest patch LGTM, committed to

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015337#comment-17015337 ] Hadoop QA commented on YARN-9970: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-14 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015195#comment-17015195 ] Manikandan R commented on YARN-9970: [~snemeth] Thanks for your review. Attached .009.patch. >

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-14 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014920#comment-17014920 ] Szilard Nemeth commented on YARN-9970: -- Hi [~maniraj...@gmail.com], 1. Please remove unused

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014595#comment-17014595 ] Hadoop QA commented on YARN-9970: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-13 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014484#comment-17014484 ] Manikandan R commented on YARN-9970: Rebasing.. > Refactor

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-13 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014452#comment-17014452 ] Szilard Nemeth commented on YARN-9970: -- Hi [~maniraj...@gmail.com]! Patch does not apply to trunk.

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013554#comment-17013554 ] Hadoop QA commented on YARN-9970: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-11 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013531#comment-17013531 ] Manikandan R commented on YARN-9970: Rebasing.. > Refactor

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2020-01-10 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013205#comment-17013205 ] Szilard Nemeth commented on YARN-9970: -- Hi [~maniraj...@gmail.com]! Could you please rebase to trunk?

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-12-06 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989696#comment-16989696 ] Peter Bacsko commented on YARN-9970: +1 (non-binding). Checkstyle complains about the method being too

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-12-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985658#comment-16985658 ] Hadoop QA commented on YARN-9970: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-12-01 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985629#comment-16985629 ] Manikandan R commented on YARN-9970: Addressed checkstyle issues in .006.patch. Please check. >

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-28 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984508#comment-16984508 ] Peter Bacsko commented on YARN-9970: Wow, checkstyle is complaining like crazy. Well, what can we do?

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983894#comment-16983894 ] Hadoop QA commented on YARN-9970: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-27 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983746#comment-16983746 ] Manikandan R commented on YARN-9970: Attached .005.patch. > Refactor

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983740#comment-16983740 ] Hadoop QA commented on YARN-9970: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-27 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983647#comment-16983647 ] Manikandan R commented on YARN-9970: [~pbacsko] Thanks for your review.  Addressed all comments. I've

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-27 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983450#comment-16983450 ] Peter Bacsko commented on YARN-9970: 1. Please write or generate a proper {{hashCode()}} method for

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-25 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981783#comment-16981783 ] Hadoop QA commented on YARN-9970: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-25 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981654#comment-16981654 ] Manikandan R commented on YARN-9970: Rebasing.. [~snemeth] Can you review? > Refactor

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-19 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977812#comment-16977812 ] Hadoop QA commented on YARN-9970: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-19 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977660#comment-16977660 ] Manikandan R commented on YARN-9970: Addressed checkstyle, whitespace, license issues etc. > Refactor

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975234#comment-16975234 ] Hadoop QA commented on YARN-9970: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9970) Refactor TestUserGroupMappingPlacementRule#verifyQueueMapping

2019-11-15 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975118#comment-16975118 ] Manikandan R commented on YARN-9970: [~snemeth] Attached .001.patch. Can you please take a look? >