[jira] [Updated] (YARN-3700) ATS Web Performance issue at load time when large number of jobs

2015-05-21 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuan Gong updated YARN-3700: Attachment: YARN-3700.1.patch ATS Web Performance issue at load time when large number of jobs

[jira] [Updated] (YARN-3695) ServerProxy (NMProxy, etc.) shouldn't retry forever for non network exception.

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated YARN-3695: - Summary: ServerProxy (NMProxy, etc.) shouldn't retry forever for non network exception. (was:

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555133#comment-14555133 ] Junping Du commented on YARN-3411: -- Excellent work! Thanks [~vrushalic], [~sjlee0] and all

[jira] [Commented] (YARN-3646) Applications are getting stuck some times in case of retry policy forever

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555168#comment-14555168 ] Junping Du commented on YARN-3646: -- Also, congratulations to [~raju.bairishetti] for

[jira] [Commented] (YARN-3127) Apphistory url crashes when RM switches with ATS enabled

2015-05-21 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555202#comment-14555202 ] Xuan Gong commented on YARN-3127: - Link https://issues.apache.org/jira/browse/YARN-3701.

[jira] [Commented] (YARN-3684) Change ContainerExecutor's primary lifecycle methods to use a more extensible mechanism for passing information.

2015-05-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555275#comment-14555275 ] Hudson commented on YARN-3684: -- FAILURE: Integrated in Hadoop-trunk-Commit #7887 (See

[jira] [Updated] (YARN-3632) Ordering policy should be allowed to reorder an application when demand changes

2015-05-21 Thread Craig Welch (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Welch updated YARN-3632: -- Attachment: YARN-3632.6.patch Ordering policy should be allowed to reorder an application when demand

[jira] [Created] (YARN-3702) Timeline service v2 load generator needs to write event id

2015-05-21 Thread Li Lu (JIRA)
Li Lu created YARN-3702: --- Summary: Timeline service v2 load generator needs to write event id Key: YARN-3702 URL: https://issues.apache.org/jira/browse/YARN-3702 Project: Hadoop YARN Issue Type: Bug

[jira] [Updated] (YARN-3702) Timeline service v2 load generator needs to write event id

2015-05-21 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Li Lu updated YARN-3702: Attachment: YARN-3702-YARN-2928.001.patch trivial patch to add a sample timeline event id for the

[jira] [Assigned] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams

2015-05-21 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke reassigned YARN-3594: -- Assignee: Lars Francke WintuilsProcessStubExecutor.startStreamReader leaks streams

[jira] [Created] (YARN-3701) Isolating the erro of generating a single app report when getting all apps from generic history service

2015-05-21 Thread Zhijie Shen (JIRA)
Zhijie Shen created YARN-3701: - Summary: Isolating the erro of generating a single app report when getting all apps from generic history service Key: YARN-3701 URL: https://issues.apache.org/jira/browse/YARN-3701

[jira] [Updated] (YARN-3701) Isolating the error of generating a single app report when getting all apps from generic history service

2015-05-21 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhijie Shen updated YARN-3701: -- Summary: Isolating the error of generating a single app report when getting all apps from generic

[jira] [Updated] (YARN-3701) Isolating the error of generating a single app report when getting all apps from generic history service

2015-05-21 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhijie Shen updated YARN-3701: -- Attachment: YARN-3701.1.patch Create a patch to swallow the exception on generating the individual app

[jira] [Commented] (YARN-3684) Change ContainerExecutor's primary lifecycle methods to use a more extensible mechanism for passing information.

2015-05-21 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555193#comment-14555193 ] Vinod Kumar Vavilapalli commented on YARN-3684: --- This is a good first step,

[jira] [Commented] (YARN-3695) EOFException shouldn't be retry forever in RMProxy

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555192#comment-14555192 ] Junping Du commented on YARN-3695: -- bq. Junping Du, we have seen in some cases

[jira] [Updated] (YARN-3695) ServerProxy (NMProxy, etc.) shouldn't retry forever for non network exception.

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated YARN-3695: - Description: YARN-3646 fix the retry forever policy in RMProxy that it only applies on limited exceptions

[jira] [Commented] (YARN-3684) Change ContainerExecutor's primary lifecycle methods to use a more extensible mechanism for passing information.

2015-05-21 Thread Sidharta Seethana (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555204#comment-14555204 ] Sidharta Seethana commented on YARN-3684: - Thanks for the review and commit,

[jira] [Commented] (YARN-3645) ResourceManager can't start success if attribute value of aclSubmitApps is null in fair-scheduler.xml

2015-05-21 Thread Gabor Liptak (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555207#comment-14555207 ] Gabor Liptak commented on YARN-3645: Correcting checkstyle warnings ResourceManager

[jira] [Commented] (YARN-3655) FairScheduler: potential livelock due to maxAMShare limitation and container reservation

2015-05-21 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555228#comment-14555228 ] zhihai xu commented on YARN-3655: - [~asuresh], thanks for the review. As [~kasha]

[jira] [Commented] (YARN-3701) Isolating the error of generating a single app report when getting all apps from generic history service

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555289#comment-14555289 ] Hadoop QA commented on YARN-3701: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Updated] (YARN-3676) Disregard 'assignMultiple' directive while scheduling apps with NODE_LOCAL resource requests

2015-05-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-3676: -- Attachment: YARN-3676.3.patch Updating patch with testcase Disregard 'assignMultiple' directive while

[jira] [Commented] (YARN-2942) Aggregated Log Files should be combined

2015-05-21 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555382#comment-14555382 ] Robert Kanter commented on YARN-2942: - [~kasha], [~vinodkv], [~jlowe], and I had a

[jira] [Assigned] (YARN-3695) ServerProxy (NMProxy, etc.) shouldn't retry forever for non network exception.

2015-05-21 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Bairishetti reassigned YARN-3695: -- Assignee: Raju Bairishetti ServerProxy (NMProxy, etc.) shouldn't retry forever for non

[jira] [Commented] (YARN-3702) Timeline service v2 load generator needs to write event id

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555481#comment-14555481 ] Hadoop QA commented on YARN-3702: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3645) ResourceManager can't start success if attribute value of aclSubmitApps is null in fair-scheduler.xml

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555362#comment-14555362 ] Hadoop QA commented on YARN-3645: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3632) Ordering policy should be allowed to reorder an application when demand changes

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555413#comment-14555413 ] Hadoop QA commented on YARN-3632: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3701) Isolating the error of generating a single app report when getting all apps from generic history service

2015-05-21 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1415#comment-1415 ] Xuan Gong commented on YARN-3701: - Thanks for working this. [~zjshen]. The patch looks good

[jira] [Commented] (YARN-3676) Disregard 'assignMultiple' directive while scheduling apps with NODE_LOCAL resource requests

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1417#comment-1417 ] Hadoop QA commented on YARN-3676: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3655) FairScheduler: potential livelock due to maxAMShare limitation and container reservation

2015-05-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1466#comment-1466 ] Arun Suresh commented on YARN-3655: --- makes sense... +1 from me.. will commit, unless

[jira] [Commented] (YARN-3702) Timeline service v2 load generator needs to write event id

2015-05-21 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555613#comment-14555613 ] Zhijie Shen commented on YARN-3702: --- Nice catch, Li! Will commit the patch. Timeline

[jira] [Updated] (YARN-3697) FairScheduler: ContinuousSchedulingThread can't be shutdown after stop sometimes.

2015-05-21 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhihai xu updated YARN-3697: Attachment: YARN-3697.000.patch FairScheduler: ContinuousSchedulingThread can't be shutdown after stop

[jira] [Created] (YARN-3698) Make task attempt log files accessible from webapps

2015-05-21 Thread Sreenath Somarajapuram (JIRA)
Sreenath Somarajapuram created YARN-3698: Summary: Make task attempt log files accessible from webapps Key: YARN-3698 URL: https://issues.apache.org/jira/browse/YARN-3698 Project: Hadoop YARN

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554877#comment-14554877 ] Junping Du commented on YARN-3411: -- Address 2nd one in YARN-3696 also sounds good.

[jira] [Commented] (YARN-3697) FairScheduler: ContinuousSchedulingThread can't be shutdown after stop sometimes.

2015-05-21 Thread zhihai xu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554951#comment-14554951 ] zhihai xu commented on YARN-3697: - I uploaded a patch YARN-3697.000.patch for review. I

[jira] [Commented] (YARN-3594) WintuilsProcessStubExecutor.startStreamReader leaks streams

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554950#comment-14554950 ] Hadoop QA commented on YARN-3594: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Created] (YARN-3696) Handle null vs real 0 referenced in hbase writer impl

2015-05-21 Thread Vrushali C (JIRA)
Vrushali C created YARN-3696: Summary: Handle null vs real 0 referenced in hbase writer impl Key: YARN-3696 URL: https://issues.apache.org/jira/browse/YARN-3696 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-3681) yarn cmd says could not find main class 'queue' in windows

2015-05-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554559#comment-14554559 ] Hudson commented on YARN-3681: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See

[jira] [Commented] (YARN-3654) ContainerLogsPage web UI should not have meta-refresh

2015-05-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554557#comment-14554557 ] Hudson commented on YARN-3654: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See

[jira] [Commented] (YARN-2918) Don't fail RM if queue's configured labels are not existed in cluster-node-labels

2015-05-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554556#comment-14554556 ] Hudson commented on YARN-2918: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See

[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.

2015-05-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554558#comment-14554558 ] Hudson commented on YARN-3609: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554532#comment-14554532 ] Vrushali C commented on YARN-3411: -- HI [~djp] Thanks, appreciate your review very much!

[jira] [Commented] (YARN-3676) Disregard 'assignMultiple' directive while scheduling apps with NODE_LOCAL resource requests

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554539#comment-14554539 ] Hadoop QA commented on YARN-3676: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Vrushali C (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554544#comment-14554544 ] Vrushali C commented on YARN-3411: -- Yes, I in fact filed a jira

[jira] [Updated] (YARN-3676) Disregard 'assignMultiple' directive while scheduling apps with NODE_LOCAL resource requests

2015-05-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-3676: -- Attachment: YARN-3676.2.patch Reattaching patch. Disregard 'assignMultiple' directive while scheduling

[jira] [Commented] (YARN-3445) Cache runningApps in RMNode for getting running apps on given NodeId

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554591#comment-14554591 ] Hadoop QA commented on YARN-3445: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554586#comment-14554586 ] Sangjin Lee commented on YARN-3411: --- [~djp], I understand your concern on this. That

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554595#comment-14554595 ] Joep Rottinghuis commented on YARN-3411: I think it is reasonable that two

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554599#comment-14554599 ] Sangjin Lee commented on YARN-3411: --- This constructor

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Joep Rottinghuis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554606#comment-14554606 ] Joep Rottinghuis commented on YARN-3411: With respect to discussion on

[jira] [Commented] (YARN-3445) Cache runningApps in RMNode for getting running apps on given NodeId

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554623#comment-14554623 ] Junping Du commented on YARN-3445: -- [~vinodkv], can you help to review it again? Thanks!

[jira] [Updated] (YARN-3212) RMNode State Transition Update with DECOMMISSIONING state

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated YARN-3212: - Attachment: YARN-3212-v4.patch Update the patch to rebase on current trunk (with YARN-3225 get in with

[jira] [Commented] (YARN-3212) RMNode State Transition Update with DECOMMISSIONING state

2015-05-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554685#comment-14554685 ] Junping Du commented on YARN-3212: -- That make sense. Add a TODO in v4 patch so far to

[jira] [Updated] (YARN-3686) CapacityScheduler should trim default_node_label_expression

2015-05-21 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sunil G updated YARN-3686: -- Attachment: 0003-YARN-3686.patch Thank you [~leftnoteasy] for sharing the comments. Uploading new patch

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

2015-05-21 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554690#comment-14554690 ] Li Lu commented on YARN-3411: - Sorry about the delayed reply. Firstly, I thought flowVersion

[jira] [Commented] (YARN-3676) Disregard 'assignMultiple' directive while scheduling apps with NODE_LOCAL resource requests

2015-05-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554710#comment-14554710 ] Hadoop QA commented on YARN-3676: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

<    1   2