[jira] [Commented] (YARN-9560) Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime

2019-05-22 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845999#comment-16845999 ] Jim Brennan commented on YARN-9560: --- [~ebadger] thanks for the update!  I am +1 (non-binding) on patch

[jira] [Commented] (YARN-9560) Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime

2019-05-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844121#comment-16844121 ] Jim Brennan commented on YARN-9560: --- [~ebadger] Thanks for the patch. Overall this looks like a good

[jira] [Commented] (YARN-9560) Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime

2019-05-21 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844919#comment-16844919 ] Jim Brennan commented on YARN-9560: --- Thanks for the updates [~ebadger]! Some comments on the new patch:

[jira] [Commented] (YARN-9518) can't use CGroups with YARN in centos7

2019-05-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839570#comment-16839570 ] Jim Brennan commented on YARN-9518: --- [~shurong.mai], ideally we would use the same solution in 2.7 that

[jira] [Commented] (YARN-9561) Add C changes for the new OCI/squashfs/runc runtime

2019-05-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844311#comment-16844311 ] Jim Brennan commented on YARN-9561: --- [~ebadger] thanks for the patch!  I did an extensive review of this

[jira] [Commented] (YARN-9518) can't use CGroups with YARN in centos7

2019-04-29 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829328#comment-16829328 ] Jim Brennan commented on YARN-9518: --- [~shurong.mai], are you running with the latest code (trunk)?   The

[jira] [Commented] (YARN-9518) can't use CGroups with YARN in centos7

2019-04-30 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830347#comment-16830347 ] Jim Brennan commented on YARN-9518: --- [~shurong.mai], your patch needs to be based on branch trunk.   I

[jira] [Updated] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-07 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9527: -- Attachment: YARN-9527.002.patch > Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-19 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822028#comment-16822028 ] Jim Brennan commented on YARN-9486: --- [~eyang], why is launch.markLaunched() returning false in this

[jira] [Commented] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-02 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831903#comment-16831903 ] Jim Brennan commented on YARN-9527: --- I was able to find a node where the problem was actively happening,

[jira] [Created] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-02 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-9527: - Summary: Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file Key: YARN-9527 URL: https://issues.apache.org/jira/browse/YARN-9527 Project: Hadoop YARN

[jira] [Commented] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-02 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831883#comment-16831883 ] Jim Brennan commented on YARN-9527: --- For example, we recently had a case where all of the disks used by

[jira] [Assigned] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-03 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reassigned YARN-9527: - Assignee: Jim Brennan > Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same

[jira] [Updated] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-08 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9527: -- Attachment: YARN-9527.003.patch > Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same

[jira] [Commented] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-05-08 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835623#comment-16835623 ] Jim Brennan commented on YARN-9527: --- I put up patch 003 to address the checkstyle issues.   > Rogue

[jira] [Commented] (YARN-9560) Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime

2019-06-27 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874203#comment-16874203 ] Jim Brennan commented on YARN-9560: --- I think since these are not static strings - they are determined at

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-24 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825222#comment-16825222 ] Jim Brennan commented on YARN-9486: --- [~eyang] I'm not sure I agree. This suggests that

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-24 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825333#comment-16825333 ] Jim Brennan commented on YARN-9486: --- [~eyang] I am not too familiar with the ContainerRelaunch path, but

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-24 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825404#comment-16825404 ] Jim Brennan commented on YARN-9486: --- [~eyang] {quote} The right logic is probably try to locate it

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-24 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825465#comment-16825465 ] Jim Brennan commented on YARN-9486: --- {quote}Patch 003 added the safe guard for missing pid file, and

[jira] [Commented] (YARN-7848) Force removal of docker containers that do not get removed on first try

2019-04-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814627#comment-16814627 ] Jim Brennan commented on YARN-7848: --- Thanks [~eyang] for the update! Some comments: In

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-25 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826101#comment-16826101 ] Jim Brennan commented on YARN-9486: --- {quote} As the result, we need to check both markedLaunched and

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-25 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826142#comment-16826142 ] Jim Brennan commented on YARN-9486: --- [~eyang], I am +1 (non-binding) on patch 004. > Docker container

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-25 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826198#comment-16826198 ] Jim Brennan commented on YARN-9486: --- [~eyang] thanks for updating the comment.  +1 (non-binding) on

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-22 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823309#comment-16823309 ] Jim Brennan commented on YARN-9486: --- {quote} It looks like the problem is in the usage of

[jira] [Commented] (YARN-9486) Docker container exited with failure does not get clean up correctly

2019-04-22 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823189#comment-16823189 ] Jim Brennan commented on YARN-9486: --- [~eyang] I'm just trying to understand the logic here.

[jira] [Commented] (YARN-9560) Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime

2019-06-28 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875124#comment-16875124 ] Jim Brennan commented on YARN-9560: --- Thanks for all the updates [~ebadger]! I am also +1 on patch 013

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906463#comment-16906463 ] Jim Brennan commented on YARN-9442: --- Thanks [~ebadger]!  I will put up a patch for 2.8.   > container

[jira] [Updated] (YARN-9442) container working directory has group read permissions

2019-08-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9442: -- Attachment: YARN-9442-branch-2.8.001.patch > container working directory has group read permissions >

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906625#comment-16906625 ] Jim Brennan commented on YARN-9442: --- Thanks [~ebadger]! > container working directory has group read

[jira] [Commented] (YARN-9815) ReservationACLsTestBase fails with NPE

2019-09-10 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926851#comment-16926851 ] Jim Brennan commented on YARN-9815: --- {quote} Ok sure. I thought to avoid having NULL so the problem does

[jira] [Commented] (YARN-9815) ReservationACLsTestBase fails with NPE

2019-09-09 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926099#comment-16926099 ] Jim Brennan commented on YARN-9815: --- [~ahussein], I think a better solution would be to just add a null

[jira] [Commented] (YARN-9815) ReservationACLsTestBase fails with NPE

2019-09-11 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927589#comment-16927589 ] Jim Brennan commented on YARN-9815: --- [~ahussein] I am +1 (non-binding) on patch 002.  [~eepayne] or

[jira] [Commented] (YARN-9805) Fine-grained SchedulerNode synchronization

2019-09-11 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927594#comment-16927594 ] Jim Brennan commented on YARN-9805: --- [~ahussein], before getting into a detailed review of the changes,

[jira] [Commented] (YARN-9805) Fine-grained SchedulerNode synchronization

2019-09-11 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927609#comment-16927609 ] Jim Brennan commented on YARN-9805: --- [~ahussein] here's my initial impression of the

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-07 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902072#comment-16902072 ] Jim Brennan commented on YARN-9442: --- Thanks [~ebadger].  The current patch no longer applies, so I will

[jira] [Updated] (YARN-9442) container working directory has group read permissions

2019-08-07 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9442: -- Attachment: YARN-9442.003.patch > container working directory has group read permissions >

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-07 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902405#comment-16902405 ] Jim Brennan commented on YARN-9442: --- [~ebadger], I've put up a new patch that applies to trunk.   >

[jira] [Commented] (YARN-8045) Reduce log output from container status calls

2019-08-06 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901432#comment-16901432 ] Jim Brennan commented on YARN-8045: --- The patch for 2.8 looks good to me.  +1 (non-binding) > Reduce log

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-06 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901443#comment-16901443 ] Jim Brennan commented on YARN-9442: --- [~eyang], [~ebadger], [~shaneku...@gmail.com], [~jeagles], any

[jira] [Commented] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-08-06 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901473#comment-16901473 ] Jim Brennan commented on YARN-9527: --- We have been running with this patch on one of our large research

[jira] [Commented] (YARN-9527) Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same file

2019-08-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904109#comment-16904109 ] Jim Brennan commented on YARN-9527: --- Thanks [~eyang] and [~ebadger]! > Rogue

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904132#comment-16904132 ] Jim Brennan commented on YARN-9442: --- I am actually testing out a change - [~ebadger] and I discussed

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904142#comment-16904142 ] Jim Brennan commented on YARN-9442: --- [~eyang] read permission is needed for directory listing.  execute

[jira] [Commented] (YARN-9442) container working directory has group read permissions

2019-08-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904218#comment-16904218 ] Jim Brennan commented on YARN-9442: --- [~eyang], [~ebadger] thanks for the discussion.  I have tested on a

[jira] [Commented] (YARN-9647) Docker launch fails when local-dirs or log-dirs is unhealthy.

2019-07-22 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890503#comment-16890503 ] Jim Brennan commented on YARN-9647: --- [~ebadger], [~eyang], [~magnum] I think I'm following the

[jira] [Commented] (YARN-8045) Reduce log output from container status calls

2019-07-26 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893841#comment-16893841 ] Jim Brennan commented on YARN-8045: --- Would really like to see this pulled back to 2.8 - it looks like it

[jira] [Commented] (YARN-9846) Use Finer-Grain Synchronization in ResourceLocalizationService

2019-09-20 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934761#comment-16934761 ] Jim Brennan commented on YARN-9846: --- [~belugabehr] thanks for the patch, but can you provide some

[jira] [Commented] (YARN-9844) TestCapacitySchedulerPerf test errors in branch-2

2019-09-19 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933510#comment-16933510 ] Jim Brennan commented on YARN-9844: --- Here is a output from running the tests: {noformat} mvn test

[jira] [Commented] (YARN-9844) TestCapacitySchedulerPerf test errors in branch-2

2019-09-19 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933536#comment-16933536 ] Jim Brennan commented on YARN-9844: --- It appears that I can run these individually, and there are no

[jira] [Created] (YARN-9844) TestCapacitySchedulerPerf test errors in branch-2

2019-09-19 Thread Jim Brennan (Jira)
Jim Brennan created YARN-9844: - Summary: TestCapacitySchedulerPerf test errors in branch-2 Key: YARN-9844 URL: https://issues.apache.org/jira/browse/YARN-9844 Project: Hadoop YARN Issue Type:

[jira] [Updated] (YARN-9844) TestCapacitySchedulerPerf test errors in branch-2

2019-09-19 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9844: -- Description: These TestCapacitySchedulerPerf throughput tests are failing in branch-2: {{[ERROR]  

[jira] [Commented] (YARN-9564) Create docker-to-squash tool for image conversion

2019-11-01 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965038#comment-16965038 ] Jim Brennan commented on YARN-9564: --- Based on my testing with the latest patches for YARN-9561,

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-11-01 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965048#comment-16965048 ] Jim Brennan commented on YARN-9562: --- Thanks for the updates [~ebadger]!  I am +1 (non-binding) on patch

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-11-01 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965061#comment-16965061 ] Jim Brennan commented on YARN-9561: --- Thanks for updating the patch [~ebadger]!  I tested this along with

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-11-01 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965064#comment-16965064 ] Jim Brennan commented on YARN-9561: --- Actually, it might be better in this case to just do the stat and

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-11-04 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966954#comment-16966954 ] Jim Brennan commented on YARN-9561: --- Thanks for fixing that [~ebadger]!  The change looks good to me,

[jira] [Commented] (YARN-9564) Create docker-to-squash tool for image conversion

2019-11-08 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970382#comment-16970382 ] Jim Brennan commented on YARN-9564: --- Thanks for the updates [~ebadger]!  I am +1 (non-binding) on patch

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-11-08 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970381#comment-16970381 ] Jim Brennan commented on YARN-9562: --- Thanks for the updates [~ebadger]!  I am +1 (non-binding) on patch

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-11-08 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970380#comment-16970380 ] Jim Brennan commented on YARN-9561: --- Thanks for the updates [~ebadger]! A couple comments on the new

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-11-14 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974650#comment-16974650 ] Jim Brennan commented on YARN-9562: --- [~ebadger] I don't see a patch 015... > Add Java changes for the

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-11-15 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975247#comment-16975247 ] Jim Brennan commented on YARN-9561: --- I'm +1 (non-binding) on patch 014. > Add C changes for the new

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-11-15 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975241#comment-16975241 ] Jim Brennan commented on YARN-9562: --- I'm +1 on patch 015 (non-binding) > Add Java changes for the new

[jira] [Commented] (YARN-9959) Work around hard-coded tmp and /var/tmp bind-mounts in the container's working directory

2019-11-15 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975253#comment-16975253 ] Jim Brennan commented on YARN-9959: --- Sounds reasonable to me as well, but we may want to choose a format

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-11-06 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968537#comment-16968537 ] Jim Brennan commented on YARN-9562: --- [~ebadger], [~shaneku...@gmail.com] for the record, I ran with 

[jira] [Commented] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-28 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961090#comment-16961090 ] Jim Brennan commented on YARN-9914: --- Thanks [~ebadger]!  I was just about to put up another patch to fix

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-10-28 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961150#comment-16961150 ] Jim Brennan commented on YARN-9562: --- [~ebadger], I pulled YARN-9561, YARN-9562, and YARN-9564 into a

[jira] [Resolved] (YARN-9906) When setting multi volumes throurh the "YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS" setting is not valid

2019-10-16 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan resolved YARN-9906. --- Resolution: Invalid > When setting multi volumes throurh the "YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS"

[jira] [Commented] (YARN-9906) When setting multi volumes throurh the "YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS" setting is not valid

2019-10-16 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952852#comment-16952852 ] Jim Brennan commented on YARN-9906: --- [~lynnyuan] please see YARN-8071.   You can specify environment

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-10-24 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959002#comment-16959002 ] Jim Brennan commented on YARN-9561: --- [~ebadger] it does not look like Hadoop QA tests have run since you

[jira] [Commented] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-24 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958982#comment-16958982 ] Jim Brennan commented on YARN-9914: --- [~epayne] or [~ebadger] can you please review?   > Use separate

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-10-24 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959191#comment-16959191 ] Jim Brennan commented on YARN-9561: --- Thanks for the updated patch [~ebadger]! I had a few comments on

[jira] [Commented] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-24 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959256#comment-16959256 ] Jim Brennan commented on YARN-9914: --- Thanks for the review [~ebadger]!   I've updated patch 002 which

[jira] [Updated] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-24 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9914: -- Attachment: YARN-9914.002.patch > Use separate configs for free disk space checking for full and

[jira] [Commented] (YARN-9562) Add Java changes for the new RuncContainerRuntime

2019-10-24 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959220#comment-16959220 ] Jim Brennan commented on YARN-9562: --- Comment on patch 009: Nodemanager.java * ServiceInit() looks like

[jira] [Created] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-18 Thread Jim Brennan (Jira)
Jim Brennan created YARN-9914: - Summary: Use separate configs for free disk space checking for full and not-full disks Key: YARN-9914 URL: https://issues.apache.org/jira/browse/YARN-9914 Project: Hadoop

[jira] [Updated] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-18 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9914: -- Attachment: YARN-9914.001.patch > Use separate configs for free disk space checking for full and

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

2019-10-17 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953870#comment-16953870 ] Jim Brennan commented on YARN-9884: --- Thanks for the update [~ebadger]! I am +1 on patch 004

[jira] [Commented] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960057#comment-16960057 ] Jim Brennan commented on YARN-9914: --- Thanks [~ebadger]! I've attached a patch for branch-2.8. > Use

[jira] [Updated] (YARN-9914) Use separate configs for free disk space checking for full and not-full disks

2019-10-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-9914: -- Attachment: YARN-9914-branch-2.8.001.patch > Use separate configs for free disk space checking for full

[jira] [Commented] (YARN-9561) Add C changes for the new RuncContainerRuntime

2019-11-26 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982720#comment-16982720 ] Jim Brennan commented on YARN-9561: --- Thanks for the update [~ebadger]!  I downloaded patch 015 and then

[jira] [Commented] (YARN-9730) Support forcing configured partitions to be exclusive based on app node label

2019-09-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938009#comment-16938009 ] Jim Brennan commented on YARN-9730: --- [~jhung] I believe pulling this back to branch-2 has caused

[jira] [Commented] (YARN-9857) TestDelegationTokenRenewer throws NPE but tests pass

2019-09-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938023#comment-16938023 ] Jim Brennan commented on YARN-9857: --- +1 This looks good to me. (non-binding) [~ebadger] what do you

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

2019-10-11 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949691#comment-16949691 ] Jim Brennan commented on YARN-9884: --- [~ebadger] good job on the re-factoring.  This looks pretty good to

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

2019-10-14 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951032#comment-16951032 ] Jim Brennan commented on YARN-9884: --- Thanks for the updates [~ebadger]! I am +1 (non-binding) on patch

[jira] [Commented] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044743#comment-17044743 ] Jim Brennan commented on YARN-10161: [~inigoiri] or [~curino] can you please review? >

[jira] [Created] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-24 Thread Jim Brennan (Jira)
Jim Brennan created YARN-10161: -- Summary: TestRouterWebServicesREST is corrupting STDOUT Key: YARN-10161 URL: https://issues.apache.org/jira/browse/YARN-10161 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-2710) RM HA tests failed intermittently on trunk

2020-03-04 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051428#comment-17051428 ] Jim Brennan commented on YARN-2710: --- Thanks for the patches [~ahussein]! I have downloaded them and

[jira] [Commented] (YARN-2710) RM HA tests failed intermittently on trunk

2020-03-04 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051446#comment-17051446 ] Jim Brennan commented on YARN-2710: --- [~ahussein] can you be more specific? What are you using for

[jira] [Commented] (YARN-2710) RM HA tests failed intermittently on trunk

2020-03-04 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051460#comment-17051460 ] Jim Brennan commented on YARN-2710: --- Thanks [~ahussein]! In the meantime, I have finished running all

[jira] [Commented] (YARN-2710) RM HA tests failed intermittently on trunk

2020-03-04 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051579#comment-17051579 ] Jim Brennan commented on YARN-2710: --- Thanks for the update [~ahussein]! I re-ran the tests on both

[jira] [Commented] (YARN-9427) TestContainerSchedulerQueuing.testKillOnlyRequiredOpportunisticContainers fails sporadically

2020-03-02 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-9427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049671#comment-17049671 ] Jim Brennan commented on YARN-9427: --- Thanks for the patches [~ahussein]! I am +1 (non-binding) on these

[jira] [Commented] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-27 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046713#comment-17046713 ] Jim Brennan commented on YARN-10161: Thanks for the review [~inigoiri]! Just to make sure I

[jira] [Updated] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-27 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-10161: --- Attachment: YARN-10161.002.patch > TestRouterWebServicesREST is corrupting STDOUT >

[jira] [Commented] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-27 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046794#comment-17046794 ] Jim Brennan commented on YARN-10161: patch 003 fixes the whitespace issue. >

[jira] [Updated] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-27 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-10161: --- Attachment: YARN-10161.003.patch > TestRouterWebServicesREST is corrupting STDOUT >

[jira] [Assigned] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reassigned YARN-10161: -- Assignee: Jim Brennan > TestRouterWebServicesREST is corrupting STDOUT >

[jira] [Updated] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-25 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-10161: --- Affects Version/s: 3.2.1 > TestRouterWebServicesREST is corrupting STDOUT >

[jira] [Commented] (YARN-10161) TestRouterWebServicesREST is corrupting STDOUT

2020-02-27 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046970#comment-17046970 ] Jim Brennan commented on YARN-10161: Thanks [~inigoiri]! Can you commit this to trunk and other

[jira] [Commented] (YARN-2710) RM HA tests failed intermittently on trunk

2020-03-06 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053506#comment-17053506 ] Jim Brennan commented on YARN-2710: --- [~kihwal] would be good to get this committed. We are still seeing

<    1   2   3   4   5   6   7   8   9   >