[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369770#comment-15369770
]
Hudson commented on YARN-3908:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642860#comment-14642860
]
Sangjin Lee commented on YARN-3908:
---
Thanks for the update [~vrushalic]. Are folks OK
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643048#comment-14643048
]
Li Lu commented on YARN-3908:
-
Hi [~sjlee0], I'm OK with checking this in and address the event
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643113#comment-14643113
]
Zhijie Shen commented on YARN-3908:
---
[~vrushalic], thanks for fixing the problem. W.R.T
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643188#comment-14643188
]
Vrushali C commented on YARN-3908:
--
Hi Zhijie
Thanks.. that is a good point. But if we
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643267#comment-14643267
]
Zhijie Shen commented on YARN-3908:
---
Okay, it's fair point. It seems that the key design
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643446#comment-14643446
]
Vrushali C commented on YARN-3908:
--
Yes, let's get the current patch in and continue
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643421#comment-14643421
]
Li Lu commented on YARN-3908:
-
Just a quick check about the current status of this JIRA. Are we
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643476#comment-14643476
]
Zhijie Shen commented on YARN-3908:
---
Sure, as most folks are comfortable with the latest
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643424#comment-14643424
]
Sangjin Lee commented on YARN-3908:
---
+1 for committing this patch and having the event
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641026#comment-14641026
]
Vrushali C commented on YARN-3908:
--
Thanks everyone for the discussion. I will upload
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641114#comment-14641114
]
Joep Rottinghuis commented on YARN-3908:
It would be good to get the patch for
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641211#comment-14641211
]
Vrushali C commented on YARN-3908:
--
Sounds good, the current patch can be checked in and I
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641136#comment-14641136
]
Li Lu commented on YARN-3908:
-
bq. It would be good to get the patch for YARN-3908 checked in
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637300#comment-14637300
]
Zhijie Shen commented on YARN-3908:
---
bq. Is it the event id + timestamp? How about the
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636399#comment-14636399
]
Joep Rottinghuis commented on YARN-3908:
What does this mean for the
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635754#comment-14635754
]
Sangjin Lee commented on YARN-3908:
---
I filed YARN-3949 to address the need for timely
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635996#comment-14635996
]
Sangjin Lee commented on YARN-3908:
---
[~jrottinghuis], [~vrushalic], and I had offline
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636009#comment-14636009
]
Li Lu commented on YARN-3908:
-
Hi [~sjlee0], I don't think we're still using event type in new
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636050#comment-14636050
]
Sangjin Lee commented on YARN-3908:
---
Hmm, then isn't this incorrect?
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636058#comment-14636058
]
Li Lu commented on YARN-3908:
-
Hi [~sjlee0], I think the code you posted here belongs to
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636057#comment-14636057
]
Sangjin Lee commented on YARN-3908:
---
Sorry my bad. I mistakenly pulled up the v.1 of
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633937#comment-14633937
]
Sangjin Lee commented on YARN-3908:
---
bq. 1. The events have been written into metrics
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633936#comment-14633936
]
Sangjin Lee commented on YARN-3908:
---
The JIRA site seems offline right now.
bq. 1. The
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633857#comment-14633857
]
Zhijie Shen commented on YARN-3908:
---
I found two more issues upon debugging the reader
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634383#comment-14634383
]
Sangjin Lee commented on YARN-3908:
---
I'd like to propose closing this issue with the
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634200#comment-14634200
]
Zhijie Shen commented on YARN-3908:
---
I set up hbase-1.0.1.1 as a single node cluster on
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634293#comment-14634293
]
Sangjin Lee commented on YARN-3908:
---
Currently we're not calling
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632094#comment-14632094
]
Hadoop QA commented on YARN-3908:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631826#comment-14631826
]
Sangjin Lee commented on YARN-3908:
---
Thanks for the comment [~gtCarrera9]. I agree the
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630275#comment-14630275
]
Joep Rottinghuis commented on YARN-3908:
bq. In fact, I'm wondering if we should
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630289#comment-14630289
]
Joep Rottinghuis commented on YARN-3908:
Patch looks good with one comment. I
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630769#comment-14630769
]
Li Lu commented on YARN-3908:
-
Hi [~sjlee0], one nit: the name {{readTimeseriesResults}} looks
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630479#comment-14630479
]
Hadoop QA commented on YARN-3908:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624973#comment-14624973
]
Sangjin Lee commented on YARN-3908:
---
I would appreciate your review on this. Thanks!
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625369#comment-14625369
]
Zhijie Shen commented on YARN-3908:
---
[~vrushalic] and [~sjlee0], thanks for helping fix
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625387#comment-14625387
]
Sangjin Lee commented on YARN-3908:
---
bq. 2. We don't want to store the metric type, do
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625397#comment-14625397
]
Zhijie Shen commented on YARN-3908:
---
Yeah, but the method based on metric value number is
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625414#comment-14625414
]
Sangjin Lee commented on YARN-3908:
---
When a time series data expires after the TTL
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625502#comment-14625502
]
Sangjin Lee commented on YARN-3908:
---
bq. 1. In fact, I'm wondering if we should but info
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621982#comment-14621982
]
Hadoop QA commented on YARN-3908:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623180#comment-14623180
]
Hadoop QA commented on YARN-3908:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623133#comment-14623133
]
Hadoop QA commented on YARN-3908:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622727#comment-14622727
]
Sangjin Lee commented on YARN-3908:
---
Thanks [~vrushalic]! I'll look at it and see if more
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622987#comment-14622987
]
Sangjin Lee commented on YARN-3908:
---
A couple of comments on the latest patch:
I find
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621592#comment-14621592
]
Zhijie Shen commented on YARN-3908:
---
1. TimelineEvent has a timestamp associated with it.
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621571#comment-14621571
]
Vrushali C commented on YARN-3908:
--
Hi [~zjshen]
I see that event#info is not being
[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621480#comment-14621480
]
Zhijie Shen commented on YARN-3908:
---
Assign it to [~vrushalic] by default. Please feel
48 matches
Mail list logo
