[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799750#comment-15799750
]
Jian He commented on YARN-4164:
---
merged the patch to 2.8 too
> Retrospect update ApplicationPriority API
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799668#comment-15799668
]
Junping Du commented on YARN-4164:
--
This patch goes to branch-2 only instead of branch-2.8, set 2.9 as fix
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064915#comment-15064915
]
Hudson commented on YARN-4164:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #8999 (See
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064854#comment-15064854
]
Jian He commented on YARN-4164:
---
lgtm, +1
> Retrospect update ApplicationPriority API return type
>
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065162#comment-15065162
]
Rohith Sharma K S commented on YARN-4164:
-
Thanks [~jianhe] for review and committing patch
>
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063518#comment-15063518
]
Rohith Sharma K S commented on YARN-4164:
-
Looking into the HadoopQA result,
bq. -1 cc 16m
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061477#comment-15061477
]
Sunil G commented on YARN-4164:
---
Thanks [~rohithsharma] for updating the patch. Looks good. [~jianhe],
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058457#comment-15058457
]
Hadoop QA commented on YARN-4164:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057564#comment-15057564
]
Rohith Sharma K S commented on YARN-4164:
-
Updated the patch changing sysout message.
> Retrospect
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035302#comment-15035302
]
Rohith Sharma K S commented on YARN-4164:
-
I think just log message update with clarity should be
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035274#comment-15035274
]
Sunil G commented on YARN-4164:
---
Thanks [~rohithsharma] for updating the patch.
{code}
Priority
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034354#comment-15034354
]
Hadoop QA commented on YARN-4164:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976047#comment-14976047
]
Rohith Sharma K S commented on YARN-4164:
-
bq. rather than keeping a success flag.
Right, the
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976049#comment-14976049
]
Rohith Sharma K S commented on YARN-4164:
-
Updated the patch, kindly review
> Retrospect update
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976656#comment-14976656
]
Naganarasimha G R commented on YARN-4164:
-
Also can you take a look @ checkstyle and white space ?
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976557#comment-14976557
]
Hadoop QA commented on YARN-4164:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976653#comment-14976653
]
Naganarasimha G R commented on YARN-4164:
-
Thanks for the patch [~rohithsharma],
Yes as you
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965001#comment-14965001
]
Sunil G commented on YARN-4164:
---
Hi [~rohithsharma]
Thanks for updating patch.
I have one suggestion here,
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963396#comment-14963396
]
Hadoop QA commented on YARN-4164:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746952#comment-14746952
]
Sunil G commented on YARN-4164:
---
Hi [~rohithsharma]
Thanks for raising this. To an extent I also feel that
[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746921#comment-14746921
]
Rohith Sharma K S commented on YARN-4164:
-
The API {{public void
21 matches
Mail list logo
