[jira] [Commented] (YARN-6934) ResourceUtils.checkMandatoryResources() should also ensure that no min or max is set for vcores or memory

2017-08-05 Thread Manikandan R (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115364#comment-16115364
 ] 

Manikandan R commented on YARN-6934:


Ok, Modified patch and submitted for YARN-6933.

> ResourceUtils.checkMandatoryResources() should also ensure that no min or max 
> is set for vcores or memory
> -
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>  Labels: newbie++
> Attachments: YARN-6934.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6934) ResourceUtils.checkMandatoryResources() should also ensure that no min or max is set for vcores or memory

2017-08-04 Thread Daniel Templeton (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114863#comment-16114863
 ] 

Daniel Templeton commented on YARN-6934:


Thanks for the patch, [~maniraj...@gmail.com].  I just took a closer look at 
the code, and it looks like I was wrong when I filed this JIRA.  
{{setMinimumAllocationForMandatoryResources()}} and 
{{setMaximumAllocationForMandatoryResources()}} explicitly allow for the min 
and max to be set on CPU and memory.  I'm going to close it as invalid.

I have added you as a contributor for the YARN project now, so you can assign 
JIRAs to yourself in the future.  YARN-6933?

> ResourceUtils.checkMandatoryResources() should also ensure that no min or max 
> is set for vcores or memory
> -
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>  Labels: newbie++
> Attachments: YARN-6934.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6934) ResourceUtils.checkMandatoryResources() should also ensure that no min or max is set for vcores or memory

2017-08-04 Thread Manikandan R (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114849#comment-16114849
 ] 

Manikandan R commented on YARN-6934:


Based on discussion, Attached patch for review. It contains even the changes 
required for YARN-6933 as it is closely related.

> ResourceUtils.checkMandatoryResources() should also ensure that no min or max 
> is set for vcores or memory
> -
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>  Labels: newbie++
> Attachments: YARN-6934.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6934) ResourceUtils.checkMandatoryResources() should also ensure that no min or max is set for vcores or memory

2017-08-04 Thread Daniel Templeton (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114520#comment-16114520
 ] 

Daniel Templeton commented on YARN-6934:


See YARN-6933. :)

That whole block of code can be removed.  {{checkMandatoryResources()}} does 
the same check, but more descriptively.  {{checkMandatoryResources()}} and 
{{addMandatoryResources()}} are called at the bottom of 
{{initializeResourcesMap()}}, so taking out the extra check is fine.

Good catch on the order of {{checkMandatoryResources()}} and 
{{addMandatoryResources()}} being different in 
{{getNodeResourceInformation()}}.  You should probably swap them to match the 
order in {{initializeResourcesMap()}}.

> ResourceUtils.checkMandatoryResources() should also ensure that no min or max 
> is set for vcores or memory
> -
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>  Labels: newbie++
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6934) ResourceUtils.checkMandatoryResources() should also ensure that no min or max is set for vcores or memory

2017-08-04 Thread Manikandan R (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114373#comment-16114373
 ] 

Manikandan R commented on YARN-6934:


[~dan...@cloudera.com] 

While making an attempt to do required changes, had come across below lines 

{code}if (DISALLOWED_NAMES.contains(resourceName)) {
  throw new YarnRuntimeException(
  "Resource type cannot be named '" + resourceName
  + "'. That name is disallowed.");
}{code}

in initializeResourcesMap() method in ResourceUtils.java. I am not sure about 
the use of checkMandatatoryResources() method when above block of code doesn't 
allow to proceed further. Should we need to make a call to 
checkMandatatoryResources()  after addManadtoryResources() similar to calls in 
getNodeResourceInformation() ?
I may be wrong, Please help me to understand.

In addition, we will need to fix typo issues in method names as well. for ex, 
addManadtoryResources()

> ResourceUtils.checkMandatoryResources() should also ensure that no min or max 
> is set for vcores or memory
> -
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>  Labels: newbie++
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org