[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332188#comment-14332188
]
Hudson commented on YARN-2799:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #112 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/112/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
* hadoop-yarn-project/CHANGES.txt
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332216#comment-14332216
]
Hudson commented on YARN-2799:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2062 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2062/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330281#comment-14330281
]
Hudson commented on YARN-2799:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2043 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2043/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330300#comment-14330300
]
Hudson commented on YARN-2799:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #102 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/102/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330144#comment-14330144
]
Hudson commented on YARN-2799:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #111 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/111/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330174#comment-14330174
]
Hudson commented on YARN-2799:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #845 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/845/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
* hadoop-yarn-project/CHANGES.txt
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329958#comment-14329958
]
zhihai xu commented on YARN-2799:
-
Thanks [~djp] for valuable feedback and committing the patch!
Greatly appreciated
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329209#comment-14329209
]
Junping Du commented on YARN-2799:
--
+1. Committing it now.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329187#comment-14329187
]
Hadoop QA commented on YARN-2799:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698939/YARN-2799.002.patch
against trunk revision a64dd3d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6681//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6681//console
This message is automatically generated.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329224#comment-14329224
]
Hudson commented on YARN-2799:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7163 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7163/])
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90.
Contributed by Zhihai Xu (junping_du: rev
c33ae271c24f0770c9735ccd2086cafda4f4e0b2)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java
* hadoop-yarn-project/CHANGES.txt
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Fix For: 2.7.0
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322656#comment-14322656
]
Junping Du commented on YARN-2799:
--
Latest patch looks good to me. Kick off Jenkins test again (as patch is 2 days
ago) and +1 depends on Jenkins result.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321754#comment-14321754
]
zhihai xu commented on YARN-2799:
-
Hi [~djp],
Yes, you are right. that is a good catch. I uploaded a new patch
YARN-2799.002.patch which addressed your comment.
Please review it.
thanks
zhihai
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321762#comment-14321762
]
Hadoop QA commented on YARN-2799:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698939/YARN-2799.002.patch
against trunk revision ef950ea.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6639//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6639//console
This message is automatically generated.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch,
YARN-2799.002.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320096#comment-14320096
]
Junping Du commented on YARN-2799:
--
Patch looks good in overall. However, a comment for a trivial issue here:
In testAppLogDirCreation(), we create a new InlineDispatcher
{code}
InlineDispatcher dispatcher = new InlineDispatcher();
{code}
but we doesn't stop it somewhere. Shall we add a stop() within the test?
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320095#comment-14320095
]
Hadoop QA commented on YARN-2799:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681240/YARN-2799.001.patch
against trunk revision ba3c80a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6634//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6634//console
This message is automatically generated.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320048#comment-14320048
]
Hadoop QA commented on YARN-2799:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681240/YARN-2799.001.patch
against trunk revision ba3c80a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6632//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6632//console
This message is automatically generated.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209222#comment-14209222
]
zhihai xu commented on YARN-2799:
-
attached a new patch YARN-2799.001.patch which is rebased to latest code.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209258#comment-14209258
]
Hadoop QA commented on YARN-2799:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681240/YARN-2799.001.patch
against trunk revision 9f0319b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5835//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5835//console
This message is automatically generated.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch, YARN-2799.001.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2799) cleanup TestLogAggregationService based on the change in YARN-90
[
https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14194061#comment-14194061
]
Hadoop QA commented on YARN-2799:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12678830/YARN-2799.000.patch
against trunk revision 5c0381c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5686//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5686//console
This message is automatically generated.
cleanup TestLogAggregationService based on the change in YARN-90
Key: YARN-2799
URL: https://issues.apache.org/jira/browse/YARN-2799
Project: Hadoop YARN
Issue Type: Improvement
Components: test
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
Attachments: YARN-2799.000.patch
cleanup TestLogAggregationService based on the change in YARN-90.
The following code is added to setup in YARN-90,
{code}
dispatcher = createDispatcher();
appEventHandler = mock(EventHandler.class);
dispatcher.register(ApplicationEventType.class, appEventHandler);
{code}
In this case, we should remove all these code from each test function to
avoid duplicate code.
Same for dispatcher.stop() which is in tearDown,
we can remove dispatcher.stop() from from each test function also because it
will always be called from tearDown for each test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
