[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146407#comment-17146407 ] Hudson commented on YARN-6526: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18384 (See

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-06-18 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139986#comment-17139986 ] Íñigo Goiri commented on YARN-6526: --- +1 on [^YARN-6526.008.patch]. > Refactoring

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-06-12 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134376#comment-17134376 ] Bilwa S T commented on YARN-6526: - [~elgoiri] Can you please take a look at this when you are free? Thanks

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-06-11 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133248#comment-17133248 ] Brahma Reddy Battula commented on YARN-6526: [~BilwaST], thanks for updating the patch..

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110555#comment-17110555 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-18 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110507#comment-17110507 ] Bilwa S T commented on YARN-6526: - Hi [~brahmareddy] I think its correct to decrease the count when

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-14 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107317#comment-17107317 ] Bilwa S T commented on YARN-6526: - Hi [~brahmareddy]  this is metrics is to check how many connections

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-14 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107298#comment-17107298 ] Brahma Reddy Battula commented on YARN-6526: Patch lgtm. apart from the following doubt which

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-13 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106481#comment-17106481 ] Íñigo Goiri commented on YARN-6526: --- +1 on [^YARN-6526.007.patch]. The findbugs seems unrelated. >

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-12 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105604#comment-17105604 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-12 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105538#comment-17105538 ] Bilwa S T commented on YARN-6526: - Thanks [~elgoiri] for reviewing. I updated patch > Refactoring

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105526#comment-17105526 ] Íñigo Goiri commented on YARN-6526: --- Thanks for the update in [^YARN-6526.006.patch]. For the

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103753#comment-17103753 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-10 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103729#comment-17103729 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-10 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103690#comment-17103690 ] Bilwa S T commented on YARN-6526: - Thanks [~elgoiri] for reviewing. I have updated patch * Before i was

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-09 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103477#comment-17103477 ] Íñigo Goiri commented on YARN-6526: --- Thanks [~BilwaST], this looks good. Just a couple things to wrap

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103122#comment-17103122 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102905#comment-17102905 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-08 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102846#comment-17102846 ] Bilwa S T commented on YARN-6526: - Hi [~elgoiri] I have attached patch by adding metrics and related

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-07 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102114#comment-17102114 ] Íñigo Goiri commented on YARN-6526: --- That would be the right place to do it yes. As long as we can check

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-07 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101508#comment-17101508 ] Bilwa S T commented on YARN-6526: - Hi [~elgoiri] We can add it in FederationStateStoreClientMetrics . But

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-06 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101164#comment-17101164 ] Íñigo Goiri commented on YARN-6526: --- Is there something we can test to make sure we are not recreating

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-05 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099662#comment-17099662 ] Bilwa S T commented on YARN-6526: - cc [~inigoiri] [~brahmareddy] > Refactoring SQLFederationStateStore by

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097686#comment-17097686 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097661#comment-17097661 ] Hadoop QA commented on YARN-6526: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-01 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097600#comment-17097600 ] Bilwa S T commented on YARN-6526: - Thanks [~giovanni.fumarola] for clarification. I have attached patch.

[jira] [Commented] (YARN-6526) Refactoring SQLFederationStateStore by avoiding to recreate a connection at every call

2020-05-01 Thread Giovanni Matteo Fumarola (Jira)
[ https://issues.apache.org/jira/browse/YARN-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097545#comment-17097545 ] Giovanni Matteo Fumarola commented on YARN-6526: Currently the code get a connection from