[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366168#comment-16366168
]
Konstantinos Karanasos commented on YARN-7920:
--
Patch looks good, thanks [~leftnoteasy].
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365444#comment-16365444
]
genericqa commented on YARN-7920:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365246#comment-16365246
]
Wangda Tan commented on YARN-7920:
--
Attached ver.6 patch for the ASF warning, failed test case is not
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365174#comment-16365174
]
genericqa commented on YARN-7920:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365097#comment-16365097
]
Wangda Tan commented on YARN-7920:
--
Updated (Ver.5) patch, also converted to standard markdown, only a few
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365092#comment-16365092
]
Wangda Tan commented on YARN-7920:
--
Thanks [~kkaranasos],
the .md.vm is not supported by Intellij and
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364783#comment-16364783
]
Konstantinos Karanasos commented on YARN-7920:
--
Re: configuration, I think it is simpler at
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364248#comment-16364248
]
Sunil G commented on YARN-7920:
---
I think a name like {{placement-processor}} seems more simple for now. We
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364214#comment-16364214
]
Wangda Tan commented on YARN-7920:
--
+ [~cheersyang]
> Cleanup configuration of PlacementConstraints
>
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364083#comment-16364083
]
Wangda Tan commented on YARN-7920:
--
{quote}If you don't like priority/placement-optimized, how about
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363849#comment-16363849
]
genericqa commented on YARN-7920:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363733#comment-16363733
]
genericqa commented on YARN-7920:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363667#comment-16363667
]
Arun Suresh commented on YARN-7920:
---
bq. More likely, the two handler will be merged in the future into
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363645#comment-16363645
]
Wangda Tan commented on YARN-7920:
--
Thanks [~asuresh],
Addressed:
{quote} * the \{{
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363595#comment-16363595
]
Arun Suresh commented on YARN-7920:
---
Thanks for working on this [~leftnoteasy]
Couple of comments:
* the
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363557#comment-16363557
]
Wangda Tan commented on YARN-7920:
--
Thanks [~kkaranasos] for review:
{quote} * The naming external
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363348#comment-16363348
]
Konstantinos Karanasos commented on YARN-7920:
--
Hi [~leftnoteasy],
{quote}I would still prefer
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362500#comment-16362500
]
genericqa commented on YARN-7920:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362232#comment-16362232
]
Wangda Tan commented on YARN-7920:
--
Attached patch (ver.2) addressed comments from Sunil.
> Cleanup
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362027#comment-16362027
]
Wangda Tan commented on YARN-7920:
--
Thanks [~sunilg], I plan to update documentation in a separate Jira or
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362022#comment-16362022
]
genericqa commented on YARN-7920:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361907#comment-16361907
]
Sunil G commented on YARN-7920:
---
Thanks [~leftnoteasy] for the patch. Refactoring looks fine to me.
Few
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360317#comment-16360317
]
Wangda Tan commented on YARN-7920:
--
Attached ver.1 patch, [~kkaranasos]/[~asuresh]/[~sunilg] please help
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360265#comment-16360265
]
Wangda Tan commented on YARN-7920:
--
Thanks [~kkaranasos], I would still prefer to "scheduler", otherwise
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360261#comment-16360261
]
Konstantinos Karanasos commented on YARN-7920:
--
Hi [~leftnoteasy], +1 for simplifying the
[
https://issues.apache.org/jira/browse/YARN-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359712#comment-16359712
]
Wangda Tan commented on YARN-7920:
--
cc: [~sunilg], [~kkaranasos]:
I plan to work on a patch tomorrow,
26 matches
Mail list logo