[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435624#comment-16435624
]
Hudson commented on YARN-7931:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1398
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1643#comment-1643
]
Haibo Chen commented on YARN-7931:
--
+1. Will check this in shortly
> [atsv2 read acls] In
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434985#comment-16434985
]
genericqa commented on YARN-7931:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434922#comment-16434922
]
Vrushali C commented on YARN-7931:
--
Uploading v004 that addresses Haibo's point about ensu
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432688#comment-16432688
]
Vrushali C commented on YARN-7931:
--
Hi [~haibochen]
That's a good question. Let me check
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428411#comment-16428411
]
Haibo Chen commented on YARN-7931:
--
I have one question. The DomainRowKeyConverter.encode(
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428021#comment-16428021
]
Rohith Sharma K S commented on YARN-7931:
-
+1 lgtm
> [atsv2 read acls] Include dom
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427675#comment-16427675
]
genericqa commented on YARN-7931:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427619#comment-16427619
]
Vrushali C commented on YARN-7931:
--
uploading 003 that addresses latest review suggestions
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426491#comment-16426491
]
Rohith Sharma K S commented on YARN-7931:
-
nit: I see that DomainTable class has ou
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426483#comment-16426483
]
Rohith Sharma K S commented on YARN-7931:
-
overall patch looks good to me.
One do
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424793#comment-16424793
]
Haibo Chen commented on YARN-7931:
--
+1 on the latest patch. [~rohithsharma] Do you want to
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424720#comment-16424720
]
genericqa commented on YARN-7931:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424670#comment-16424670
]
Vrushali C commented on YARN-7931:
--
Uploaded patch 002 that addresses Haibo's suggestions.
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414345#comment-16414345
]
Vrushali C commented on YARN-7931:
--
Thanks [~haibochen] for the review!
Yes I will update
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410277#comment-16410277
]
Haibo Chen commented on YARN-7931:
--
Thanks [~vrushalic] for the patch. The patch looks goo
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408996#comment-16408996
]
genericqa commented on YARN-7931:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408819#comment-16408819
]
Vrushali C commented on YARN-7931:
--
Uploading patch 0001.
> [atsv2 read acls] Include do
18 matches
Mail list logo