[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689432#comment-16689432
]
Abhishek Modi commented on YARN-8303:
-
Thanks [~rohithsharma] for review and committing it.
>
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689362#comment-16689362
]
Hudson commented on YARN-8303:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15448 (See
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689340#comment-16689340
]
Rohith Sharma K S commented on YARN-8303:
-
+1 committing shortly
> YarnClient should contact
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689328#comment-16689328
]
Hadoop QA commented on YARN-8303:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689306#comment-16689306
]
Abhishek Modi commented on YARN-8303:
-
[~rohithsharma] thanks for review. I already added a new patch
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689304#comment-16689304
]
Rohith Sharma K S commented on YARN-8303:
-
+1 lgtm.. [~abmodi] test is failing, could you correct
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689125#comment-16689125
]
Hadoop QA commented on YARN-8303:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687689#comment-16687689
]
Rohith Sharma K S commented on YARN-8303:
-
[~abmodi] We also need to newer option in help message
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687610#comment-16687610
]
Hadoop QA commented on YARN-8303:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687590#comment-16687590
]
Rohith Sharma K S commented on YARN-8303:
-
Digging more details, it appears
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687572#comment-16687572
]
Rohith Sharma K S commented on YARN-8303:
-
thanks [~abmodi] for the patch! I see some issues while
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686556#comment-16686556
]
Rohith Sharma K S commented on YARN-8303:
-
[~abmodi] along with above comments, 2 of checkstyle
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686554#comment-16686554
]
Rohith Sharma K S commented on YARN-8303:
-
Some comments
YarnClientImpl
# Most of the API's
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685430#comment-16685430
]
Hadoop QA commented on YARN-8303:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683440#comment-16683440
]
Rohith Sharma K S commented on YARN-8303:
-
[~abmodi] Could you update the patch ?
> YarnClient
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674714#comment-16674714
]
Rohith Sharma K S commented on YARN-8303:
-
[~abmodi] could you also update the -clusterid options
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672062#comment-16672062
]
Hadoop QA commented on YARN-8303:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667495#comment-16667495
]
Rohith Sharma K S commented on YARN-8303:
-
[~abmodi] Any update on this?
> YarnClient should
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661587#comment-16661587
]
Suma Shivaprasad commented on YARN-8303:
Thanks [~abmodi] for the patch.
Given that
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659199#comment-16659199
]
Abhishek Modi commented on YARN-8303:
-
Sure [~rohithsharma]. Will do by end of this week.
>
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659098#comment-16659098
]
Rohith Sharma K S commented on YARN-8303:
-
Hi [~abmodi], YARN-8834 is committed. Hence, could you
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631451#comment-16631451
]
Abhishek Modi commented on YARN-8303:
-
Thanks [~rohithsharma] for review. It's a good idea to separate
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631444#comment-16631444
]
Rohith Sharma K S commented on YARN-8303:
-
I felt providing java client need to be discussed more.
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631428#comment-16631428
]
Rohith Sharma K S commented on YARN-8303:
-
Thanks [~abmodi] for the patch.. Couple of comments..
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628494#comment-16628494
]
Abhishek Modi commented on YARN-8303:
-
[~rohithsharma] I will submit an updated patch by EOD today.
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628318#comment-16628318
]
Rohith Sharma K S commented on YARN-8303:
-
[~abmodi] any update on this?
> YarnClient should
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598375#comment-16598375
]
Abhishek Modi commented on YARN-8303:
-
Thanks [~rohithsharma] for review. I will address these
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598229#comment-16598229
]
Rohith Sharma K S commented on YARN-8303:
-
Thanks [~abmodi] for the patch.. Approach looks good to
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597632#comment-16597632
]
Vrushali C commented on YARN-8303:
--
Thanks Abhishek!
[~rohithsharma] we should look at this patch and
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576216#comment-16576216
]
genericqa commented on YARN-8303:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575819#comment-16575819
]
Abhishek Modi commented on YARN-8303:
-
[~rohithsharma] [~vrushalic] I have submitted a POC patch for
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509666#comment-16509666
]
Abhishek Modi commented on YARN-8303:
-
Thanks [~rohithsharma]. I will start working on it soon.
>
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507256#comment-16507256
]
Rohith Sharma K S commented on YARN-8303:
-
All is yours:-) Go ahead..
> YarnClient should contact
[
https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507252#comment-16507252
]
Abhishek Modi commented on YARN-8303:
-
Thanks [~rohithsharma] for filing this. I am assigning it to
34 matches
Mail list logo