[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708242#comment-16708242
]
Yufei Gu commented on YARN-9041:
The last patch looks good. +1 for the patch v7. Will commit this soon.
>
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708140#comment-16708140
]
Wanqiang Ji commented on YARN-9041:
---
I'm so sorry for this brought unnecessary trouble to you,
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708107#comment-16708107
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707857#comment-16707857
]
Yufei Gu commented on YARN-9041:
Thanks for the patch. Some nits:
# {{ * @return list preemptable
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704300#comment-16704300
]
Wanqiang Ji commented on YARN-9041:
---
Hi [~yufeigu], the v6 patch fixed all the issues you mentioned. Pls
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704295#comment-16704295
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704014#comment-16704014
]
Yufei Gu commented on YARN-9041:
Hi [~jiwq], the patch v5 looks good in terms of logic. Some nits:
# Can
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702681#comment-16702681
]
Wanqiang Ji commented on YARN-9041:
---
Thanks for [~Steven Rand] review and help.
> Optimize
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702538#comment-16702538
]
Steven Rand commented on YARN-9041:
---
bq. If we not allowed relax locality, it will executes three
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702308#comment-16702308
]
Yufei Gu commented on YARN-9041:
There is an error in test build which isn't related to your patch. I'll
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701664#comment-16701664
]
Wanqiang Ji commented on YARN-9041:
---
Not sure why Jenkins gives -1 even all UTs have passed, I have seen
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701607#comment-16701607
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701438#comment-16701438
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701374#comment-16701374
]
Wanqiang Ji commented on YARN-9041:
---
Updated 004 patch to fix the checkstyle issue and change the new UT
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700835#comment-16700835
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700592#comment-16700592
]
Wanqiang Ji commented on YARN-9041:
---
Hi [~yufeigu], thanks for your detailed review. I added the UT in
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700424#comment-16700424
]
Wanqiang Ji commented on YARN-9041:
---
Hi [~Steven Rand], thanks for your detailed review.
{quote}I'm
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699843#comment-16699843
]
Steven Rand commented on YARN-9041:
---
Yes, the v2 patch resolves my concern -- thanks [~jiwq] for fixing
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699511#comment-16699511
]
Yufei Gu commented on YARN-9041:
Hi [~jiwq], thanks for the patch. I like the idea to shrink the search
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694564#comment-16694564
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694366#comment-16694366
]
Wanqiang Ji commented on YARN-9041:
---
Thanks for [~Steven Rand] detailed review. You are right, I ignored
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694329#comment-16694329
]
Steven Rand commented on YARN-9041:
---
I'm not sure that this is correct. I think that it can lead to
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694275#comment-16694275
]
Wanqiang Ji commented on YARN-9041:
---
The UT failure should be irrelevant, I tested locally it can work
[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694139#comment-16694139
]
Hadoop QA commented on YARN-9041:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
24 matches
Mail list logo
