[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206736#comment-15206736 ] Hadoop QA commented on YARN-998: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205907#comment-15205907 ] Hadoop QA commented on YARN-998: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205383#comment-15205383 ] Junping Du commented on YARN-998: - Thanks [~jianhe] for comments! bq. should ResourceTrackerService#drConf

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205193#comment-15205193 ] Jian He commented on YARN-998: -- looks good to me overall, - should ResourceTrackerService#drConf be volatile ?

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205065#comment-15205065 ] Hadoop QA commented on YARN-998: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-21 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204769#comment-15204769 ] Junping Du commented on YARN-998: - Verified in locally that

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204666#comment-15204666 ] Hadoop QA commented on YARN-998: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199584#comment-15199584 ] Junping Du commented on YARN-998: - Hi [~jianhe], would you kindly review the patch again? Thanks! >

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-19 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197345#comment-15197345 ] Junping Du commented on YARN-998: - Thanks Jian for review and comments. bq.

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197900#comment-15197900 ] Hadoop QA commented on YARN-998: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-15 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196541#comment-15196541 ] Jian He commented on YARN-998: -- thanks Junping for the explanation, few comments I have: -

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-15 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196347#comment-15196347 ] Junping Du commented on YARN-998: - Hi [~jianhe], thanks for reviewing and comments. bq. is the purpose of

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-15 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196310#comment-15196310 ] Jian He commented on YARN-998: -- [~djp], to better understand this jira, is the purpose of the jira to make RM

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196235#comment-15196235 ] Hadoop QA commented on YARN-998: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-998) Persistent resource change during NM/RM restart

2016-03-11 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191389#comment-15191389 ] Junping Du commented on YARN-998: - Thanks Kenji for providing a sample patch. Several improvements should