[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248315#comment-17248315
]
Adam Antal commented on YARN-10031:
---
Committed to trunk. Thanks for the contribution [~gandras]!
>
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247906#comment-17247906
]
Adam Antal commented on YARN-10031:
---
Thanks [~gandras]!
LGTM. If there's no other reviews, I will
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247884#comment-17247884
]
Hadoop QA commented on YARN-10031:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247773#comment-17247773
]
Andras Gyori commented on YARN-10031:
-
Thank you [~adam.antal] for the help. I have addressed the
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243160#comment-17243160
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243045#comment-17243045
]
Adam Antal commented on YARN-10031:
---
Reuploaded patch v5
> Create a general purpose log request with
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239144#comment-17239144
]
Adam Antal commented on YARN-10031:
---
Hi [~gandras],
Could you please rebase and reupload the patch to
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235310#comment-17235310
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235284#comment-17235284
]
Andras Gyori commented on YARN-10031:
-
Fixed the checkstyle errors and javadoc issues.
> Create a
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235013#comment-17235013
]
Adam Antal commented on YARN-10031:
---
Thanks for rebasing the patch.
I plan to have another review
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234927#comment-17234927
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234749#comment-17234749
]
Andras Gyori commented on YARN-10031:
-
Uploaded a new patch rebased on recent trunk.
> Create a
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234705#comment-17234705
]
Szilard Nemeth commented on YARN-10031:
---
[~gandras],
Please upload a next patch as it cannot be
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234704#comment-17234704
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234703#comment-17234703
]
Szilard Nemeth commented on YARN-10031:
---
Retriggered build for this one.
> Create a general
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213145#comment-17213145
]
Hadoop QA commented on YARN-10031:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213069#comment-17213069
]
Andras Gyori commented on YARN-10031:
-
Thank you for the feedback [~adam.antal]. I have uploaded a
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208611#comment-17208611
]
Adam Antal commented on YARN-10031:
---
Thanks for the patch [~gandras]. Sorry for the late with the
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200752#comment-17200752
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200644#comment-17200644
]
Andras Gyori commented on YARN-10031:
-
Thank you [~adam.antal] for the answers. The null check
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197729#comment-17197729
]
Adam Antal commented on YARN-10031:
---
Thanks for the response [~gandras].
I accidentally made an error
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192844#comment-17192844
]
Andras Gyori commented on YARN-10031:
-
Thanks [~adam.antal] for the review. I agree with the naming
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191754#comment-17191754
]
Adam Antal commented on YARN-10031:
---
Thanks for the patch [~gandras].
Looks good overall: I agree
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188589#comment-17188589
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188433#comment-17188433
]
Andras Gyori commented on YARN-10031:
-
A new patch has been uploaded, where the new query is
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165819#comment-17165819
]
Hadoop QA commented on YARN-10031:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165706#comment-17165706
]
Andras Gyori commented on YARN-10031:
-
Also, for now, only the TFile controller is supported. This
27 matches
Mail list logo