[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057354#comment-14057354
]
Hudson commented on YARN-1366:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #609 (See
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057472#comment-14057472
]
Hudson commented on YARN-1366:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1800 (See
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057539#comment-14057539
]
Hudson commented on YARN-1366:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056570#comment-14056570
]
Hudson commented on YARN-1366:
--
FAILURE: Integrated in Hadoop-trunk-Commit #5850 (See
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14054839#comment-14054839
]
Hadoop QA commented on YARN-1366:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055200#comment-14055200
]
Jian He commented on YARN-1366:
---
lgtm
AM should implement Resync with the
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053200#comment-14053200
]
Jian He commented on YARN-1366:
---
Can you also clarify why AMRMClient automatically does
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053201#comment-14053201
]
Bikas Saha commented on YARN-1366:
--
bq. I meant an empty response.
After this does
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053210#comment-14053210
]
Jian He commented on YARN-1366:
---
right, we can remove that too
AM should implement Resync
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051141#comment-14051141
]
Hadoop QA commented on YARN-1366:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050913#comment-14050913
]
Jian He commented on YARN-1366:
---
looks good, +1
AM should implement Resync with the
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050965#comment-14050965
]
Bikas Saha commented on YARN-1366:
--
Why are we returning the old allocateResponse to the
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050975#comment-14050975
]
Jian He commented on YARN-1366:
---
bq. Should we make a second call to allocate (after
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050977#comment-14050977
]
Jian He commented on YARN-1366:
---
bq. in which case the returned allocate response should be
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050978#comment-14050978
]
Bikas Saha commented on YARN-1366:
--
Does a null response make sense for the user?
AM
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051013#comment-14051013
]
Rohith commented on YARN-1366:
--
bq. can you add some documentation about this
Shall I add in
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051049#comment-14051049
]
Jian He commented on YARN-1366:
---
add java doc for AMRMClient#allocate(). should be enough.
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048567#comment-14048567
]
Hadoop QA commented on YARN-1366:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048574#comment-14048574
]
Hadoop QA commented on YARN-1366:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049167#comment-14049167
]
Jian He commented on YARN-1366:
---
- SecurityUtil.java loads configurations during class
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049563#comment-14049563
]
Rohith commented on YARN-1366:
--
bq. These two synchronized block can be merged into one ?
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049572#comment-14049572
]
Jian He commented on YARN-1366:
---
I meant, can we do this ?
{code}
synchronized (this)
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049610#comment-14049610
]
Hadoop QA commented on YARN-1366:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049646#comment-14049646
]
Hadoop QA commented on YARN-1366:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047412#comment-14047412
]
Rohith commented on YARN-1366:
--
Thank you for reviewing patch. I will update patch soon.
One
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047432#comment-14047432
]
Jian He commented on YARN-1366:
---
bq. The test does verification of pending release too
I see.
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047718#comment-14047718
]
Hadoop QA commented on YARN-1366:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047962#comment-14047962
]
Jian He commented on YARN-1366:
---
Thanks for updating, some more comments:
-
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048079#comment-14048079
]
Jian He commented on YARN-1366:
---
- we may check pendingRelease isEmpty as well to avoid
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047072#comment-14047072
]
Hadoop QA commented on YARN-1366:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047366#comment-14047366
]
Jian He commented on YARN-1366:
---
Thanks for working on the patch ! some comments:
-
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046826#comment-14046826
]
Rohith commented on YARN-1366:
--
Looking into fix findbug warning and test case. Will update
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046900#comment-14046900
]
Hadoop QA commented on YARN-1366:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046176#comment-14046176
]
Hadoop QA commented on YARN-1366:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043085#comment-14043085
]
Jian He commented on YARN-1366:
---
btw, can you add necessary comments in the test body also,
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043044#comment-14043044
]
Jian He commented on YARN-1366:
---
Hi [~rohithsharma], start looking at the patch. it''s been
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043059#comment-14043059
]
Rohith commented on YARN-1366:
--
Thank you [~jianhe] for looking into patch :-) In current
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013356#comment-14013356
]
Jian He commented on YARN-1366:
---
The bulk of the patch here is MR changes. I think we should
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013607#comment-14013607
]
Rohith commented on YARN-1366:
--
Let this jira keep only for Yarn Client. I created
[
https://issues.apache.org/jira/browse/YARN-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013281#comment-14013281
]
Anubhav Dhoot commented on YARN-1366:
-
Updated the title to more accurately reflect the
40 matches
Mail list logo