[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377999#comment-14377999
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #142 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/142/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377950#comment-14377950
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #133 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/133/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377930#comment-14377930
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2074 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2074/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377868#comment-14377868
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2092 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2092/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377655#comment-14377655
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #876 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/876/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377639#comment-14377639
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #142 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/142/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377216#comment-14377216
]
Hudson commented on YARN-3393:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7409 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7409/])
YARN-3393. Getting application(s) goes wrong when app finishes before (xgong:
rev 9fae455e26e0230107e1c6db58a49a5b6b296cf4)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryManagerOnTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377211#comment-14377211
]
Xuan Gong commented on YARN-3393:
-
Committed into trunk/branch-2/branch-2.7. Thanks, zhijie.
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Fix For: 2.7.0
>
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377204#comment-14377204
]
Xuan Gong commented on YARN-3393:
-
+1 LGTM. Will commit
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3393) Getting application(s) goes wrong when app finishes before starting the attempt
[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377133#comment-14377133
]
Hadoop QA commented on YARN-3393:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706792/YARN-3393.1.patch
against trunk revision 2c238ae.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7084//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7084//console
This message is automatically generated.
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> ---
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>Priority: Critical
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
