[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369809#comment-15369809 ] Hudson commented on YARN-3551: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527586#comment-14527586 ] Hadoop QA commented on YARN-3551: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527442#comment-14527442 ] Li Lu commented on YARN-3551: - The latest patch LGTM. +1 for commit. Consolidate data model

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527426#comment-14527426 ] Sangjin Lee commented on YARN-3551: --- LGTM. I've seen much flakiness with the

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524144#comment-14524144 ] Li Lu commented on YARN-3551: - It seems like the 3 findbugs warnings were introduced in

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522960#comment-14522960 ] Hadoop QA commented on YARN-3551: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522744#comment-14522744 ] Zhijie Shen commented on YARN-3551: --- Created a new patch to change timeline metric APIs

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522785#comment-14522785 ] Sangjin Lee commented on YARN-3551: --- The latest patch looks good. Thanks for addressing

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520295#comment-14520295 ] Sangjin Lee commented on YARN-3551: --- I'm fine with going with using GenericOptionMapper

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520484#comment-14520484 ] Zhijie Shen commented on YARN-3551: --- Cool, thanks for the comments, Sangjin. So the

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518360#comment-14518360 ] Li Lu commented on YARN-3551: - Hi [~sjlee0]! I agree it would be nice to have more strict type

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518494#comment-14518494 ] Sangjin Lee commented on YARN-3551: --- I don't think those two things are mutually

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518450#comment-14518450 ] Li Lu commented on YARN-3551: - OK, I didn't say it clear enough but this is the solution I was

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518583#comment-14518583 ] Vrushali C commented on YARN-3551: -- + 1 to the constructor and templated code above. bq.

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518338#comment-14518338 ] Sangjin Lee commented on YARN-3551: --- Thanks for the patch [~zjshen]! How about making

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518414#comment-14518414 ] Sangjin Lee commented on YARN-3551: --- I was going to follow up. The generics alone is not

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518569#comment-14518569 ] Vrushali C commented on YARN-3551: -- Thanks [~zjshen] for the jira and the patch. I was

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518575#comment-14518575 ] Vrushali C commented on YARN-3551: -- Hmm, yes, we do need a datatype per metric to be

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518654#comment-14518654 ] Zhijie Shen commented on YARN-3551: --- bq. Also, think along with singleData, we also need

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516073#comment-14516073 ] Li Lu commented on YARN-3551: - Hi [~zjshen], thanks for the patch! Some quick comments and

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516359#comment-14516359 ] Zhijie Shen commented on YARN-3551: --- Li, thanks for the comments. See the following

[jira] [Commented] (YARN-3551) Consolidate data model change according to the backend implementation

[ https://issues.apache.org/jira/browse/YARN-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516422#comment-14516422 ] Li Lu commented on YARN-3551: - Hi [~zjshen], thanks for the update. The latest patch LGTM.