[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390792#comment-16390792
]
Yufei Gu commented on YARN-5028:
It is a nice-to-have one. Trunk is good enough. Thanks [~leftnoteasy].
>
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390707#comment-16390707
]
Wangda Tan commented on YARN-5028:
--
[~yufeigu], since this isn't committed to branch-3.1, just set fix
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385855#comment-16385855
]
Gergo Repas commented on YARN-5028:
---
Thanks [~yufeigu], [~rohithsharma]!
> RMStateStore should trim down
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382312#comment-16382312
]
Hudson commented on YARN-5028:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13750 (See
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382279#comment-16382279
]
Yufei Gu commented on YARN-5028:
Committed the addendum to trunk.
> RMStateStore should trim down app
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382246#comment-16382246
]
Yufei Gu commented on YARN-5028:
The addendum patch looks good to me. +1. This original one only committed
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382127#comment-16382127
]
Rohith Sharma K S commented on YARN-5028:
-
I have verified basic RM restart scenarios and looks
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382113#comment-16382113
]
Gergo Repas commented on YARN-5028:
---
[~rohithsharma] Apologies for causing the break, and thanks for the
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381950#comment-16381950
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381912#comment-16381912
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381801#comment-16381801
]
Rohith Sharma K S commented on YARN-5028:
-
Updated patch adding app name and app tags included.
>
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381784#comment-16381784
]
Rohith Sharma K S commented on YARN-5028:
-
I found that couple of more issues where app report also
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381679#comment-16381679
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381591#comment-16381591
]
Sunil G commented on YARN-5028:
---
Addendum patch looks fine. +1 pending jenkins.
> RMStateStore should trim
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381582#comment-16381582
]
Rohith Sharma K S commented on YARN-5028:
-
As it is blocking ATS enabled recovery flows, taking
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381556#comment-16381556
]
Rohith Sharma K S commented on YARN-5028:
-
[~grepas] [~yufeigu] this seems to be breaking when ATS
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372608#comment-16372608
]
Gergo Repas commented on YARN-5028:
---
[~yufeigu] Thanks for the commit and reviews. Thanks, but I don't
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371928#comment-16371928
]
Hudson commented on YARN-5028:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13697 (See
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371908#comment-16371908
]
Yufei Gu commented on YARN-5028:
Committed to trunk. Thanks for the patch, [~grepas]. Thanks for the
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370958#comment-16370958
]
Rohith Sharma K S commented on YARN-5028:
-
latest patch reasonable to me
> RMStateStore should
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370356#comment-16370356
]
Yufei Gu commented on YARN-5028:
+1 for the last patch. Will commit it later.
> RMStateStore should trim
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370203#comment-16370203
]
genericqa commented on YARN-5028:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370093#comment-16370093
]
Gergo Repas commented on YARN-5028:
---
007.patch: I addressed the checkstyle issue, locally ran all unit
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369427#comment-16369427
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369202#comment-16369202
]
Gergo Repas commented on YARN-5028:
---
I'm looking into the test failures.
> RMStateStore should trim down
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369174#comment-16369174
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369095#comment-16369095
]
Gergo Repas commented on YARN-5028:
---
[~sunilg] - I think we can keep the ACL-s in the same field as
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369091#comment-16369091
]
Sunil G commented on YARN-5028:
---
Thanks [~grepas]. Thats a really good change. Does this mean we have to
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369088#comment-16369088
]
Gergo Repas commented on YARN-5028:
---
[~rohithsharma] [~yufeigu] - A pi job produced 1891 byte long znode
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367864#comment-16367864
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367565#comment-16367565
]
Gergo Repas commented on YARN-5028:
---
[~rohithsharma] - Sure, I'm going to put together statistics on
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367486#comment-16367486
]
Rohith Sharma K S commented on YARN-5028:
-
Apologies for pitching in late! thanks [~grepas] for
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367317#comment-16367317
]
Gergo Repas commented on YARN-5028:
---
I fixed the bug in 003.patch. The latest run was marked as failed
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366897#comment-16366897
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366187#comment-16366187
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365852#comment-16365852
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365788#comment-16365788
]
Gergo Repas commented on YARN-5028:
---
[~yufeigu] Thanks for the suggestions, I addressed all of them in
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365047#comment-16365047
]
Yufei Gu commented on YARN-5028:
In case of {{createAndPopulateNewRMApp}}, it uses the ApplicationACLs in
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364266#comment-16364266
]
Gergo Repas commented on YARN-5028:
---
[~yufeigu] - Right, the null check can be abandoned (I'll upload a
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362817#comment-16362817
]
Yufei Gu commented on YARN-5028:
Thanks [~grepas]. Yes. We do need these two fields.
{code}
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362390#comment-16362390
]
Gergo Repas commented on YARN-5028:
---
[~yufeigu] The two fields that are needed for the unit tests to pass
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361601#comment-16361601
]
Yufei Gu commented on YARN-5028:
Thanks [~grepas]. I'm OK with the first four fields. Can you tell me a
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360528#comment-16360528
]
Gergo Repas commented on YARN-5028:
---
[~yufeigu] Yes, sure - I started out with an empty submission
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358801#comment-16358801
]
Yufei Gu commented on YARN-5028:
Hi [~grepas], thanks for working on this. Could you elaborate on the
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355237#comment-16355237
]
Szilard Nemeth commented on YARN-5028:
--
Hey [~grepas]!
I just checked your changes, +1 (non-binding).
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354169#comment-16354169
]
Gergo Repas commented on YARN-5028:
---
The TestRMWebServiceAppsNodelabel unit test failure is unrelated
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352287#comment-16352287
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350701#comment-16350701
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350349#comment-16350349
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349286#comment-16349286
]
genericqa commented on YARN-5028:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343593#comment-16343593
]
Gergo Repas commented on YARN-5028:
---
Hi [~templedf] - can I please pick this ticket up?
> RMStateStore
51 matches
Mail list logo
