[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146735#comment-16146735 ] Hudson commented on YARN-6069: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017028#comment-16017028 ] Varun Saxena commented on YARN-6069: Yes. Any issues?

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016972#comment-16016972 ] Sunil G commented on YARN-6069: --- [~varun_saxena] could you please confirm whether its committed to trunk. >

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905816#comment-15905816 ] Varun Saxena commented on YARN-6069: Committed to trunk > CORS support in timeline v2 >

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904678#comment-15904678 ] Varun Saxena commented on YARN-6069: Ok...Will do so shortly. > CORS support in timeline v2 >

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904653#comment-15904653 ] Rohith Sharma K S commented on YARN-6069: - [~varun_saxena] We are facing issue in trunk integration

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879921#comment-15879921 ] Varun Saxena commented on YARN-6069: Committed to YARN-5355, YARN-5355-branch-2 Thanks Rohith! > CORS

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877874#comment-15877874 ] Varun Saxena commented on YARN-6069: Thanks [~rohithsharma], changes LGTM. Will commit it later

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877840#comment-15877840 ] Hadoop QA commented on YARN-6069: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877530#comment-15877530 ] Rohith Sharma K S commented on YARN-6069: - [~gtCarrera9] Basically CORS is required when there is

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876765#comment-15876765 ] Li Lu commented on YARN-6069: - Sorry to chime in this late, but one general question about CORS itself. I'm

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876503#comment-15876503 ] Varun Saxena commented on YARN-6069: Thanks [~rohithsharma] for the patch. The configuration

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875860#comment-15875860 ] Hadoop QA commented on YARN-6069: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875636#comment-15875636 ] Varun Saxena commented on YARN-6069: [~rohithsharma], yeah documentation looks fine to me.

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875559#comment-15875559 ] Rohith Sharma K S commented on YARN-6069: - bq. Also yarn.timeline-service.http-cross-origin.enabled

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874951#comment-15874951 ] Varun Saxena commented on YARN-6069: In comment above, I think we can simplify the sentence I wrote

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874915#comment-15874915 ] Varun Saxena commented on YARN-6069: Thanks [~rohithsharma] for the patch. Core changes look fine to

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874452#comment-15874452 ] Hadoop QA commented on YARN-6069: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872410#comment-15872410 ] Varun Saxena commented on YARN-6069: The patch as such looks fine to me. We can add a link to HTTP

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870044#comment-15870044 ] Varun Saxena commented on YARN-6069: bq. I think folks are forgetting one important thing that this

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869957#comment-15869957 ] Varun Saxena commented on YARN-6069: Probably it did not come out clearly in my previous comment. I was

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869914#comment-15869914 ] Rohith Sharma K S commented on YARN-6069: - I think folks are forgetting one important thing that

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869865#comment-15869865 ] Varun Saxena commented on YARN-6069: Now coming to the patch, the thing we have to consider is that we

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869864#comment-15869864 ] Varun Saxena commented on YARN-6069: [~sunilg], bq. I am behind such a linear approach and reuse

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869176#comment-15869176 ] Hadoop QA commented on YARN-6069: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869154#comment-15869154 ] Sunil G commented on YARN-6069: --- In RM and NM, we just a enable a configuration to decide whether CORS

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869117#comment-15869117 ] Rohith Sharma K S commented on YARN-6069: - I am not fan of adding daemon specific code snippet into

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869094#comment-15869094 ] Varun Saxena commented on YARN-6069: As of now for timeline service, we use the timeline specific

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869084#comment-15869084 ] Varun Saxena commented on YARN-6069: bq. I think you are missing one key thing is PREFIX is different

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869054#comment-15869054 ] Rohith Sharma K S commented on YARN-6069: - [~varun_saxena] I think you are missing one key thing is

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869030#comment-15869030 ] Sunil G commented on YARN-6069: --- [~rohithsharma] Do we have

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868628#comment-15868628 ] Varun Saxena commented on YARN-6069: Thanks [~rohithsharma] for the patch. # I think we can move

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866248#comment-15866248 ] Rohith Sharma K S commented on YARN-6069: - These are CORS filter attributes which are customized

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866056#comment-15866056 ] Sunil G commented on YARN-6069: --- One quick doubt. Where are these configs

[jira] [Commented] (YARN-6069) CORS support in timeline v2

[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865869#comment-15865869 ] Hadoop QA commented on YARN-6069: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||