[jira] [Commented] (YARN-8448) AM HTTPS Support for AM communication with RMWeb proxy

2018-10-19 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657044#comment-16657044 ] Eric Yang commented on YARN-8448: - [~rkanter] This patch has a problem with clean up

[jira] [Commented] (YARN-8448) AM HTTPS Support for AM communication with RMWeb proxy

2018-10-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652431#comment-16652431 ] Hudson commented on YARN-8448: -- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15230 (See

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-16 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652392#comment-16652392 ] Haibo Chen commented on YARN-8448: -- I ran the cestest locally and it did not fail for me either. +1 on

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-16 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652181#comment-16652181 ] Robert Kanter commented on YARN-8448: - {{TestCapacityOverTimePolicy}} failure is unrelated.  I'm not

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651016#comment-16651016 ] Hadoop QA commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-15 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650740#comment-16650740 ] Robert Kanter commented on YARN-8448: - Thanks [~haibochen] for another review. The license issue is

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-15 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650587#comment-16650587 ] Haibo Chen commented on YARN-8448: -- Thanks [~rkanter] for addressing the comments!  {quote}The only

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648742#comment-16648742 ] Hadoop QA commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-12 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648614#comment-16648614 ] Robert Kanter commented on YARN-8448: - Thanks for the feedback {{haibochen}}! Some comments: {quote}In

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-12 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648434#comment-16648434 ] Haibo Chen commented on YARN-8448: -- For the ProxyCA related changes, I have a few questions/comments. 1) 

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-12 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648293#comment-16648293 ] Haibo Chen commented on YARN-8448: -- A few minor comments/questions about the c code changes. 1) In

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647227#comment-16647227 ] Hadoop QA commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647209#comment-16647209 ] Haibo Chen commented on YARN-8448: -- Thanks [~rkanter] for the patch update! Posting some of my comments

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647210#comment-16647210 ] Haibo Chen commented on YARN-8448: -- I'll continue the review tomorrow and post remaining comments, if

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647168#comment-16647168 ] Robert Kanter commented on YARN-8448: - I see, thanks for the details [~jlowe] - it's been a while

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647131#comment-16647131 ] Jason Lowe commented on YARN-8448: -- bq. The cc warning isn't a problem. IMHO the warning should be

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646811#comment-16646811 ] Robert Kanter commented on YARN-8448: - - The cc warning isn't a problem.  It's complaining that I'm

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646106#comment-16646106 ] Hadoop QA commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-10 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645928#comment-16645928 ] Robert Kanter commented on YARN-8448: - The 007 patch: - Rebased on latest trunk - Removed pom changes

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-09 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644059#comment-16644059 ] Robert Kanter commented on YARN-8448: - I discussed this with [~haibochen] offline and we agreed that

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-09 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643719#comment-16643719 ] Haibo Chen commented on YARN-8448: -- Thanks [~rkanter] for the elaboration. OFF is what YARN does as of

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-08 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642647#comment-16642647 ] Robert Kanter commented on YARN-8448: - Thanks [~haibochen] for the review.  That's a good idea about

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-08 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642603#comment-16642603 ] Haibo Chen commented on YARN-8448: -- Thanks [~rkanter]  for the the patch. I took a high-level look. The

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-04 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638522#comment-16638522 ] Robert Kanter commented on YARN-8448: - Test failures seem unrelated - they all pass locally for me. >

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636430#comment-16636430 ] Hadoop QA commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-02 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636254#comment-16636254 ] Robert Kanter commented on YARN-8448: - I've kicked off another run after fixing trunk (it wasn't

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636229#comment-16636229 ] Hadoop QA commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-10-02 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635808#comment-16635808 ] Robert Kanter commented on YARN-8448: - Thanks for the review [~snemeth]. I was on PTO but am back

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-16 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582321#comment-16582321 ] Szilard Nemeth commented on YARN-8448: -- Hey [~rkanter]! Here are my review comments: - hadoop

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-06 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571030#comment-16571030 ] genericqa commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-06 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570703#comment-16570703 ] Robert Kanter commented on YARN-8448: - The 005 patch: - Fixes the unit tests. It turns out we do

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569068#comment-16569068 ] genericqa commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-03 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568819#comment-16568819 ] Robert Kanter commented on YARN-8448: - - Existing mvnsite failure and findbugs with ozone and hdds are

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567616#comment-16567616 ] genericqa commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-08-02 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567078#comment-16567078 ] Robert Kanter commented on YARN-8448: - I'm not sure where Jenkins went, so I've just kicked one off

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-07-30 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562482#comment-16562482 ] Robert Kanter commented on YARN-8448: - There was a bunch of unrelated issues with HDFS, even before

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-07-27 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560586#comment-16560586 ] genericqa commented on YARN-8448: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-07-27 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560254#comment-16560254 ] Robert Kanter commented on YARN-8448: - The 002 patch is mostly just some refactoring to split

[jira] [Commented] (YARN-8448) AM HTTPS Support

2018-07-25 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556364#comment-16556364 ] Robert Kanter commented on YARN-8448: - I've finished up a patch that implements everything described