[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657044#comment-16657044
]
Eric Yang commented on YARN-8448:
-
[~rkanter] This patch has a problem with clean up
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652431#comment-16652431
]
Hudson commented on YARN-8448:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #15230 (See
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652392#comment-16652392
]
Haibo Chen commented on YARN-8448:
--
I ran the cestest locally and it did not fail for me either. +1 on
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652181#comment-16652181
]
Robert Kanter commented on YARN-8448:
-
{{TestCapacityOverTimePolicy}} failure is unrelated. I'm not
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651016#comment-16651016
]
Hadoop QA commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650740#comment-16650740
]
Robert Kanter commented on YARN-8448:
-
Thanks [~haibochen] for another review.
The license issue is
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650587#comment-16650587
]
Haibo Chen commented on YARN-8448:
--
Thanks [~rkanter] for addressing the comments!
{quote}The only
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648742#comment-16648742
]
Hadoop QA commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648614#comment-16648614
]
Robert Kanter commented on YARN-8448:
-
Thanks for the feedback {{haibochen}}! Some comments:
{quote}In
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648434#comment-16648434
]
Haibo Chen commented on YARN-8448:
--
For the ProxyCA related changes, I have a few questions/comments.
1)
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648293#comment-16648293
]
Haibo Chen commented on YARN-8448:
--
A few minor comments/questions about the c code changes.
1) In
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647227#comment-16647227
]
Hadoop QA commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647209#comment-16647209
]
Haibo Chen commented on YARN-8448:
--
Thanks [~rkanter] for the patch update! Posting some of my comments
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647210#comment-16647210
]
Haibo Chen commented on YARN-8448:
--
I'll continue the review tomorrow and post remaining comments, if
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647168#comment-16647168
]
Robert Kanter commented on YARN-8448:
-
I see, thanks for the details [~jlowe] - it's been a while
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647131#comment-16647131
]
Jason Lowe commented on YARN-8448:
--
bq. The cc warning isn't a problem.
IMHO the warning should be
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646811#comment-16646811
]
Robert Kanter commented on YARN-8448:
-
- The cc warning isn't a problem. It's complaining that I'm
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646106#comment-16646106
]
Hadoop QA commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645928#comment-16645928
]
Robert Kanter commented on YARN-8448:
-
The 007 patch:
- Rebased on latest trunk
- Removed pom changes
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644059#comment-16644059
]
Robert Kanter commented on YARN-8448:
-
I discussed this with [~haibochen] offline and we agreed that
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643719#comment-16643719
]
Haibo Chen commented on YARN-8448:
--
Thanks [~rkanter] for the elaboration. OFF is what YARN does as of
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642647#comment-16642647
]
Robert Kanter commented on YARN-8448:
-
Thanks [~haibochen] for the review. That's a good idea about
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642603#comment-16642603
]
Haibo Chen commented on YARN-8448:
--
Thanks [~rkanter] for the the patch. I took a high-level look. The
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638522#comment-16638522
]
Robert Kanter commented on YARN-8448:
-
Test failures seem unrelated - they all pass locally for me.
>
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636430#comment-16636430
]
Hadoop QA commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636254#comment-16636254
]
Robert Kanter commented on YARN-8448:
-
I've kicked off another run after fixing trunk (it wasn't
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636229#comment-16636229
]
Hadoop QA commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635808#comment-16635808
]
Robert Kanter commented on YARN-8448:
-
Thanks for the review [~snemeth]. I was on PTO but am back
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582321#comment-16582321
]
Szilard Nemeth commented on YARN-8448:
--
Hey [~rkanter]!
Here are my review comments:
- hadoop
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571030#comment-16571030
]
genericqa commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570703#comment-16570703
]
Robert Kanter commented on YARN-8448:
-
The 005 patch:
- Fixes the unit tests. It turns out we do
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569068#comment-16569068
]
genericqa commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568819#comment-16568819
]
Robert Kanter commented on YARN-8448:
-
- Existing mvnsite failure and findbugs with ozone and hdds are
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567616#comment-16567616
]
genericqa commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567078#comment-16567078
]
Robert Kanter commented on YARN-8448:
-
I'm not sure where Jenkins went, so I've just kicked one off
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562482#comment-16562482
]
Robert Kanter commented on YARN-8448:
-
There was a bunch of unrelated issues with HDFS, even before
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560586#comment-16560586
]
genericqa commented on YARN-8448:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560254#comment-16560254
]
Robert Kanter commented on YARN-8448:
-
The 002 patch is mostly just some refactoring to split
[
https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556364#comment-16556364
]
Robert Kanter commented on YARN-8448:
-
I've finished up a patch that implements everything described
39 matches
Mail list logo