Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Stanislav Brabec
Igor Grinberg wrote: > Stanislav, > Can't you define a fixed voltage regulator for the ads7846 in spitz board > file? > This shouldn't be a hard task and is the right solution from the regulator > API POV. Yes, I can. ADS7846 needs more definitions in the platform file to work well on spitz. T

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Igor Grinberg
On 06/30/11 21:01, Mark Brown wrote: > On Thu, Jun 30, 2011 at 08:40:40PM +0300, Igor Grinberg wrote: >> On 06/30/11 19:13, Stanislav Brabec wrote: > >>> I seen two >>> proposals: >>> - As ADS7846 hardware does not require dedicated regulator, don't >>> require it in driver and fail only on pl

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Mark Brown
On Thu, Jun 30, 2011 at 08:40:40PM +0300, Igor Grinberg wrote: > On 06/30/11 19:13, Stanislav Brabec wrote: > > Igor Grinberg wrote: > >> I thought we've finished discussing the regulator issue... > > The discussion ended without a fix (at least for spitz). > Well, the discussion was mainly abou

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Igor Grinberg
On 06/30/11 19:13, Stanislav Brabec wrote: > Igor Grinberg wrote: >> On 06/30/11 17:45, Stanislav Brabec wrote: >> I want to >>> add .needs_regulator bool to ads7846.c and send the patch again to the >>> list. >> Please, don't... >> I thought we've finished discussing the regulator issue... > The

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Igor Grinberg
On 06/30/11 17:45, Stanislav Brabec wrote: > Marek Vasut wrote: >> On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote: >>> Hallo. >>> >>> These Oops and kernel panic were observed on a Zaurus (spitz) machine >>> (ARMv5, PXA270). >> Looks similar to "Re: [PATCH v2] Input: Make ADS7846 in

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Stanislav Brabec
Pavel Herrmann wrote: > On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote: > > Then I tried to apply "[PATCH] MAX: Fix race condition causing NULL > > > So I guess that MAX AC voltage reading (via SPI) was involved in an > > incorrect moment and race happened there and your MA

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Stanislav Brabec
Igor Grinberg wrote: > On 06/30/11 17:45, Stanislav Brabec wrote: > I want to > > add .needs_regulator bool to ads7846.c and send the patch again to the > > list. > > Please, don't... > I thought we've finished discussing the regulator issue... The discussion ended without a fix (at least for spi

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Mark Brown
On Thu, Jun 30, 2011 at 06:25:51PM +0300, Igor Grinberg wrote: > On 06/30/11 17:45, Stanislav Brabec wrote: > > from this thread. Without it, ADS7846 does not work on spitz (ADS7846 > > does not have any dedicated regulator there). I want to > > add .needs_regulator bool to ads7846.c and send the

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Pavel Herrmann
On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote: > Then I tried to apply "[PATCH] MAX: Fix race condition causing NULL > pointer exception", connected charger that periodically disconnects and > not seen the crash again. No OOPS was seen after ~100 reconnects. > > So I guess that

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Marek Vasut
On Thursday, June 30, 2011 04:45:18 PM Stanislav Brabec wrote: > Marek Vasut wrote: > > On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote: > > > Hallo. > > > > > > These Oops and kernel panic were observed on a Zaurus (spitz) machine > > > (ARMv5, PXA270). > > > > Looks similar to "Re

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Stanislav Brabec
Marek Vasut wrote: > On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote: > > Hallo. > > > > These Oops and kernel panic were observed on a Zaurus (spitz) machine > > (ARMv5, PXA270). > > Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on regulator" I don't see any tra

Re: [Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-30 Thread Marek Vasut
On Thursday, June 23, 2011 06:09:40 PM Stanislav Brabec wrote: > Hallo. > > These Oops and kernel panic were observed on a Zaurus (spitz) machine > (ARMv5, PXA270). Looks similar to "Re: [PATCH v2] Input: Make ADS7846 independent on regulator" CCing previously involved people, I'd like to see th

[Zaurus-devel] kernel panic in spi_complete() on spitz (PXA270)

2011-06-23 Thread Stanislav Brabec
Hallo. These Oops and kernel panic were observed on a Zaurus (spitz) machine (ARMv5, PXA270). Kernel version: config-3.0.0-rc4+ (2992c4b) Unable to handle kernel NULL pointer dereference at virtual address pgd = c0004000 [] *pgd= Internal error: Oops: 17 [#1] PREEMPT Mod