I like the last one :)
On Fri, Feb 10, 2012 at 12:30 PM, Siegfried Gevatter wrote:
> Review: Approve
>
> OK, merging it, but there's some outstanding stuff:
>
> * Important: the TableLookup in FTS can currently explode. The new schema
> version needs to add AUTOINCREMENT to the `id' row of all t
The proposal to merge lp:~zeitgeist/zeitgeist/fts++ into lp:zeitgeist has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/fts++/+merge/92022
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fts++/+merge/92022
Your team Ze
Review: Approve
OK, merging it, but there's some outstanding stuff:
* Important: the TableLookup in FTS can currently explode. The new schema
version needs to add AUTOINCREMENT to the `id' row of all tables in
TableLookup. We should do this before releasing a new tarball.
* TableLookup.get_v
I have been using it for 2 days now...
I noticed an small increase in memory consumption around 2-4 MB
However this is nothing that really bothers me
AWESOME WORK
On Thu, Feb 9, 2012 at 11:47 AM, Mikkel Kamstrup Erlandsen <
mikkel.kamst...@gmail.com> wrote:
> Review: Approve
>
> Looking good to m
Review: Approve
Looking good to me. I'd like someone else to +1 it before we merge though...
Outstanding work Michal!
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fts++/+merge/92022
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
__
> > Functionally tested in Unity and working well. Unit tests passing. However -
> >
> > There seems to be a fairly bad leak somewhere. Try repeatedly searching for
> > 'u' or something like that and you'll see the memory consumption go up
> fairly
> > fast.
>
> Nope, sorry can't reproduce that, t
> Functionally tested in Unity and working well. Unit tests passing. However -
>
> There seems to be a fairly bad leak somewhere. Try repeatedly searching for
> 'u' or something like that and you'll see the memory consumption go up fairly
> fast.
Nope, sorry can't reproduce that, the first search
1550+void Indexer::DropIndex ()
Are we not leaking db and enquire in this method?
--
https://code.launchpad.net/~zeitgeist/zeitgeist/fts++/+merge/92022
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.
___
Mailing list: https
Review: Needs Fixing
1583+void Indexer::Flush ()
1584+{
1585+ db->flush ();
1586+}
This need to be Commit() and db->commit(). See
http://xapian.org/docs/apidoc/html/classXapian_1_1WritableDatabase.html#cbea2163142de795024880a7123bc693.
You should probably also surround it with a
Review: Needs Fixing
Functionally tested in Unity and working well. Unit tests passing. However -
There seems to be a fairly bad leak somewhere. Try repeatedly searching for 'u'
or something like that and you'll see the memory consumption go up fairly fast.
--
https://code.launchpad.net/~zeitge
The proposal to merge lp:~zeitgeist/zeitgeist/fts++ into lp:zeitgeist has been
updated.
Description changed to:
More core changes so we can implement the new FTS daemon, plus the daemon
itself.
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/fts++/+merge/92022
--
https:
> Awesome! C++ FTS ftw.
>
> - Add COPYING.GPL3, otherwise the tarball can't be re-distributed.
>
On it...
> - Considering sharing a get_flags_for_log_level or even set_log_level
> function between ZG and FTS?
>
I don't think that's really necessary, strictly speaking it'd be a utility
func
Review: Needs Fixing
Awesome! C++ FTS ftw.
- Add COPYING.GPL3, otherwise the tarball can't be re-distributed.
- Considering sharing a get_flags_for_log_level or even set_log_level
function between ZG and FTS?
- s/ver != DatabaseSchema.CORE_SCHEMA_VERSION)/ver <
DatabaseSchema.CORE_SCHEMA_VER
13 matches
Mail list logo
