The proposal to merge lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212
--
https://code.launchpad.net/~zeitgeist/zeitgeist/storagemoni
Review: Approve
Alright, I've tested it with Network Manager and it seems to work fine. Awesome
work!
Since I love nitpicking so much, "self._up ()" could be changed to "self._up()"
:P. But anyway, I think this is ready to merge as soon as dbschema4 goes in
(outstanding issues for that are deci
Review: Needs Fixing
[2011-03-04 22:48:11,119] - ERROR - zeitgeist.extension - Failed loading the
'StorageMonitor' extension
Traceback (most recent call last):
File
"/home/rainct/Desenvolupament/Python/zeitgeist-project/storagemonitor2/zeitgeist/../_zeitgeist/engine/extension.py",
line 265, in
Haven't tried it yet, but the code looks good to me (although I still think a
baseclass would be neat :P).
--
https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/storagemonitor2.
> > "lambda : "
> The space before the colons looks ugly :P.
Fixed
> > "except:"
> Please make this "except sqlite3.foobar" (or, worst-case, "except Exception").
> Also, why do you need the rollback there?
Since sqlite3 doesn't have a common error super class I am just catching
Exception for no
Review: Needs Fixing
> "lambda : "
The space before the colons looks ugly :P.
> "except:"
Please make this "except sqlite3.foobar" (or, worst-case, "except Exception").
Also, why do you need the rollback there?
> "A storage medium is indetified by a key"
How can I indetify you? :)
You could move
Review: Needs Fixing
+logging.basicConfig(level=logging.DEBUG)
WHY?
And why is this and the imports there twice (before and after the big comments)?
+# storgaemonitor extension. This is actually backwards compatible.
Storgae? Is that like 'deine mudda' in Danish?
--
https://code.launchpad.net/
Mikkel Kamstrup Erlandsen has proposed merging
lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
Related bugs:
#489194 Implement storage monitor (devices and connectivity)
https://bugs.launchpad.net/bugs/489194
For more detai
8 matches
Mail list logo
