[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~zeitgeist/zeitgeist/symbols/+merge/69927 Symbols class for generating symbols that

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

Review: Needs Fixing - /* datamodel.vala ontology - public static HashTable SymbolsCollection = null; rename all_symbols, put it into Symbol (it's static), make it private - displayName, allChildren display_name, all_children - why are you messing with GenericArray<->List? (parents, etc.) th

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

Review: Needs Fixing I find the Symbol class just an implementation detail, there's no need to expose it at all, as RainCT said you'll want to use static functions with signature like `string[] Symbol.get_children (string uri)`, or `string Symbol.get_description (string uri)` (of course we can u

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/symbols into lp:~zeitgeist/zeitgeist/bluebird

> - /* datamodel.vala > ontology > > - public static HashTable SymbolsCollection = null; > rename all_symbols, put it into Symbol (it's static), make it private > why put it in symbol? > - displayName, allChildren > display_name, all_children ok > > - why are you messing with GenericArra