The proposal to merge lp:~zeitgeist/zeitgeist/symbols into
lp:~zeitgeist/zeitgeist/bluebird has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/symbols/+merge/69927
--
https://code.launchpad.net/~zeitgeist/zeitgeist/symbols
Review: Needs Fixing
My point is that the Symbol class itself shouldn't even be public, it should be
something private to this source file.
Method that this file needs to expose are (all of them are static):
List Symbol.get_parents (string uri)
List Symbol.get_children (string uri)
List Symbol.g
you can get the immidiate stuff by asking for the properties, parents and
children...
I will just change the names to get_all_parents
On Mon, Aug 1, 2011 at 1:55 PM, Michal Hruby wrote:
> Review: Needs Fixing
> Since you made get_parents return all parents, there's now no way to get
> the immedi
Review: Needs Fixing
Since you made get_parents return all parents, there's now no way to get the
immediate parents and therefore reconstruct the original ontology graph easily.
Fix pls...
--
https://code.launchpad.net/~zeitgeist/zeitgeist/symbols/+merge/69927
Your team Zeitgeist Framework Team
> - /* datamodel.vala
> ontology
>
> - public static HashTable SymbolsCollection = null;
> rename all_symbols, put it into Symbol (it's static), make it private
>
why put it in symbol?
> - displayName, allChildren
> display_name, all_children
ok
>
> - why are you messing with GenericArra
Review: Needs Fixing
I find the Symbol class just an implementation detail, there's no need to
expose it at all, as RainCT said you'll want to use static functions with
signature like `string[] Symbol.get_children (string uri)`, or `string
Symbol.get_description (string uri)` (of course we can u
Review: Needs Fixing
- /* datamodel.vala
ontology
- public static HashTable SymbolsCollection = null;
rename all_symbols, put it into Symbol (it's static), make it private
- displayName, allChildren
display_name, all_children
- why are you messing with GenericArray<->List? (parents, etc.)
th
Seif Lotfy has proposed merging lp:~zeitgeist/zeitgeist/symbols into
lp:~zeitgeist/zeitgeist/bluebird.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/symbols/+merge/69927
Symbols class for generating symbols that
8 matches
Mail list logo
