Jim Fulton wrote:
> On Wed, Nov 18, 2009 at 12:00 PM, Chris Withers
> wrote:
>> - Anyone know what to replace md5 with? The warning suggests hashlib,
>
> Yes
>
>> which landed in 2.5. I assume it's okay to just use hashlib rather than
>> worry about conditionally import md5 or hashlib, given th
Chris Withers wrote:
> Jim Fulton wrote:
>> I'm fine with change the storage server to pass the history size
>> argument as a keyword parameter.
>
> Okay, but where is the Z309 equivalent of ZEOStorage308Adapter's history
> method?
Ug, the answer is much less pleasant :-(
So, a ZODB 3.9.3 Clien
On Thu, Nov 19, 2009 at 4:50 PM, Chris Withers wrote:
> Jim Fulton wrote:
>>
>> On Wed, Nov 18, 2009 at 12:00 PM, Chris Withers
>> wrote:
>>>
>>> - Anyone know what to replace md5 with? The warning suggests hashlib,
>>
>> Yes
>>
>>> which landed in 2.5. I assume it's okay to just use hashlib rath
Jim Fulton wrote:
>>> It's easy to handle this with a test on sys.version_info.
>> OK, this is all done on trunk and 3.9 branch, I ran the test script with
>> Python 2.4 and 2.6, no errors.
>
> Cool, but can we please get an automated test? I don't run the manual
> tests. I never will. :)
I'm afr
On Thu, Nov 19, 2009 at 5:38 PM, Chris Withers wrote:
> Chris Withers wrote:
>>
>> Jim Fulton wrote:
>>>
>>> I'm fine with change the storage server to pass the history size
>>> argument as a keyword parameter.
>>
>> Okay, but where is the Z309 equivalent of ZEOStorage308Adapter's history
>> metho
On Thu, Nov 19, 2009 at 5:41 PM, Chris Withers wrote:
> Jim Fulton wrote:
It's easy to handle this with a test on sys.version_info.
>>>
>>> OK, this is all done on trunk and 3.9 branch, I ran the test script with
>>> Python 2.4 and 2.6, no errors.
>>
>> Cool, but can we please get an aut
Jim Fulton wrote:
> What's wrong with the original idea of having the server pass the size
> as a keyword parameter? The ZEO protocol is irrelevant.
Okay, from the top:
>> So, a ZODB 3.9.3 ClientStorage calls the ServerStub's history method, this
>> does an rpc call:
>>
>> self.rpc.call('history'
Jim Fulton wrote:
>> Also feels like a bit of an ask for fixing a deprecation warning bug ;-)
>
> I don't follow that. Isn't that what you did?
No, I ran an existing test script with two versions of python and
verified that it worked as expected in both cases, with no deprecation
warning being
On Thu, Nov 19, 2009 at 5:55 PM, Chris Withers wrote:
> Jim Fulton wrote:
>>
>> What's wrong with the original idea of having the server pass the size
>> as a keyword parameter? The ZEO protocol is irrelevant.
>
> Okay, from the top:
>
>>> So, a ZODB 3.9.3 ClientStorage calls the ServerStub's hist
Jim Fulton wrote:
> So why not add a history method to ZEOStorage that passes size as a
> keyword argument?
I don't know what "ZEOStorage" is...
zrpc.connection.Connection appears to despatch direct to the storage,
please correct me if I'm wrong.
In this case, that's a RAIDStorage. It doesn't h
On Thu, Nov 19, 2009 at 6:07 PM, Chris Withers wrote:
> Jim Fulton wrote:
>>
>> So why not add a history method to ZEOStorage that passes size as a
>> keyword argument?
>
> I don't know what "ZEOStorage" is...
Then we shouldn't be having this conversation.
Jim
--
Jim Fulton
___
On Thu, Nov 19, 2009 at 5:59 PM, Chris Withers wrote:
> Jim Fulton wrote:
>>>
>>> Also feels like a bit of an ask for fixing a deprecation warning bug ;-)
>>
>> I don't follow that. Isn't that what you did?
>
> No, I ran an existing test script with two versions of python and verified
> that it w
Jim Fulton wrote:
> There's nothing official or supported about a backup solution without
> automated tests.
>
> So I guess there isn't one.
Right, so what does Zope Corp use?
Chris
--
Simplistix - Content Management, Batch Processing & Python Consulting
- http://www.simplistix.co.
Jim Fulton wrote:
> On Thu, Nov 19, 2009 at 6:07 PM, Chris Withers wrote:
>> Jim Fulton wrote:
>>> So why not add a history method to ZEOStorage that passes size as a
>>> keyword argument?
>> I don't know what "ZEOStorage" is...
>
> Then we shouldn't be having this conversation.
I'm working off
On 11/20/2009 01:07 AM, Chris Withers wrote:
> Jim Fulton wrote:
>> On Thu, Nov 19, 2009 at 6:07 PM, Chris Withers
>> wrote:
>>> Jim Fulton wrote:
So why not add a history method to ZEOStorage that passes size as a
keyword argument?
>>> I don't know what "ZEOStorage" is...
See StorageS
15 matches
Mail list logo