Re: [zones-discuss] code review for 6495558

2009-12-17 Thread Jerry Jelinek
Frank Batschulat (Home) wrote: Hey Ed, Steve, Jordan, Jerry, I got it in writing from Veritas Engineering that they do not have any heartburn over using "fsck -o p" on VxFS and inside the zone and also by testing in the lab I confirmed it behaves as expected and similar to UFS: # uname -a Sun

Re: [zones-discuss] code review for 6495558

2009-12-17 Thread Edward Pilatowicz
lgtm. ed On Thu, Dec 17, 2009 at 07:34:08PM +0100, Frank Batschulat (Home) wrote: > Hey Ed, Steve, Jordan, Jerry, > > I got it in writing from Veritas Engineering that they do not have any > heartburn > over using "fsck -o p" on VxFS and inside the zone and also by testing in the > lab I > confi

Re: [zones-discuss] code review for 6495558

2009-12-17 Thread Frank Batschulat (Home)
Hey Ed, Steve, Jordan, Jerry, I got it in writing from Veritas Engineering that they do not have any heartburn over using "fsck -o p" on VxFS and inside the zone and also by testing in the lab I confirmed it behaves as expected and similar to UFS: # uname -a SunOS lab234 5.10 Generic_139555-08

Re: [zones-discuss] code review for 6495558

2009-12-14 Thread Frank Batschulat (Home)
valid point, Ed! ignoring the minor detail that my fix should really do 'fsck -o p" (new webrev is in progress, thanks Steve for catching my ignorance) in fact "-o p" is documented in the generic fsck(1M) man page. -o specific-options p Check and fix the file s

Re: [zones-discuss] code review for 6495558

2009-12-14 Thread Edward Pilatowicz
so just one question. the '-p' preen option is only documented in the fsck_ufs(1m) man page, and not in fsck(1m). so i'm wondering is are there zones which may be installed on other filesystems which supply an fsck utility which may not support the preen option? (or perhas '-p is defined as some

Re: [zones-discuss] code review for 6495558

2009-12-11 Thread Jordan Vaughan
On 12/11/09 05:24 AM, Frank Batschulat (Home) wrote: friends, may I request code review for the earth-shattering fix to: 6495558 zoneadm -z boot should not only check but repair filesystems http://cr.opensolaris.org/~batschul/onnv-vplat/ backround: Evaluation when booting a zone, zoneadm ( i

Re: [zones-discuss] code review for 6495558

2009-12-11 Thread Jerry Jelinek
Frank Batschulat (Home) wrote: friends, may I request code review for the earth-shattering fix to: 6495558 zoneadm -z boot should not only check but repair filesystems http://cr.opensolaris.org/~batschul/onnv-vplat/ backround: Evaluation when booting a zone, zoneadm ( ie. vplat.c:dofsck() )

[zones-discuss] code review for 6495558

2009-12-11 Thread Frank Batschulat (Home)
friends, may I request code review for the earth-shattering fix to: 6495558 zoneadm -z boot should not only check but repair filesystems http://cr.opensolaris.org/~batschul/onnv-vplat/ backround: Evaluation when booting a zone, zoneadm ( ie. vplat.c:dofsck() ) should perform the same tasks as