Jordan Vaughan wrote:
I have a few nits. Some of them (such at [3]) might be ridiculously
trivial, so I won't complain if you don't take them into account.
Jordan,
Thanks for reviewing this. I'll make all of the simplifications
you suggested.
Thanks again,
Jerry
On 06/15/09 09:39, Jerry Jelinek wrote:
I need a code review for the fix for:
ssh dumping core on maramba
There is a webrev at:
http://cr.opensolaris.org/~gjelinek/webrev.crypto/
Thanks,
Jerry
___
zones-discuss mailing list
zones-discuss@opensolaris
On Mon, Jun 15, 2009 at 11:54:46AM -0600, Jerry Jelinek wrote:
> Ed,
>
> Thanks for reviewing this.
>
> Edward Pilatowicz wrote:
>> - you might want to add the crypto libraries to the list of libraries
>> to watch for breakage. ;)
>
> Yep. :-) I'm also going to try to see if any of the other de
Ed,
Thanks for reviewing this.
Edward Pilatowicz wrote:
- you might want to add the crypto libraries to the list of libraries
to watch for breakage. ;)
Yep. :-) I'm also going to try to see if any of the other default devices
that are inside of a zone might have had their ioctl params cha
- you might want to add the crypto libraries to the list of libraries
to watch for breakage. ;)
- to improve the readability of crypto_ioctl(), could you make a
dedicated function or macro that just does translation between
the s10 and nevada versions of crypto_get_function_list_t?
- when
I need a code review for the fix for:
ssh dumping core on maramba
There is a webrev at:
http://cr.opensolaris.org/~gjelinek/webrev.crypto/
Thanks,
Jerry
___
zones-discuss mailing list
zones-discuss@opensolaris.org