Re: feedback zkclient

2009-10-01 Thread Patrick Hunt
I started looking a bit more closely at the source, some questions: 1) I tried generating the javadocs (see my fork of the project on github if you want my changes to build.xml for this) but it looks like there's pretty much no javadoc. Some information, particularly on semantics of

Re: feedback zkclient

2009-10-01 Thread Peter Voss
Hi Patrick, On 01.10.2009, at 08:57, Patrick Hunt wrote: I started looking a bit more closely at the source, some questions: 1) I tried generating the javadocs (see my fork of the project on github if you want my changes to build.xml for this) but it looks like there's pretty much no

Re: feedback zkclient

2009-10-01 Thread Ted Dunning
I think that another way to say this is that zkClient is going a bit for the Spring philosophy that if the caller can't (or won't) be handling the situation, then they shouldn't be forced to declare it. The Spring jdbcTemplate is a grand example of the benefits of this. First implementations of

Re: feedback zkclient

2009-10-01 Thread Ted Dunning
There is not much way to totally avoid this without massive performance loss because the connection loss could be during the the time that the confirmation is returning. You may be able to tell if the file is yours be examining the content and ownership, but this is pretty implementation

Re: feedback zkclient

2009-10-01 Thread Adam Rosien
I'm on the fence about checked vs. unchecked, but I think Javadoc that declares what exceptions are thrown would help users figure out if they might want to catch something. Additionally some of the ZkClient method semantics are confusing. For example, create() returns the path of the created

Re: feedback zkclient

2009-10-01 Thread Patrick Hunt
Peter Voss wrote: On 01.10.2009, at 08:57, Patrick Hunt wrote: 2) what purpose does ZkEventThread serve? ZkClient updates it's connection state from the ZooKeeper events. Based on these it notifies listeners, updates it's connection state or reconnects to ZooKeeper. ZkClient has its own

Re: feedback zkclient

2009-10-01 Thread Patrick Hunt
Not to harp on this ;-) but this sounds like something that would be a very helpful addition to the README. Ted Dunning wrote: I think that another way to say this is that zkClient is going a bit for the Spring philosophy that if the caller can't (or won't) be handling the situation, then they

Re: feedback zkclient

2009-10-01 Thread Ted Dunning
That looks really lovely. Judging by history and that fact that only 40/127 issues are resolved, 3.3 is probably 3-6 months away. Is that a fair assessment? On Thu, Oct 1, 2009 at 11:13 AM, Patrick Hunt ph...@apache.org wrote: One nice thing about ephemeral is that the Stat contains the owner

Re: feedback zkclient

2009-10-01 Thread Patrick Hunt
Ted Dunning wrote: Judging by history and that fact that only 40/127 issues are resolved, 3.3 is probably 3-6 months away. Is that a fair assessment? Yes, that's fair. Patrick On Thu, Oct 1, 2009 at 11:13 AM, Patrick Hunt ph...@apache.org wrote: One nice thing about ephemeral is that the

[jira] Created: (ZOOKEEPER-539) generate eclipse project via ant target

2009-10-01 Thread Patrick Hunt (JIRA)
generate eclipse project via ant target --- Key: ZOOKEEPER-539 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-539 Project: Zookeeper Issue Type: New Feature Components: build

[jira] Updated: (ZOOKEEPER-532) java compiler should be target Java 1.5

2009-10-01 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-532: --- Status: Open (was: Patch Available) java compiler should be target Java 1.5

[jira] Commented: (ZOOKEEPER-539) generate eclipse project via ant target

2009-10-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761345#action_12761345 ] Hadoop QA commented on ZOOKEEPER-539: - -1 overall. Here are the results of testing

[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython

2009-10-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761349#action_12761349 ] Hadoop QA commented on ZOOKEEPER-420: - +1 overall. Here are the results of testing

[jira] Updated: (ZOOKEEPER-420) build/test should not require install in zkpython

2009-10-01 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-420: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch

[jira] Created: (ZOOKEEPER-540) zkpython needs better tracking of handle validity

2009-10-01 Thread Patrick Hunt (JIRA)
zkpython needs better tracking of handle validity - Key: ZOOKEEPER-540 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-540 Project: Zookeeper Issue Type: Bug Components:

[jira] Commented: (ZOOKEEPER-538) zookeeper.async causes python to segfault

2009-10-01 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761362#action_12761362 ] Patrick Hunt commented on ZOOKEEPER-538: Disregard my last comment - the patch

[jira] Updated: (ZOOKEEPER-538) zookeeper.async causes python to segfault

2009-10-01 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-538: --- Status: Patch Available (was: Open) zookeeper.async causes python to segfault

[jira] Updated: (ZOOKEEPER-538) zookeeper.async causes python to segfault

2009-10-01 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-538: --- Attachment: callback.patch same as previous patch except added async test.

[jira] Commented: (ZOOKEEPER-538) zookeeper.async causes python to segfault

2009-10-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761377#action_12761377 ] Hadoop QA commented on ZOOKEEPER-538: - +1 overall. Here are the results of testing

[jira] Updated: (ZOOKEEPER-510) zkpython lumps all exceptions as IOError, needs specialized exceptions for KeeperException types

2009-10-01 Thread Henry Robinson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-510: - Attachment: ZOOKEEPER-510.patch This patch adds all the exceptions that the Java

[jira] Updated: (ZOOKEEPER-538) zookeeper.async causes python to segfault

2009-10-01 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-538: --- Resolution: Fixed Fix Version/s: 3.3.0 Hadoop Flags: [Reviewed]