[jira] Updated: (ZOOKEEPER-227) gcc warning from recordio.h
[ https://issues.apache.org/jira/browse/ZOOKEEPER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-227: --- Fix Version/s: 3.0.1 let's try to get this one into 3.0.1 > gcc warning from recordio.h > --- > > Key: ZOOKEEPER-227 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 >Reporter: Chris Darroch >Assignee: Chris Darroch >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: zookeeper-recordio-trunk.patch > > > Recent gcc compilers issue warnings when function declarations for functions > with no arguments don't specific "void". The attached patch fixes one such > warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-64) We should log system env information when intializing client/server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-64: --- Hadoop Flags: [Reviewed] +1 Excellent. > We should log system env information when intializing client/server > --- > > Key: ZOOKEEPER-64 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-64 > Project: Zookeeper > Issue Type: Improvement > Components: c client, java client, server >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: ZOOKEEPER-64.patch > > > We should log system environment information (as much as possible) during > both client & server initialization. This will help with debugging of > customer issues. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-208: Attachment: ZOOKEEPER-208.patch Updated the tests to not look for usage of gethostbyname. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-208.patch, > zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-208: Status: Patch Available (was: Open) > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-208.patch, > zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-204) SetWatches needs to be the first message after auth messages to the server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-204: Attachment: ZOOKEEPER-204.patch made a few changes regarding logging and formatting otherwise +1 > SetWatches needs to be the first message after auth messages to the server > -- > > Key: ZOOKEEPER-204 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-204 > Project: Zookeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.0.0 >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-204.patch, ZOOKEEPER-204.patch, > ZOOKEEPER-204.patch, ZOOKEEPER-204.patch > > > When the ZooKeeper java client makes a connection it queues a SetWatches > request. The problem is that it puts the request at the end of the outgoing > requests. This means that watches for requests that were queued before the > connection is made and after the disconnect may improperly get their watches > triggered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-211) Not all Mock tests are working
[ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-211: --- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Looks good, +1 branch: Committed revision 718831. trunk: Committed revision 718832. > Not all Mock tests are working > -- > > Key: ZOOKEEPER-211 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211 > Project: Zookeeper > Issue Type: Test > Components: c client >Reporter: Benjamin Reed >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-211.patch > > > For the 3.0 release there was a bug in the ZKMock code that prevented some > tests from working. This patch fixes the bug and reenables the tests. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-208: --- Status: Open (was: Patch Available) Cancelling the patch: the c unit tests are failing (ubuntu) with this patch applied: Zookeeper_init::testAddressResolution : assertion (more) Also, I just realized - the configure.ac file should be updated for the new functions used (notice gethostbyname is there in .ac file, need to add strtok_r, getaddrinfo, etc... ). Might also be a good idea to verify this build on window/linux/freebsd. It built fine on ubuntu. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.0.1, 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-226) exists calls fails on server if node has null data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-226: Resolution: Fixed Status: Resolved (was: Patch Available) committed to 718799 in trunk and 718801 in 3.0 branch. > exists calls fails on server if node has null data > -- > > Key: ZOOKEEPER-226 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-226.patch > > > An NPE will be generated on the server (and resulting in client getting > MarshallingException) if exists() is called on a node with null data. > workaround is to create the node with non-null data. > be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-204) SetWatches needs to be the first message after auth messages to the server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-204: Attachment: ZOOKEEPER-204.patch Good catch Flavio. Uploaded a fixed version. > SetWatches needs to be the first message after auth messages to the server > -- > > Key: ZOOKEEPER-204 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-204 > Project: Zookeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.0.0 >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-204.patch, ZOOKEEPER-204.patch, > ZOOKEEPER-204.patch > > > When the ZooKeeper java client makes a connection it queues a SetWatches > request. The problem is that it puts the request at the end of the outgoing > requests. This means that watches for requests that were queued before the > connection is made and after the disconnect may improperly get their watches > triggered. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-206) documentation tab should contain the version number (and other small site changes)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-206: Resolution: Fixed Status: Resolved (was: Patch Available) committed to revision 718795 in 3.0 and revision 718768 in trunk. thanks pat. > documentation tab should contain the version number (and other small site > changes) > --- > > Key: ZOOKEEPER-206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-206 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-206_301.patch, ZOOKEEPER-206_trunk.patch > > > Feedback from Doug Cutting on 3.0.0 documentation: > - The "Zookeeper Documentation" tab should contain the version number. > - "Informal Documentation" might better be named "Other Documentation". > - The "Other Info" page should be removed, since it contains nothing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-208: Fix Version/s: 3.0.1 > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.0.1, 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-208: Hadoop Flags: [Reviewed] +1 great work. We should include this in 3.0.1 > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.0.1, 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-226) exists calls fails on server if node has null data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-226: Hadoop Flags: [Reviewed] +1 Ready to commit > exists calls fails on server if node has null data > -- > > Key: ZOOKEEPER-226 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-226.patch > > > An NPE will be generated on the server (and resulting in client getting > MarshallingException) if exists() is called on a node with null data. > workaround is to create the node with non-null data. > be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-206) documentation tab should contain the version number (and other small site changes)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-206: Hadoop Flags: [Reviewed] +1 for the patch... > documentation tab should contain the version number (and other small site > changes) > --- > > Key: ZOOKEEPER-206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-206 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-206_301.patch, ZOOKEEPER-206_trunk.patch > > > Feedback from Doug Cutting on 3.0.0 documentation: > - The "Zookeeper Documentation" tab should contain the version number. > - "Informal Documentation" might better be named "Other Documentation". > - The "Other Info" page should be removed, since it contains nothing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-206) documentation tab should contain the version number (and other small site changes)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648804#action_12648804 ] Benjamin Reed commented on ZOOKEEPER-206: - +1 > documentation tab should contain the version number (and other small site > changes) > --- > > Key: ZOOKEEPER-206 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-206 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-206_301.patch, ZOOKEEPER-206_trunk.patch > > > Feedback from Doug Cutting on 3.0.0 documentation: > - The "Zookeeper Documentation" tab should contain the version number. > - "Informal Documentation" might better be named "Other Documentation". > - The "Other Info" page should be removed, since it contains nothing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-221) log message in ZkWatchManager.materialize missing conditional
[
https://issues.apache.org/jira/browse/ZOOKEEPER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648802#action_12648802
]
Mahadev konar commented on ZOOKEEPER-221:
-
Looks like ZOOKEEPER-204 has the fix already.. can you verify?
> log message in ZkWatchManager.materialize missing conditional
> -
>
> Key: ZOOKEEPER-221
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-221
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.0.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.0.1, 3.1.0
>
> Attachments: ZOOKEEPER-221.patch
>
>
> the following code is missing conditional log call based on result of remove
> call (size > 0)
> // XXX This shouldn't be needed, but just in case
> > synchronized (existWatches) {
> > addTo(existWatches.remove(path), result);
> > LOG.warn("We are triggering an exists watch for delete! Shouldn't
> > happen!");
> > }
> >
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-218) error in barrier recipe example code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-218: Resolution: Fixed Status: Resolved (was: Patch Available) committed to revision 718758 in trunk and committed to revision 718759 in 3.0.0 branch. > error in barrier recipe example code > > > Key: ZOOKEEPER-218 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-218 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-218.patch > > > Report from user Murali Vemulapati. The wiki recipe page also should be > updated to handle multiple clients using the barrier on the same system > (multiple processes, etc...). Currently the docs/example support only a > single user of the barrier per host. > -- > I believe there is a typo in the barrier example given at: > http://hadoop.apache.org/zookeeper/docs/current/zookeeperTutorial.html > With the following fix, the program runs as expected: > == > 83c83 > < this.name = new > String(InetAddress.getLocalHost().getCanonicalHostName().toString()); > --- > > name = new > > String(InetAddress.getLocalHost().getCanonicalHostName().toString()); > 100c100 > < CreateMode.EPHEMERAL_SEQUENTIAL); > --- > > CreateMode.EPHEMERAL); > == > The first change assigns the name to the instance variable 'name' of Barrier > class (otherwise the 'name' instance variable will have a value of 'null' > when calling zk.create to create the child node under the root barrier node). > The second change lets us run multiple processes on the same machine. > thanks > murali -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-218) error in barrier recipe example code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-218: Hadoop Flags: [Reviewed] +1 for the patch... > error in barrier recipe example code > > > Key: ZOOKEEPER-218 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-218 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-218.patch > > > Report from user Murali Vemulapati. The wiki recipe page also should be > updated to handle multiple clients using the barrier on the same system > (multiple processes, etc...). Currently the docs/example support only a > single user of the barrier per host. > -- > I believe there is a typo in the barrier example given at: > http://hadoop.apache.org/zookeeper/docs/current/zookeeperTutorial.html > With the following fix, the program runs as expected: > == > 83c83 > < this.name = new > String(InetAddress.getLocalHost().getCanonicalHostName().toString()); > --- > > name = new > > String(InetAddress.getLocalHost().getCanonicalHostName().toString()); > 100c100 > < CreateMode.EPHEMERAL_SEQUENTIAL); > --- > > CreateMode.EPHEMERAL); > == > The first change assigns the name to the instance variable 'name' of Barrier > class (otherwise the 'name' instance variable will have a value of 'null' > when calling zk.create to create the child node under the root barrier node). > The second change lets us run multiple processes on the same machine. > thanks > murali -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-226) exists calls fails on server if node has null data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-226: Status: Patch Available (was: Open) > exists calls fails on server if node has null data > -- > > Key: ZOOKEEPER-226 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-226.patch > > > An NPE will be generated on the server (and resulting in client getting > MarshallingException) if exists() is called on a node with null data. > workaround is to create the node with non-null data. > be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-226) exists calls fails on server if node has null data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-226: Attachment: ZOOKEEPER-226.patch this patch fixes the issue and also adds a test. > exists calls fails on server if node has null data > -- > > Key: ZOOKEEPER-226 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-226.patch > > > An NPE will be generated on the server (and resulting in client getting > MarshallingException) if exists() is called on a node with null data. > workaround is to create the node with non-null data. > be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-229) improve documentation regarding user's responsibility to cleanup datadir (snaps/logs)
improve documentation regarding user's responsibility to cleanup datadir (snaps/logs) - Key: ZOOKEEPER-229 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-229 Project: Zookeeper Issue Type: Improvement Components: documentation, server Affects Versions: 3.0.0 Reporter: Patrick Hunt Fix For: 3.1.0 It's not very obvious in the docs that the operator of the zk server is responsible for managing the files in the datadir: http://hadoop.apache.org/zookeeper/docs/r3.0.0/zookeeperAdmin.html#File+Management specifically removing the old snaps/transactionallogs we need to make this more obvious, perhaps call it out in the quickstart (note pointing to this document) Perhaps we should include example script and cron as well (docs) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648757#action_12648757 ] phunt edited comment on ZOOKEEPER-208 at 11/18/08 1:18 PM: -- Great. Thanks much Austin! I'm marking this as "patch available" on behalf of the author for consideration in 3.1.0. was (Author: phunt): Great. Thanks much Austin! I'm marking this as "patch submitted" on behalf of the author for consideration in 3.1.0. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-208: --- Status: Patch Available (was: Open) Great. Thanks much Austin! I'm marking this as "patch submitted" on behalf of the author for consideration in 3.1.0. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648756#action_12648756 ] Austin Shoemaker commented on ZOOKEEPER-208: Chris, thanks for modifying my patch to comply with the project. I reattached it granting the license, let me know if I can help with anything else. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin Shoemaker updated ZOOKEEPER-208: --- Attachment: zookeeper-strtok_getaddrinfo-trunk.patch Reattaching patch with license granted. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch, > zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648750#action_12648750 ] Patrick Hunt commented on ZOOKEEPER-208: Arg, jira won't allow me to wipe this. I've also messaged the author directly through email. Let's see if that helps. > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[ https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-208: --- Comment: was deleted > Zookeeper C client uses API that are not thread safe, causing crashes when > multiple instances are active > > > Key: ZOOKEEPER-208 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 > Environment: Linux >Reporter: Austin Shoemaker >Assignee: Austin Shoemaker >Priority: Critical > Fix For: 3.1.0 > > Attachments: zookeeper-strtok_getaddrinfo-trunk.patch > > > The Zookeeper C client library uses gethostbyname and strtok, both of which > are not safe to use from multiple threads. > The problem is resolved by using getaddrinfo and strtok_r in place of the > older API. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[
https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-208:
---
Description:
The Zookeeper C client library uses gethostbyname and strtok, both of which are
not safe to use from multiple threads.
The problem is resolved by using getaddrinfo and strtok_r in place of the older
API.
was:
The Zookeeper C client library uses gethostbyname and strtok, both of which are
not safe to use from multiple threads. Below is the original patch we made
which fixes the problem.
The problem is resolved by using getaddrinfo and strtok_r in place of the older
API.
Patch for zookeeper-c-client-2.2.1/src/zookeeper.c (2008-06-09 on SF.net)
241c241
< struct hostent *he;
---
> struct addrinfo hints, *res, *res0;
243,245d242
< struct sockaddr_in *addr4;
< struct sockaddr_in6 *addr6;
< char **ptr;
247a245
> char *strtok_last;
263c261
< host=strtok(hosts, ",");
---
> host=strtok_r(hosts, ",", &strtok_last);
283,294c281,297
< he = gethostbyname(host);
< if (!he) {
< LOG_ERROR(("could not resolve %s", host));
< errno=EINVAL;
< rc=ZBADARGUMENTS;
< goto fail;
< }
<
< /* Setup the address array */
< for(ptr = he->h_addr_list;*ptr != 0; ptr++) {
< if (zh->addrs_count == alen) {
< void *tmpaddr;
---
>
> memset(&hints, 0, sizeof(hints));
> hints.ai_flags = AI_ADDRCONFIG;
> hints.ai_family = AF_UNSPEC;
> hints.ai_socktype = SOCK_STREAM;
> hints.ai_protocol = IPPROTO_TCP;
>
> if (getaddrinfo(host, port_spec, &hints, &res0) != 0) {
> LOG_ERROR(("getaddrinfo: %s\n", strerror(errno)));
> rc=ZSYSTEMERROR;
> goto fail;
> }
>
> for (res = res0; res; res = res->ai_next) {
> // Expand address list if needed
> if (zh->addrs_count == alen) {
> void *tmpaddr;
304,313c307,312
< }
< addr = &zh->addrs[zh->addrs_count];
< addr4 = (struct sockaddr_in*)addr;
< addr6 = (struct sockaddr_in6*)addr;
< addr->sa_family = he->h_addrtype;
< if (addr->sa_family == AF_INET) {
< addr4->sin_port = htons(port);
< memset(&addr4->sin_zero, 0, sizeof(addr4->sin_zero));
< memcpy(&addr4->sin_addr, *ptr, he->h_length);
< zh->addrs_count++;
---
> }
>
> // Copy addrinfo into address list
> addr = &zh->addrs[zh->addrs_count];
> switch (res->ai_family) {
> case AF_INET:
315,320c314
< } else if (addr->sa_family == AF_INET6) {
< addr6->sin6_port = htons(port);
< addr6->sin6_scope_id = 0;
< addr6->sin6_flowinfo = 0;
< memcpy(&addr6->sin6_addr, *ptr, he->h_length);
< zh->addrs_count++;
---
> case AF_INET6:
322,327c316,328
< } else {
< LOG_WARN(("skipping unknown address family %x for %s",
< addr->sa_family, zh->hostname));
< }
< }
< host = strtok(0, ",");
---
> memcpy(addr, res->ai_addr, res->ai_addrlen);
> ++zh->addrs_count;
> break;
> default:
> LOG_WARN(("skipping unknown address family %x
> for %s",
> res->ai_family, zh->hostname));
> break;
> }
> }
>
> freeaddrinfo(res0);
>
> host = strtok_r(0, ",", &strtok_last);
329a331
>
I've updated the summary now that the changes are attached. If the original
author doesn't approve then perhaps we can get someone who's untainted to
create a new patch.
> Zookeeper C client uses API that are not thread safe, causing crashes when
> multiple instances are active
>
>
> Key: ZOOKEEPER-208
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.0.0
> Environment: Linux
>Reporter: Austin Shoemaker
>Assignee: Austin Shoemaker
>Priority: Critical
> Fix For: 3.1.0
>
> Attachments: zookeeper-strtok_getaddrinfo-t
[jira] Updated: (ZOOKEEPER-208) Zookeeper C client uses API that are not thread safe, causing crashes when multiple instances are active
[
https://issues.apache.org/jira/browse/ZOOKEEPER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Darroch updated ZOOKEEPER-208:
Attachment: zookeeper-strtok_getaddrinfo-trunk.patch
I've reformatted the original submitter's normal patch as a unified diff file
to use against 3.0.0 and SVN trunk (at the moment).
I won't grant a license for it, though, since I didn't do the original work.
Hopefully this saves the submitter a little work. If they can just sign off on
this file, they shouldn't need to deal with any other details.
> Zookeeper C client uses API that are not thread safe, causing crashes when
> multiple instances are active
>
>
> Key: ZOOKEEPER-208
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-208
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.0.0
> Environment: Linux
>Reporter: Austin Shoemaker
>Assignee: Austin Shoemaker
>Priority: Critical
> Fix For: 3.1.0
>
> Attachments: zookeeper-strtok_getaddrinfo-trunk.patch
>
>
> The Zookeeper C client library uses gethostbyname and strtok, both of which
> are not safe to use from multiple threads. Below is the original patch we
> made which fixes the problem.
> The problem is resolved by using getaddrinfo and strtok_r in place of the
> older API.
> Patch for zookeeper-c-client-2.2.1/src/zookeeper.c (2008-06-09 on SF.net)
> 241c241
> < struct hostent *he;
> ---
> > struct addrinfo hints, *res, *res0;
> 243,245d242
> < struct sockaddr_in *addr4;
> < struct sockaddr_in6 *addr6;
> < char **ptr;
> 247a245
> > char *strtok_last;
> 263c261
> < host=strtok(hosts, ",");
> ---
> > host=strtok_r(hosts, ",", &strtok_last);
> 283,294c281,297
> < he = gethostbyname(host);
> < if (!he) {
> < LOG_ERROR(("could not resolve %s", host));
> < errno=EINVAL;
> < rc=ZBADARGUMENTS;
> < goto fail;
> < }
> <
> < /* Setup the address array */
> < for(ptr = he->h_addr_list;*ptr != 0; ptr++) {
> < if (zh->addrs_count == alen) {
> < void *tmpaddr;
> ---
> >
> > memset(&hints, 0, sizeof(hints));
> > hints.ai_flags = AI_ADDRCONFIG;
> > hints.ai_family = AF_UNSPEC;
> > hints.ai_socktype = SOCK_STREAM;
> > hints.ai_protocol = IPPROTO_TCP;
> >
> > if (getaddrinfo(host, port_spec, &hints, &res0) != 0) {
> > LOG_ERROR(("getaddrinfo: %s\n", strerror(errno)));
> > rc=ZSYSTEMERROR;
> > goto fail;
> > }
> >
> > for (res = res0; res; res = res->ai_next) {
> > // Expand address list if needed
> > if (zh->addrs_count == alen) {
> > void *tmpaddr;
> 304,313c307,312
> < }
> < addr = &zh->addrs[zh->addrs_count];
> < addr4 = (struct sockaddr_in*)addr;
> < addr6 = (struct sockaddr_in6*)addr;
> < addr->sa_family = he->h_addrtype;
> < if (addr->sa_family == AF_INET) {
> < addr4->sin_port = htons(port);
> < memset(&addr4->sin_zero, 0, sizeof(addr4->sin_zero));
> < memcpy(&addr4->sin_addr, *ptr, he->h_length);
> < zh->addrs_count++;
> ---
> > }
> >
> > // Copy addrinfo into address list
> > addr = &zh->addrs[zh->addrs_count];
> > switch (res->ai_family) {
> > case AF_INET:
> 315,320c314
> < } else if (addr->sa_family == AF_INET6) {
> < addr6->sin6_port = htons(port);
> < addr6->sin6_scope_id = 0;
> < addr6->sin6_flowinfo = 0;
> < memcpy(&addr6->sin6_addr, *ptr, he->h_length);
> < zh->addrs_count++;
> ---
> > case AF_INET6:
> 322,327c316,328
> < } else {
> < LOG_WARN(("skipping unknown address family %x for %s",
> < addr->sa_family, zh->hostname));
> < }
> < }
> < host = strtok(0, ",");
> ---
> > memcpy(addr, res->ai_addr, res->ai_addrlen);
> > ++zh->addrs_count;
> > break;
> > default:
> > LOG_WARN(("skipping unknown address family %x
> > for %s",
> > res->ai_family, zh->hostname));
> > break;
> > }
[jira] Updated: (ZOOKEEPER-217) handle errors when parsing config file, throw illegalargumentexception rather than exit()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-217: --- Summary: handle errors when parsing config file, throw illegalargumentexception rather than exit() (was: Errors in config file) I updated the summary to be more descriptive of the issue -- this information is included in the release notes/changes files. > handle errors when parsing config file, throw illegalargumentexception rather > than exit() > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
ZooKeeper 3.0 Fix Release slated for end of this week.
I've slated the 3.0.1 fix release of ZooKeeper for the end of this week. https://issues.apache.org/jira/browse/ZOOKEEPER?report=com.atlassian.jira.plugin.system.project:roadmap-panel Of particular interest are exists() NPE in ZOOKEEPER-226, and some perf issues ZOOKEEPER-212 & ZOOKEEPER-223 If there are any questions, or issues that should be included that are not, please speak up. Patrick
[jira] Updated: (ZOOKEEPER-223) default log4j root logger configuration has neg perf impact with no benefit, change default level to INFO
[ https://issues.apache.org/jira/browse/ZOOKEEPER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-223: --- Fix Version/s: 3.0.1 > default log4j root logger configuration has neg perf impact with no benefit, > change default level to INFO > - > > Key: ZOOKEEPER-223 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-223 > Project: Zookeeper > Issue Type: Improvement > Components: java client, server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-223.patch > > > The default log4j.properties has: > log4j.rootLogger=DEBUG, CONSOLE > where the console appender is only outputting INFO level and above. > This is resulting in a large number of debug logs being generated, which are > all filtered out by the console appender (by default there are no other > appenders used) > We need to change the default rootLogger to INFO level, which will resolve > this issue. > Users are free to change this of course -- most likely they would only do > this when debugging an issue, and would not want to run in DEBUG in > production (again, they are free to choose). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Anyone expert in JMX willing to help with ZK impl/docs?
ZK 3.0.0 added support for JMX. Basic server stats are available, as are details on per-client connections. However we don't have zk specific documentation and also it would probably be a good idea for someone that's expert in JMX to review what we have and suggest changes. One thing that may factor in is that we would like to move to "JDK6 only" in 3.1.0. Additionally there's probably information that's missing from our JMX beans that could help debug/operate a running zk instance. Anyone an expert in JMX that could provide some help? https://issues.apache.org/jira/browse/ZOOKEEPER-177 https://issues.apache.org/jira/browse/ZOOKEEPER-94 Regards, Patrick ps. docs are in forrest (see trunk/src/docs) but we do have a tech writer that could help with the formatting, etc... the main thing is to write the content.
[jira] Updated: (ZOOKEEPER-228) apache header missing in DBtest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-228: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision 718703 in 3.0.0 and Committed revision 718702 in trunk. > apache header missing in DBtest > --- > > Key: ZOOKEEPER-228 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-228 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-228.patch > > > one of the test files is missing apache headers ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-228) apache header missing in DBtest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-228: Hadoop Flags: [Reviewed] Status: Patch Available (was: Open) > apache header missing in DBtest > --- > > Key: ZOOKEEPER-228 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-228 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-228.patch > > > one of the test files is missing apache headers ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-228) apache header missing in DBtest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648733#action_12648733 ] Patrick Hunt commented on ZOOKEEPER-228: +1 looks good to me. > apache header missing in DBtest > --- > > Key: ZOOKEEPER-228 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-228 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-228.patch > > > one of the test files is missing apache headers ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-228) apache header missing in DBtest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-228: Attachment: ZOOKEEPER-228.patch aatching the missing header. > apache header missing in DBtest > --- > > Key: ZOOKEEPER-228 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-228 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-228.patch > > > one of the test files is missing apache headers ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-227) gcc warning from recordio.h
[ https://issues.apache.org/jira/browse/ZOOKEEPER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-227: --- Fix Version/s: (was: 3.0.0) 3.1.0 Assignee: Chris Darroch Thanks for the submission Chris! I've added you as a contributor and slated this patch for 3.1.0. > gcc warning from recordio.h > --- > > Key: ZOOKEEPER-227 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 >Reporter: Chris Darroch >Assignee: Chris Darroch >Priority: Minor > Fix For: 3.1.0 > > Attachments: zookeeper-recordio-trunk.patch > > > Recent gcc compilers issue warnings when function declarations for functions > with no arguments don't specific "void". The attached patch fixes one such > warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-228) apache header missing in DBtest
apache header missing in DBtest --- Key: ZOOKEEPER-228 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-228 Project: Zookeeper Issue Type: Bug Affects Versions: 3.0.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.0.1, 3.1.0 one of the test files is missing apache headers ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-227) gcc warning from recordio.h
[ https://issues.apache.org/jira/browse/ZOOKEEPER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Darroch updated ZOOKEEPER-227: Status: Patch Available (was: Open) > gcc warning from recordio.h > --- > > Key: ZOOKEEPER-227 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 >Reporter: Chris Darroch >Priority: Minor > Fix For: 3.0.0 > > Attachments: zookeeper-recordio-trunk.patch > > > Recent gcc compilers issue warnings when function declarations for functions > with no arguments don't specific "void". The attached patch fixes one such > warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-227) gcc warning from recordio.h
[ https://issues.apache.org/jira/browse/ZOOKEEPER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Darroch updated ZOOKEEPER-227: Attachment: zookeeper-recordio-trunk.patch FWIW, I'm an Apache committer with a contributor agreement on file. > gcc warning from recordio.h > --- > > Key: ZOOKEEPER-227 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 >Reporter: Chris Darroch >Priority: Minor > Fix For: 3.0.0 > > Attachments: zookeeper-recordio-trunk.patch > > > Recent gcc compilers issue warnings when function declarations for functions > with no arguments don't specific "void". The attached patch fixes one such > warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-227) gcc warning from recordio.h
[ https://issues.apache.org/jira/browse/ZOOKEEPER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Darroch updated ZOOKEEPER-227: Status: Patch Available (was: Open) > gcc warning from recordio.h > --- > > Key: ZOOKEEPER-227 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 >Reporter: Chris Darroch >Priority: Minor > Fix For: 3.0.0 > > > Recent gcc compilers issue warnings when function declarations for functions > with no arguments don't specific "void". The attached patch fixes one such > warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-227) gcc warning from recordio.h
gcc warning from recordio.h --- Key: ZOOKEEPER-227 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0 Reporter: Chris Darroch Priority: Minor Fix For: 3.0.0 Recent gcc compilers issue warnings when function declarations for functions with no arguments don't specific "void". The attached patch fixes one such warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-226) exists calls fails on server if node has null data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648725#action_12648725 ] Mahadev konar commented on ZOOKEEPER-226: - java.lang.NullPointerException at org.apache.zookeeper.server.DataNode.copyStat(DataNode.java:99) at org.apache.zookeeper.server.DataTree.statNode(DataTree.java:419) at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(Fina lRequestProcessor.java:179) at org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestPro cessor.java:117) at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProce ssor.java:77) here is the exception stack trace. > exists calls fails on server if node has null data > -- > > Key: ZOOKEEPER-226 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > > An NPE will be generated on the server (and resulting in client getting > MarshallingException) if exists() is called on a node with null data. > workaround is to create the node with non-null data. > be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-227) gcc warning from recordio.h
[ https://issues.apache.org/jira/browse/ZOOKEEPER-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Darroch updated ZOOKEEPER-227: Status: Open (was: Patch Available) > gcc warning from recordio.h > --- > > Key: ZOOKEEPER-227 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-227 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0 >Reporter: Chris Darroch >Priority: Minor > Fix For: 3.0.0 > > > Recent gcc compilers issue warnings when function declarations for functions > with no arguments don't specific "void". The attached patch fixes one such > warning for create_buffer_oarchive() in recordio.h. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-226) exists calls fails on server if node has null data
[ https://issues.apache.org/jira/browse/ZOOKEEPER-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-226: --- Assignee: Mahadev konar > exists calls fails on server if node has null data > -- > > Key: ZOOKEEPER-226 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.0.1, 3.1.0 > > > An NPE will be generated on the server (and resulting in client getting > MarshallingException) if exists() is called on a node with null data. > workaround is to create the node with non-null data. > be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-226) exists calls fails on server if node has null data
exists calls fails on server if node has null data -- Key: ZOOKEEPER-226 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-226 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.0.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.0.1, 3.1.0 An NPE will be generated on the server (and resulting in client getting MarshallingException) if exists() is called on a node with null data. workaround is to create the node with non-null data. be sure to update the tests for this case -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-225) c client should log an info message in zookeeper_init detailing connection parameters
c client should log an info message in zookeeper_init detailing connection parameters - Key: ZOOKEEPER-225 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-225 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0 Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.0 I've debugged a few situations where the client connection param was not set properly (even though the user swore that it was). We should log info level message during init to enable us (and user) to easier debug. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-224) Deploy ZooKeeper 3.0.0 to a Maven Repository
[ https://issues.apache.org/jira/browse/ZOOKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648686#action_12648686 ] Patrick Hunt commented on ZOOKEEPER-224: Hiram, couple things: 1) is the "GPG project KEY" different from the key I normally use to sign the release? public release key here: http://svn.apache.org/repos/asf/hadoop/zookeeper/dist/KEYS 2) how do I "deploy" it to the location you listed? What is that location? 3) do I need to name things in some particular way? What specific artifacts have to be deployed? 4) what are the security implications? what keeps someone from signing a zk jar with another key and deploying that? Thanks! > Deploy ZooKeeper 3.0.0 to a Maven Repository > > > Key: ZOOKEEPER-224 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224 > Project: Zookeeper > Issue Type: Task > Components: build >Affects Versions: 3.0.0 >Reporter: Hiram Chirino >Assignee: Patrick Hunt >Priority: Critical > > I've created the maven poms needed for the 3.0.0 release. > The directory structure and artifacts located at: > http://people.apache.org/~chirino/zk-repo/ > aka > people.apache.org:/x1/users/chirino/public_html/zk-repo > Just need sto get GPG signed by the project KEY and deployed to: > people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository > Who's the current ZooKeeper release manager? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-209) nullpointerexception if election port is not specified.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar resolved ZOOKEEPER-209. - Resolution: Fixed fixed with ZOOKEEPER-217. > nullpointerexception if election port is not specified. > --- > > Key: ZOOKEEPER-209 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-209 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Mahadev konar >Assignee: Flavio Paiva Junqueira > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-209.patch > > > The quoruom servers throw a nullpointer exception and still keep running. We > should atleast have a nice debug message and quit... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-217) Errors in config file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-217: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) committed this to trunk revision 718658 and 3.0.0 branch revision 718659. > Errors in config file > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-217) Errors in config file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648654#action_12648654 ] Flavio Paiva Junqueira commented on ZOOKEEPER-217: -- +1 looks good, mahadev. > Errors in config file > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #147
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/147/changes Changes: [mahadev] ZOOKEEPER-219. fix events.poll timeout in watcher test to be longer. (pat via mahadev) [mahadev] ZOOKEEPER-213. fix programmer guide C api docs to be in sync with latest zookeeper.h (pat via mahadev) [mahadev] ZOOKEEPER-212. fix the snapshot to be asynchronous. (mahadev and ben) [mahadev] ZOOKEEPER-223. change default level in root logger to INFO. (pat via mahadev) -- [...truncated 42586 lines...] [junit] 2008-11-18 11:16:28,036 - WARN [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - Connected to /127.0.0.1:34320 lastZxid 5 [junit] 2008-11-18 11:16:28,036 - WARN [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - Finished init of 0x11daf50b18c: true [junit] 2008-11-18 11:16:28,036 - WARN [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - Renewing session 0x11daf50b18c [junit] 2008-11-18 11:16:28,091 - WARN [main-SendThread:[EMAIL PROTECTED] - We are triggering an exists watch for delete! Shouldn't happen! [junit] 2008-11-18 11:16:28,092 - INFO [main:[EMAIL PROTECTED] - STOPPING server [junit] 2008-11-18 11:16:28,093 - WARN [main-SendThread:[EMAIL PROTECTED] - Exception closing session 0x11daf50b18c to [EMAIL PROTECTED] [junit] java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:608) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:838) [junit] 2008-11-18 11:16:28,094 - ERROR [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - => Goodbye cruel world <== [junit] 2008-11-18 11:16:28,094 - INFO [main:[EMAIL PROTECTED] - shutdown of request processor complete [junit] 2008-11-18 11:16:28,197 - INFO [main:[EMAIL PROTECTED] - STARTING server [junit] 2008-11-18 11:16:28,197 - INFO [main:[EMAIL PROTECTED] - Created server [junit] 2008-11-18 11:16:28,199 - INFO [main:[EMAIL PROTECTED] - Reading snapshot /zonestorage/hudson/home/hudson/hudson/jobs/ZooKeeper-trunk/workspace/trunk/build/test/tmp/test28937.junit.dir/version-2/snapshot.5 [junit] 2008-11-18 11:16:28,202 - INFO [main:[EMAIL PROTECTED] - Snapshotting: 6 [junit] 2008-11-18 11:16:30,184 - INFO [main-SendThread:[EMAIL PROTECTED] - Attempting connection to server /127.0.0.1:33221 [junit] 2008-11-18 11:16:30,185 - INFO [main-SendThread:[EMAIL PROTECTED] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:34325 remote=/127.0.0.1:33221] [junit] 2008-11-18 11:16:30,185 - WARN [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - Connected to /127.0.0.1:34325 lastZxid 6 [junit] 2008-11-18 11:16:30,186 - WARN [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - Finished init of 0x11daf50b18c: true [junit] 2008-11-18 11:16:30,186 - WARN [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - Renewing session 0x11daf50b18c [junit] 2008-11-18 11:16:30,223 - WARN [main-SendThread:[EMAIL PROTECTED] - We are triggering an exists watch for delete! Shouldn't happen! [junit] 2008-11-18 11:16:31,264 - INFO [main:[EMAIL PROTECTED] - Closing session: 0x11daf50b18c [junit] 2008-11-18 11:16:31,265 - INFO [main:[EMAIL PROTECTED] - Closing ClientCnxn for session: 0x11daf50b18c [junit] 2008-11-18 11:16:31,266 - INFO [ProcessThread:0:[EMAIL PROTECTED] - Processed session termination request for id: 0x11daf50b18c [junit] 2008-11-18 11:16:31,315 - INFO [main-SendThread:[EMAIL PROTECTED] - Exception while closing send thread for session 0x11daf50b18c : Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] 2008-11-18 11:16:31,424 - INFO [main:[EMAIL PROTECTED] - Disconnecting ClientCnxn for session: 0x11daf50b18c [junit] 2008-11-18 11:16:31,425 - INFO [main:[EMAIL PROTECTED] - Session: 0x11daf50b18c closed [junit] 2008-11-18 11:16:31,425 - INFO [main:[EMAIL PROTECTED] - tearDown starting [junit] 2008-11-18 11:16:31,425 - INFO [main-EventThread:[EMAIL PROTECTED] - EventThread shut down [junit] 2008-11-18 11:16:31,426 - ERROR [NIOServerCxn.Factory:33221:[EMAIL PROTECTED] - => Goodbye cruel world <== [junit] 2008-11-18 11:16:31,427 - INFO [main:[EMAIL PROTECTED] - shutdown of request processor complete [junit] 2008-11-18 11:16:31,468 - INFO [main:[EMAIL PROTECTED] - FINISHED testWatcherAutoResetWithGlobal [junit] 2008-11-18 11:16:31,469 - INFO [main:[EMAIL PROTECTED] - STARTING testWatcherAutoResetWithLocal [junit] 2008-11-18 11:16:31,470 - INFO [main:[EMAIL PROTECTED] - Created server [junit] 2008-11-18 11:16:31,471 - INFO [main:[EMAIL PROTECTED] - Snapshotting: 0 [junit] 2008-11-18 11:16:31,474 - INFO [main:[EMAIL PROTECTED] - Client test setup finished [junit] 2008-11-18 11:16:31,475 - INFO [main-SendThread:[EMAIL PROTE
[jira] Updated: (ZOOKEEPER-217) Errors in config file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-217: Status: Patch Available (was: Open) > Errors in config file > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-217) Errors in config file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-217: Attachment: ZOOKEEPER-217.patch > we should use LOG.fatal instead of LOG.error when about to exit (in main for > example) done > the following exception does not indicate the config param in question - it > might be hard to track down what has to be changed in this case, in the other > exceptions you indicate the particular field/variable/etc... that needs to be > changed. done > why is parse changed to "throws Exception" rather than the more explicit > "throws IllegalArgumentException"? just because in quorumpeerconfig it tries to read the config file for the server id... and might throw an IOException. > specifying the usage in parse seems wrong to me: done.. > Errors in config file > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
