Hudson build is back to normal: ZooKeeper-trunk #680
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/changes
[jira] Commented: (ZOOKEEPER-495) c client logs an invalid error when zookeeper_init is called with chroot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805472#action_12805472 ] Hudson commented on ZOOKEEPER-495: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) c client logs an invalid error when zookeeper_init is called with chroot Key: ZOOKEEPER-495 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-495 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.0 Reporter: Michi Mutsuzaki Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: chroot.cc, chroot.log, ZOOKEEPER-495.patch The C client logs this error message when zookeeper_init is called with chroot. 2009-08-03 18:14:29,130:6624(0x5e66e950):zoo_er...@sub_string@730: server path does not include chroot path /chroot I'll attach a simple program to reproduce this. Thanks! --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805473#action_12805473 ] Hudson commented on ZOOKEEPER-456: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. -- Key: ZOOKEEPER-456 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456 Project: Zookeeper Issue Type: Improvement Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-456.patch CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805471#action_12805471 ] Hudson commented on ZOOKEEPER-413: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) two flaws need addressing in the c tests that can cause false positive failures --- Key: ZOOKEEPER-413 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 Project: Zookeeper Issue Type: Bug Components: c client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-413.patch 1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server 2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to have some limit on the number of iterations (other than just the test, which may never return false), also the loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805475#action_12805475 ] Hudson commented on ZOOKEEPER-507: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) . BookKeeper client re-write (Utkarsh and ben via mahadev) BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Fix For: 3.3.0 Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-593) java client api does not allow client to access negotiated session timeout
[ https://issues.apache.org/jira/browse/ZOOKEEPER-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805477#action_12805477 ] Hudson commented on ZOOKEEPER-593: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) java client api does not allow client to access negotiated session timeout -- Key: ZOOKEEPER-593 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-593 Project: Zookeeper Issue Type: Bug Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-593.patch The java client api does not allow the client to access the negotiated session timeout (c does allow this). In some cases the client may not get the requested timeout (server applies a min/max bound) in which case the client user code may want to examine the timeout it did receive. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-572) add ability for operator to examine state of watches currently registered with a server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805476#action_12805476 ] Hudson commented on ZOOKEEPER-572: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) add ability for operator to examine state of watches currently registered with a server --- Key: ZOOKEEPER-572 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-572 Project: Zookeeper Issue Type: Improvement Components: jmx, server Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch, ZOOKEEPER-572.patch it may be useful for an operator to examine the watches registered with a server by the various connected sessions seems useful to allow: 1) watches on a session 2) watches on a path 3) all watches? command port and JMX. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805515#action_12805515
]
Benjamin Reed commented on ZOOKEEPER-622:
-
good catch steven and excellent patch! will you put the license header in the
generateCfgs.sh script? will you also put the header at the end of
localserverlist (making it a footer :) to avoid a release warning?
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805521#action_12805521
]
Thomas Koch commented on ZOOKEEPER-640:
---
Sorry for not replying earlier. I've finished packaging zookeeper now and
reused only a part of your buildsystem. If everything works out, zookeeper
should be in Debian unstable in a few days. I need to go on with hadoop now.
I'm working on a document for java developers how they can help their
downstream packagers:
http://wiki.debian.org/Java/UpstreamHints
Please be so kind to have a look there from time to time or even help me
expanding it. You'll see, that I'm still seeking for best practices on how to
advise upstream developers to ease Debian with packaging.
make build.xml more configurable to ease packaging for linux distros
Key: ZOOKEEPER-640
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
Project: Zookeeper
Issue Type: Improvement
Components: build
Affects Versions: 3.2.1, 3.2.2
Reporter: Thomas Koch
Assignee: Patrick Hunt
Fix For: 3.3.0
Attachments: ZOOKEEPER-640.patch
Original Estimate: 0.25h
Remaining Estimate: 0.25h
Hi,
I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
excluding contrib/rest from the build without patching the upstream tarball.
Could you please add some properties to your build.xml that allow me to
(de)select contribs? In the example below I can easily override the
properties:
project name=zookeepercontrib
property name=contribfilesetincludes value=*/build.xml /
property name=contribfilesetexcludes value= /
fileset id=contribfileset
dir=.
includes=${contribfilesetincludes}
excludes=${contribfilesetexcludes}
/
target name=compile
subant target=jar
fileset refid=contribfileset /
/subant
/target
Could you please also add a line to project.classpath:
path id=project.classpath
fileset dir=${additional.lib.dir} includes=*.jar/
For Debian I may not compile based on the jar files in lib but must use the
jars already in Debian.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
[2] http://git.debian.org/?p=pkg-java/zookeeper.git
Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805524#action_12805524
]
Benjamin Reed commented on ZOOKEEPER-622:
-
sorry, i looked at this a bit more closely and i realized that we can't really
assume that there is a /tmp. we should be using ${base_dir}/build/tmp/ i'll
take a whack at fixing the zkMultiServer.sh.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805616#action_12805616 ] Patrick Hunt commented on ZOOKEEPER-543: Steven that's great. Do you want to take a shot at adding similar verification to the c tests as well? Or should we just consider this one as is? (meaning java only) Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805620#action_12805620
]
Patrick Hunt commented on ZOOKEEPER-640:
@Thomas I subscribed to the page you listed so hopefully I'll be notified of
any changes in future.
the no network no download may be a problem. In 3.3.0 we've upgraded to ivy
(already used by
much of the rest of the hadoop projects) and as part of that change ivy will
d/l any/all necessary
dependencies during the build. I guess we'll have to cross that bridge at some
point.
so you are ok with the changes listed in this patch then? It addressed your
current concern/problems?
make build.xml more configurable to ease packaging for linux distros
Key: ZOOKEEPER-640
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
Project: Zookeeper
Issue Type: Improvement
Components: build
Affects Versions: 3.2.1, 3.2.2
Reporter: Thomas Koch
Assignee: Patrick Hunt
Fix For: 3.3.0
Attachments: ZOOKEEPER-640.patch
Original Estimate: 0.25h
Remaining Estimate: 0.25h
Hi,
I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
excluding contrib/rest from the build without patching the upstream tarball.
Could you please add some properties to your build.xml that allow me to
(de)select contribs? In the example below I can easily override the
properties:
project name=zookeepercontrib
property name=contribfilesetincludes value=*/build.xml /
property name=contribfilesetexcludes value= /
fileset id=contribfileset
dir=.
includes=${contribfilesetincludes}
excludes=${contribfilesetexcludes}
/
target name=compile
subant target=jar
fileset refid=contribfileset /
/subant
/target
Could you please also add a line to project.classpath:
path id=project.classpath
fileset dir=${additional.lib.dir} includes=*.jar/
For Debian I may not compile based on the jar files in lib but must use the
jars already in Debian.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
[2] http://git.debian.org/?p=pkg-java/zookeeper.git
Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805631#action_12805631
]
Benjamin Reed commented on ZOOKEEPER-622:
-
hey steven, it appears the test case isn't testing anything. can you clarify
how it works?
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed updated ZOOKEEPER-622:
Status: Open (was: Patch Available)
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-22) Automatic request retries on connect failover
[ https://issues.apache.org/jira/browse/ZOOKEEPER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-22: --- Attachment: zookeeper-22.docx here is design document for zookeeper-22. I realised that the scope of zookeeper-22 is much bigger than i had anticipated. This invloves extensive changes to the leader, connect requests from the client, clean up scripts. There needs to version checking introduced with this patch so that old clients work with the new servers and old servers work with the new client, to make it all backwards compatible. Given the scope of this jira, i will be creating sub jiras and mark it as part of this jira since a humongous patch would be hard to get in given that it would touch all critical parts of zookeeper. Automatic request retries on connect failover - Key: ZOOKEEPER-22 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-22 Project: Zookeeper Issue Type: New Feature Components: c client, java client Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.3.0 Attachments: zookeeper-22.docx Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1831412group_id=209147atid=1008547 When a connection to a ZooKeeper server fails, all of the pending requests will return an error. In reality the requests should be resubmitted when the client reestablishes a connection to ZooKeeper. For read requests, it's no big deal to just reissue the request. For update requests, the ZooKeeper must be able to detect if the request has been processed and, if so, return the result of the previous execution; otherwise, it should process the request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-660) Clean up scripts need to change to clean up transaction logs only for a max timeout period.
Clean up scripts need to change to clean up transaction logs only for a max timeout period. --- Key: ZOOKEEPER-660 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-660 Project: Zookeeper Issue Type: Task Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 As a part of ZOOKEEPER-22, the cleanup scripts will have to change to only clean up transaction logs within a max timeout period of the last transaction. This is necessary to replay any client reconnection requests that the servers will get. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-660) Clean up scripts need to change to clean up transaction logs only for a max timeout period.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-660: Component/s: scripts Clean up scripts need to change to clean up transaction logs only for a max timeout period. --- Key: ZOOKEEPER-660 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-660 Project: Zookeeper Issue Type: Task Components: scripts Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 As a part of ZOOKEEPER-22, the cleanup scripts will have to change to only clean up transaction logs within a max timeout period of the last transaction. This is necessary to replay any client reconnection requests that the servers will get. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-645) Bug in WriteLock recipe implementation?
[
https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805736#action_12805736
]
Robert Crocombe commented on ZOOKEEPER-645:
---
I can address point (1) in the original comment: having the session ID breaks
the lock recipe. It looks like the session ID was added per:
https://issues.apache.org/jira/browse/ZOOKEEPER-78?focusedCommentId=12615305page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12615305
but the sorting via ZNodeName is worse than starvation: it causes clients with
low session IDs not to see that clients with higher session IDs have acquired
the lock which causes the function to return true: so you could theoretically
have as many lock owners as clients as long as they acquire the lock in
descending session ID order.
I fixed this in a local branch by replacing ZNodeName with a different class
that ignores the session ID when sorting. My test for WriteLockTest became:
{noformat}
/*
* Test that the bug which makes it possible to acquire a lock in two
* different sessions simultaneously is fixed. Bug occurs because
including
* session ID in node name results in sorting in
* LockZooKeeperOperation.execute() such that low session ID clients do
not
* see that higher session ID clients already have the lock.
*/
@Test
public void testSessionOrderingBugFix() throws Exception {
// session IDs are presumably assigned in order, but perform
some checks
final ZooKeeper zooA = createClient();
final ZooKeeper zooB = createClient();
final ZooKeeper lowZoo = zooA.getSessionId()
zooB.getSessionId() ? zooA
: zooB;
final ZooKeeper highZoo = zooA.getSessionId()
zooB.getSessionId() ? zooB
: zooA;
final WriteLock highLock = new WriteLock(highZoo, dir, null);
final WriteLock lowLock = new WriteLock(lowZoo, dir, null);
boolean highLocked = highLock.lock();
assertTrue(highLocked);
// If the bug is present, this attempt to lock will succeed.
boolean lowLocked = lowLock.lock();
assertFalse(lowLocked);
assertTrue(highLock.isOwner());
assertFalse(lowLock.isOwner());
}
{noformat}
Bug in WriteLock recipe implementation?
---
Key: ZOOKEEPER-645
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645
Project: Zookeeper
Issue Type: Bug
Components: recipes
Affects Versions: 3.2.2
Environment: 3.2.2 java 1.6.0_12
Reporter: Jaakko Laine
Assignee: Jaakko Laine
Priority: Minor
Fix For: 3.3.0
Attachments: 645-fix-findPrefixInChildren.patch
Not sure, but there seem to be two issues in the example WriteLock:
(1) ZNodeName is sorted according to session ID first, and then according to
znode sequence number. This might cause starvation as lower session IDs
always get priority. WriteLock is not thread-safe in the first place, so
having session ID involved in compare operation does not seem to make sense.
(2) if findPrefixInChildren finds previous ID, it should add dir in front of
the ID
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-22) Automatic request retries on connect failover
[ https://issues.apache.org/jira/browse/ZOOKEEPER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805739#action_12805739 ] Henry Robinson commented on ZOOKEEPER-22: - Mahadev - Exciting! Any chance you could post a pdf or html version? - .docx are hard to read on various systems. Henry Automatic request retries on connect failover - Key: ZOOKEEPER-22 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-22 Project: Zookeeper Issue Type: New Feature Components: c client, java client Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.3.0 Attachments: zookeeper-22.docx Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1831412group_id=209147atid=1008547 When a connection to a ZooKeeper server fails, all of the pending requests will return an error. In reality the requests should be resubmitted when the client reestablishes a connection to ZooKeeper. For read requests, it's no big deal to just reissue the request. For update requests, the ZooKeeper must be able to detect if the request has been processed and, if so, return the result of the previous execution; otherwise, it should process the request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805743#action_12805743 ] Steven Cheng commented on ZOOKEEPER-543: Can do, shouldn't take too long I think. Tests for ZooKeeper examples Key: ZOOKEEPER-543 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543 Project: Zookeeper Issue Type: New Feature Components: tests Affects Versions: 3.3.0 Reporter: Steven Cheng Assignee: Steven Cheng Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch Initial attempt to create ZooKeeper tests based on the example code on the website. Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805746#action_12805746
]
Steven Cheng commented on ZOOKEEPER-622:
Hi Ben, sorry about that, this was just a rough cut patch, I got stuck when I
tried to add zkMultiServer.sh into the tests since the Zookeeper server gets
started in main() rather than in the test classes, so I posted it here to see
if I was on the right track. Not sure if that was the right thing to do,
mainly didn't want to go through and start changing all of the test setup
without checking first.
If there isn't anything wrong with moving the Zookeeper server startup into the
setup() methods of the test classes, I can probably get the patch starting up
multiple servers in /tmp and the basic test in place after some work. To
handle $base_dir I was planning to generate the config files somewhere in
$base_dir and point the server to them.
Test for pending watches in send_set_watches should be moved
Key: ZOOKEEPER-622
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Steven Cheng
Assignee: Benjamin Reed
Fix For: 3.3.0
Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
Valgrind found:
{quote}
==2357== Conditional jump or move depends on uninitialised value(s)
==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
(TestZookeeperClose.cc:161)
==2357==by 0x806C6BF: CppUnit::TestCallerZookeeper_close::runTest()
(TestCaller.h:166)
{quote}
zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
3.3.0 tentative release schedule ?
Just curious what the release schedule of 3.3.0 looks like and what is the roadmap for the same. -- K K.
