[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846091#action_12846091 ] Hadoop QA commented on ZOOKEEPER-121: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438950/ZOOKEEPER-121_3.patch against trunk revision 922759. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/24/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/24/console This message is automatically generated. SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846136#action_12846136 ] Hadoop QA commented on ZOOKEEPER-121: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438964/ZOOKEEPER-121_3.patch against trunk revision 922759. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/26/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/26/console This message is automatically generated. SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846140#action_12846140 ] Hudson commented on ZOOKEEPER-121: -- Integrated in ZooKeeper-trunk #744 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/744/]) . SyncRequestProcessor is not closing log stream during shutdown (3rd attempt) SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12846190#action_12846190 ] Hudson commented on ZOOKEEPER-121: -- Integrated in ZooKeeper-trunk #746 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/746/]) . SyncRequestProcessor is not closing log stream during shutdown SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_4.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845596#action_12845596 ] Hudson commented on ZOOKEEPER-121: -- Integrated in ZooKeeper-trunk #738 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/]) SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845626#action_12845626 ] Patrick Hunt commented on ZOOKEEPER-121: Still failing in some cases, most recent: [junit] 2010-03-16 00:39:13,346 - WARN [QuorumPeer:/0:0:0:0:0:0:0:0:11657:follo...@116] - Got zxid 0x10059 expected 0x1 [junit] 2010-03-16 00:39:13,353 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:11657:filetxnsnap...@208] - Snapshotting: 10153 [junit] 2010-03-16 00:39:13,354 - FATAL [SyncThread:4:syncrequestproces...@148] - Severe unrecoverable error, exiting [junit] java.nio.channels.ClosedChannelException [junit] at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:91) [junit] at sun.nio.ch.FileChannelImpl.position(FileChannelImpl.java:256) [junit] at org.apache.zookeeper.server.persistence.Util.padLogFile(Util.java:214) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.padFile(FileTxnLog.java:228) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.append(FileTxnLog.java:206) [junit] at org.apache.zookeeper.server.persistence.FileTxnSnapLog.append(FileTxnSnapLog.java:269) [junit] at org.apache.zookeeper.server.ZKDatabase.append(ZKDatabase.java:435) [junit] at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:107) [junit] 2010-03-16 00:39:13,355 - FATAL [SyncThread:3:syncrequestproces...@148] - Severe unrecoverable error, exiting [junit] java.nio.channels.ClosedChannelException [junit] at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:91) [junit] at sun.nio.ch.FileChannelImpl.position(FileChannelImpl.java:256) [junit] at org.apache.zookeeper.server.persistence.Util.padLogFile(Util.java:214) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.padFile(FileTxnLog.java:228) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.append(FileTxnLog.java:206) [junit] at org.apache.zookeeper.server.persistence.FileTxnSnapLog.append(FileTxnSnapLog.java:269) [junit] at org.apache.zookeeper.server.ZKDatabase.append(ZKDatabase.java:435) [junit] at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:107) [junit] 2010-03-16 00:39:13,357 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:11658:filetxnsnap...@208] - Snapshotting: 10153 [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845642#action_12845642 ] Patrick Hunt commented on ZOOKEEPER-121: not sure if this helps but anouther failure I see: [junit] 2010-03-16 01:12:16,548 - WARN [SyncThread:4:syncrequestproces...@115] - Too busy to snap, skipping [junit] 2010-03-16 01:12:16,548 - WARN [SyncThread:4:syncrequestproces...@115] - Too busy to snap, skipping [junit] 2010-03-16 01:12:16,548 - WARN [SyncThread:4:syncrequestproces...@115] - Too busy to snap, skipping [junit] 2010-03-16 01:12:16,549 - INFO [SyncThread:4:syncrequestproces...@151] - SyncRequestProcessor exited! then 12ms later [junit] 2010-03-16 01:12:16,561 - FATAL [SyncThread:4:syncrequestproces...@148] - Severe unrecoverable error, exiting [junit] java.nio.channels.ClosedChannelException [junit] at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:91) [junit] at sun.nio.ch.FileChannelImpl.position(FileChannelImpl.java:256) [junit] at org.apache.zookeeper.server.persistence.Util.padLogFile(Util.java:214) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.padFile(FileTxnLog.java:228) [junit] at org.apache.zookeeper.server.persistence.FileTxnLog.append(FileTxnLog.java:206) [junit] at org.apache.zookeeper.server.persistence.FileTxnSnapLog.append(FileTxnSnapLog.java:269) [junit] at org.apache.zookeeper.server.ZKDatabase.append(ZKDatabase.java:435) [junit] at org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:107) SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844968#action_12844968 ] Hadoop QA commented on ZOOKEEPER-121: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438711/ZOOKEEPER-121.patch against trunk revision 922459. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/21/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/21/console This message is automatically generated. SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844991#action_12844991 ] Patrick Hunt commented on ZOOKEEPER-121: I don't get this patch, more explanation is necessary. 1) first, why are we calling append on a closed log? in what situations? 2) more importantly, this patch seems to ignore the problem, in particular it results in append being called, append ignores (granted warn log) the operation and return immediately. How is this acceptable? ie we are asked to append and it seems we essentially drop the request and continue on (in syncrequestprocessor run method loop) SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[
https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844993#action_12844993
]
Benjamin Reed commented on ZOOKEEPER-121:
-
i think i agree with pat. we need to figure why it is happening.
looking more closely i believe the problem is in SyncRequestProcessor.shutdown.
currently it is
{code}
public void shutdown() {
try{
zks.getZKDatabase().close();
} catch (IOException ie) {
LOG.warn(Error closing logs , ie);
}
queuedRequests.add(requestOfDeath);
nextProcessor.shutdown();
}
{code}
i think we need to move up the requestOfDeath and wait for shutdown before
closing:
{code}
public void shutdown() {
queuedRequests.add(requestOfDeath);
this.join();
try{
zks.getZKDatabase().close();
} catch (IOException ie) {
LOG.warn(Error closing logs , ie);
}
nextProcessor.shutdown();
}
{code}
SyncRequestProcessor is not closing log stream during shutdown
--
Key: ZOOKEEPER-121
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121
Project: Zookeeper
Issue Type: Bug
Components: server
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Blocker
Fix For: 3.3.0
Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch,
ZOOKEEPER-121.patch
The SyncRequestProcessor is not closing log stream during shutdown.
See FIXMEs with this ID in ClientBase.java -- I've commented out the
assertion for the time being (checking for logs being deleted), as part of
this fix re-enable these asserts and also verify tests on a Windows system.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845006#action_12845006 ] Mahadev konar commented on ZOOKEEPER-121: - agreed. good point folks that was a hurried up patch from my side. sorry abt that I should have been more careful! SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844712#action_12844712 ] Benjamin Reed commented on ZOOKEEPER-121: - +1 looks good SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844721#action_12844721 ] Hadoop QA commented on ZOOKEEPER-121: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438266/ZOOKEEPER-121.patch against trunk revision 922433. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/18/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/18/console This message is automatically generated. SyncRequestProcessor is not closing log stream during shutdown -- Key: ZOOKEEPER-121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 Project: Zookeeper Issue Type: Bug Components: server Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch The SyncRequestProcessor is not closing log stream during shutdown. See FIXMEs with this ID in ClientBase.java -- I've commented out the assertion for the time being (checking for logs being deleted), as part of this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
