[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761536#action_12761536 ] Hudson commented on ZOOKEEPER-420: -- Integrated in ZooKeeper-trunk #485 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/485/]) . build/test should not require install in zkpython > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, > ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761349#action_12761349 ] Hadoop QA commented on ZOOKEEPER-420: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420574/ZOOKEEPER-420.patch against trunk revision 818584. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/0/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/0/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/0/console This message is automatically generated. > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, > ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759423#action_12759423 ] Henry Robinson commented on ZOOKEEPER-420: -- Hi Mahadev - Thanks for helping out with this. I've added the compile dependency, and also fixed the "dirname: too few arguments" problem that you get if you try to manually run the tests without having run ant compile. For the last problem - could you add this line to run_tests.sh after the PYTHONPATH is set? python -c "import sys; print sys.path" I get: ['', '/Library/Python/2.5/site-packages/virtualenv-1.3.3-py2.5.egg', '/Library/Python/2.5/site-packages/simplejson-2.0.9-py2.5-macosx-10.5-i386.egg', '/Users/henry/src/cloudera/apache-zookeeper/build/contrib/zkpython/lib.macosx-10.5-i386-2.5', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python25.zip', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/plat-darwin', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/plat-mac', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/plat-mac/lib-scriptpackages', '/System/Library/Frameworks/Python.framework/Versions/2.5/Extras/lib/python', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/lib-tk', '/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/lib-dynload', '/Library/Python/2.5/site-packages', '/System/Library/Frameworks/Python.framework/Versions/2.5/Extras/lib/python/PyObjC'] The third directory is the one that the script should have found for the .so file on my machine. Do you see the PYTHONPATH directory in the list you get? > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, > ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759378#action_12759378 ] Mahadev konar commented on ZOOKEEPER-420: - I was trying to debug this on my linux machine Looks like you have to run ant compile before running ant test. It would be better if ant test depends on compile target. While debugging I saw that PYTHONPATH was set to the library directory, that contained zookeeper.so (tried echoing PYTHONPATH and it points to the correct directory). So I am not sure why the tests are not able find the zookeeper module. Any suggestions? > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, > ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759352#action_12759352 ] Mahadev konar commented on ZOOKEEPER-420: - henry I tried the patch but I still get the error: python-test: [exec] dirname: too few arguments [exec] Try `dirname --help' for more information. [exec] Running src/test/clientid_test.py [exec] Traceback (most recent call last): [exec] File "src/test/clientid_test.py", line 21, in ? [exec] import zookeeper, zktestbase [exec] ImportError: No module named zookeeper [exec] Running src/test/connection_test.py [exec] Traceback (most recent call last): [exec] File "src/test/connection_test.py", line 21, in ? [exec] import zookeeper, zktestbase [exec] ImportError: No module named zookeeper [exec] Running src/test/create_test.py [exec] Traceback (most recent call last): [exec] File "src/test/create_test.py", line 19, in ? [exec] import zookeeper, zktestbase, unittest, threading [exec] ImportError: No module named zookeeper [exec] Running src/test/delete_test.py [exec] Traceback (most recent call last): [exec] File "src/test/delete_test.py", line 19, in ? [exec] import zookeeper, zktestbase, unittest, threading [exec] ImportError: No module named zookeeper [exec] Running src/test/exists_test.py [exec] Traceback (most recent call last): [exec] File "src/test/exists_test.py", line 19, in ? [exec] import zookeeper, zktestbase, unittest, threading [exec] ImportError: No module named zookeeper [exec] Running src/test/get_set_test.py [exec] Traceback (most recent call last): [exec] File "src/test/get_set_test.py", line 19, in ? [exec] import zookeeper, zktestbase, unittest, threading [exec] ImportError: No module named zookeeper These are steps I run the tests in - # ant test-core-cppunit # cd src/contrib # ant test and I get the above error. I can help debug if you do not have access to a linux machine. Let me know. > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, > ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758806#action_12758806 ] Patrick Hunt commented on ZOOKEEPER-420: Henry, this sounds good, however you need one more path for 1) & 3) If the user types "ant test" from the toplevel build, all the java/c code will be compiled/tested. If the user then cd's into src/contrib/zkpython and types "ant test" it will fail. The reason is that the c code is compiled into the build directory (build/test/test-cppunit/.libs) rather than src/c/.libs when the "ant test" target is run. Re ensuring the lib is built - you might take a look at what's done for ensuring that the java classes are build for contribs like the "rest" contrib. You could do similar for zkpython but for the c lib (might be more trouble than it's worth though). Perhaps I missed it, but you should mention the PYTHONPATH in the readme (docs). I was trying LD_LIBRARY_PATH and was suprised that python interp couldn't find the zookeeper.so, eventually I just gave up and copied the file. If I would have know about PP it would have helped. > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717673#action_12717673 ] Henry Robinson commented on ZOOKEEPER-420: -- Here's a strawman patch (not yet ready for submission) which illustrates a point. In order to encapsulate zkpython completely, the C libraries need to be built somewhere in the encapsulated tree. From looking at the ant dependency graph (I attached a copy of the graph for interest :) ) and experimenting it seems that test-cppunit is the only target which makes sure that they are built, and it places them in build/test/test-cppunit. In this patch, Python will try and link the zookeeper module against those libraries first, before looking for /usr/local/lib. However this then introduces a dependency between zkpython and the C tests (which I can't build on my Mac, due to an unsupported ld option), which I'd rather avoid. If there were a separate ant target for building the C libraries (seems like there should be - maybe I've missed it?) then I can make zkpython test target depend on that. I don't know the C infrastructure well enough to hack on this without confirmation that this is the right thing to do, but will happily separate out the targets if it is. It seems like this is probably related to ZOOKEEPER-316 as well? > build/test should not require install in zkpython > - > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Reporter: Patrick Hunt >Assignee: Henry Robinson > Attachments: build.jpg, ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
