Re: Zookeeper Test Project

2009-10-05 Thread Mahadev Konar
> Sounds good, I have created an ASF JIRA account, but it doesn't look like I
> can attach a file in Step 2 of the "Create Issue" screen.  Do I have to
> create the jira first then attach the file?
Yes. Please take a look at

http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

On some guidelines on contributing.

Thanks
mahadev

> 
> 
>> 
>> Also, if you are willing to work a little more on your queue
>> implementation,
>> we could have that as a part of src/recipes and then people could use that.
>> Tests can be added to this recipe to verify them...
>> 
> 
> Just took a look at the lock recipe, I'll start working on a queue recipe
> and tests.
> 
> Steven
> 
> 
> 
>> 
>> Thanks
>> mahadev
>> 
>> On 10/5/09 1:45 PM, "Steve Cheng"  wrote:
>> 
>>> Hi,
>>> 
>>> The test project on the ProjectSuggestions page, to create tests for the
>>> examples, sounded like a nice way to get started with ZooKeeper, I've
>> created
>>> one queue test and one lock test so far.
>>> 
>>> I'd like to make a good range of tests, a number of basic sanity ones
>> like the
>>> queue test, and some more involved ones like the lock test.  The lock
>> test
>>> does polling right now, another test would also test watching.  I think
>> it's
>>> useful to test both.
>>> 
>>> Any comments on this would be great, I noticed the bug about the test
>> case
>>> runtime so I'm not sure what that means for more tests, thanks,
>>> 
>>> Steven
>>> 
>>> 
>> 
>> 



Re: Zookeeper Test Project

2009-10-05 Thread Steve Cheng
Hi Mahadev,

   Can you please create a jira and upload the code to that jira for
> feedback? I am guessing that you want to contribute these tests back to
> zookeeper right ?
>  Also, do take a look at src/recipes/lock for an implementation of locks on
> top of zookeeper. They have some tests as well.
>

Sounds good, I have created an ASF JIRA account, but it doesn't look like I
can attach a file in Step 2 of the "Create Issue" screen.  Do I have to
create the jira first then attach the file?


>
> Also, if you are willing to work a little more on your queue
> implementation,
> we could have that as a part of src/recipes and then people could use that.
> Tests can be added to this recipe to verify them...
>

Just took a look at the lock recipe, I'll start working on a queue recipe
and tests.

Steven



>
> Thanks
> mahadev
>
> On 10/5/09 1:45 PM, "Steve Cheng"  wrote:
>
> > Hi,
> >
> > The test project on the ProjectSuggestions page, to create tests for the
> > examples, sounded like a nice way to get started with ZooKeeper, I've
> created
> > one queue test and one lock test so far.
> >
> > I'd like to make a good range of tests, a number of basic sanity ones
> like the
> > queue test, and some more involved ones like the lock test.  The lock
> test
> > does polling right now, another test would also test watching.  I think
> it's
> > useful to test both.
> >
> > Any comments on this would be great, I noticed the bug about the test
> case
> > runtime so I'm not sure what that means for more tests, thanks,
> >
> > Steven
> >
> >
>
>


Re: Zookeeper Test Project

2009-10-05 Thread Mahadev Konar

Hi Steve,
Can you please create a jira and upload the code to that jira for
feedback? I am guessing that you want to contribute these tests back to
zookeeper right ? 
  Also, do take a look at src/recipes/lock for an implementation of locks on
top of zookeeper. They have some tests as well.

Also, if you are willing to work a little more on your queue implementation,
we could have that as a part of src/recipes and then people could use that.
Tests can be added to this recipe to verify them...

Thanks
mahadev

On 10/5/09 1:45 PM, "Steve Cheng"  wrote:

> Hi,
> 
> The test project on the ProjectSuggestions page, to create tests for the
> examples, sounded like a nice way to get started with ZooKeeper, I've created
> one queue test and one lock test so far.
> 
> I'd like to make a good range of tests, a number of basic sanity ones like the
> queue test, and some more involved ones like the lock test.  The lock test
> does polling right now, another test would also test watching.  I think it's
> useful to test both.
> 
> Any comments on this would be great, I noticed the bug about the test case
> runtime so I'm not sure what that means for more tests, thanks,
> 
> Steven
> 
>