Re: do the test cases work for anyone else?
Here's the first issue with a patch... https://issues.apache.org/jira/browse/ZOOKEEPER-86 2008/7/23 Patrick Hunt <[EMAIL PROTECTED]>: > It's important to capture this type of information in jira. > > James Strachan wrote: >> >> FWIW I've ran the tests a few times; I think all these 4 tests have >> timing failures in them. I've seen all of them fail on OS X at some >> point. Sometimes only 2 will fail. On Linux I've seen just ClientTest >> fail. >> >> >> 2008/7/23 Patrick Hunt <[EMAIL PROTECTED]>: >>> >>> I'm on ubuntu (hardy heron) and they work. Our CI machine has >>> intermittent >>> failures (solaris x86): >>> http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/ >>> >>> there's some timing issue, what you're seeing is probably related to: >>> https://issues.apache.org/jira/browse/ZOOKEEPER-61 >>> >>> Frankly tests and docs are both areas that ZooKeeper could use _a lot_ of >>> care and feeding. Tests in particular could use some refactoring and a >>> better implementation for launching/testing/stopping client/server tests. >>> >>> As you're able to reproduce the issue reliably would you like to take on >>> 61? >>> Feel free to assign to yourself if so. >> >> As a newbie on the project its hard enough grokking ZK itself and >> attempting to contribute patches, but fixing bad test cases of ZK is >> even harder :) I was hoping the folks who know ZK really well can fix >> the tests they've written :). But I'll take a look and see if I can >> see anything obvious I can do to help with my limited knowledge of the >> history of the code and internals. >> >> How about we raise a JIRA for all tests that fail? >> > -- James --- http://macstrac.blogspot.com/ Open Source Integration http://open.iona.com
Re: do the test cases work for anyone else?
Makes sense. Feel free to do so. mahadev On 7/23/08 9:12 AM, "James Strachan" <[EMAIL PROTECTED]> wrote: > FWIW I've ran the tests a few times; I think all these 4 tests have > timing failures in them. I've seen all of them fail on OS X at some > point. Sometimes only 2 will fail. On Linux I've seen just ClientTest > fail. > > > 2008/7/23 Patrick Hunt <[EMAIL PROTECTED]>: >> I'm on ubuntu (hardy heron) and they work. Our CI machine has intermittent >> failures (solaris x86): >> http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/ >> >> there's some timing issue, what you're seeing is probably related to: >> https://issues.apache.org/jira/browse/ZOOKEEPER-61 >> >> Frankly tests and docs are both areas that ZooKeeper could use _a lot_ of >> care and feeding. Tests in particular could use some refactoring and a >> better implementation for launching/testing/stopping client/server tests. >> >> As you're able to reproduce the issue reliably would you like to take on 61? >> Feel free to assign to yourself if so. > > As a newbie on the project its hard enough grokking ZK itself and > attempting to contribute patches, but fixing bad test cases of ZK is > even harder :) I was hoping the folks who know ZK really well can fix > the tests they've written :). But I'll take a look and see if I can > see anything obvious I can do to help with my limited knowledge of the > history of the code and internals. > > How about we raise a JIRA for all tests that fail?
Re: do the test cases work for anyone else?
It's important to capture this type of information in jira. James Strachan wrote: FWIW I've ran the tests a few times; I think all these 4 tests have timing failures in them. I've seen all of them fail on OS X at some point. Sometimes only 2 will fail. On Linux I've seen just ClientTest fail. 2008/7/23 Patrick Hunt <[EMAIL PROTECTED]>: I'm on ubuntu (hardy heron) and they work. Our CI machine has intermittent failures (solaris x86): http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/ there's some timing issue, what you're seeing is probably related to: https://issues.apache.org/jira/browse/ZOOKEEPER-61 Frankly tests and docs are both areas that ZooKeeper could use _a lot_ of care and feeding. Tests in particular could use some refactoring and a better implementation for launching/testing/stopping client/server tests. As you're able to reproduce the issue reliably would you like to take on 61? Feel free to assign to yourself if so. As a newbie on the project its hard enough grokking ZK itself and attempting to contribute patches, but fixing bad test cases of ZK is even harder :) I was hoping the folks who know ZK really well can fix the tests they've written :). But I'll take a look and see if I can see anything obvious I can do to help with my limited knowledge of the history of the code and internals. How about we raise a JIRA for all tests that fail?
Re: do the test cases work for anyone else?
FWIW I've ran the tests a few times; I think all these 4 tests have timing failures in them. I've seen all of them fail on OS X at some point. Sometimes only 2 will fail. On Linux I've seen just ClientTest fail. 2008/7/23 Patrick Hunt <[EMAIL PROTECTED]>: > I'm on ubuntu (hardy heron) and they work. Our CI machine has intermittent > failures (solaris x86): > http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/ > > there's some timing issue, what you're seeing is probably related to: > https://issues.apache.org/jira/browse/ZOOKEEPER-61 > > Frankly tests and docs are both areas that ZooKeeper could use _a lot_ of > care and feeding. Tests in particular could use some refactoring and a > better implementation for launching/testing/stopping client/server tests. > > As you're able to reproduce the issue reliably would you like to take on 61? > Feel free to assign to yourself if so. As a newbie on the project its hard enough grokking ZK itself and attempting to contribute patches, but fixing bad test cases of ZK is even harder :) I was hoping the folks who know ZK really well can fix the tests they've written :). But I'll take a look and see if I can see anything obvious I can do to help with my limited knowledge of the history of the code and internals. How about we raise a JIRA for all tests that fail? -- James --- http://macstrac.blogspot.com/ Open Source Integration http://open.iona.com
Re: do the test cases work for anyone else?
I'm on ubuntu (hardy heron) and they work. Our CI machine has intermittent failures (solaris x86): http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/ there's some timing issue, what you're seeing is probably related to: https://issues.apache.org/jira/browse/ZOOKEEPER-61 Frankly tests and docs are both areas that ZooKeeper could use _a lot_ of care and feeding. Tests in particular could use some refactoring and a better implementation for launching/testing/stopping client/server tests. As you're able to reproduce the issue reliably would you like to take on 61? Feel free to assign to yourself if so. Regards, Patrick James Strachan wrote: I've always had some tests failing on most boxes I try; I wasn't sure if everyone else got those or if they do work on some platforms? On OS X I get these failures [junit] Test org.apache.zookeeper.test.AsyncTest FAILED [junit] Test org.apache.zookeeper.test.WatcherFuncTest FAILED On a linux box (an EC2 box) I get these failures [junit] Test org.apache.zookeeper.test.ClientTest FAILED [junit] Test org.apache.zookeeper.test.QuorumTest FAILED Maybe they all work on windows? :) I tried adding an explicit forkmode="perTest" to the and I still get the same results. Can anyone else get the tests to work on linux or OS X?
do the test cases work for anyone else?
I've always had some tests failing on most boxes I try; I wasn't sure if everyone else got those or if they do work on some platforms? On OS X I get these failures [junit] Test org.apache.zookeeper.test.AsyncTest FAILED [junit] Test org.apache.zookeeper.test.WatcherFuncTest FAILED On a linux box (an EC2 box) I get these failures [junit] Test org.apache.zookeeper.test.ClientTest FAILED [junit] Test org.apache.zookeeper.test.QuorumTest FAILED Maybe they all work on windows? :) I tried adding an explicit forkmode="perTest" to the and I still get the same results. Can anyone else get the tests to work on linux or OS X? -- James --- http://macstrac.blogspot.com/ Open Source Integration http://open.iona.com