[Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread yuppie
Hi Geoff! Geoff Davis wrote: I have checked my CachingPolicyManager improvements into the geoffd-cachingpolicymanager-branch. Enjoy! Great! Some feedback regard formal aspects: - Please make sure your checkins show up on the CMF-checkins list. Don't know if Tres can fix that for you or

[Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread yuppie
Jens Vagelpohl wrote: On 8 Sep 2005, at 11:08, yuppie wrote: PS Those of you who raised concerns about ZopeTestCase causing test problems in Zope 2.7 might want to take a look at why test_z3interfaces is broken when you run the tests with zopectl test. 1.) Why those of you who raised

[Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Jens Vagelpohl
On 8 Sep 2005, at 12:00, yuppie wrote: PS Those of you who raised concerns about ZopeTestCase causing test problems in Zope 2.7 might want to take a look at why test_z3interfaces is broken when you run the tests with zopectl test. 1.) Why those of you who raised concerns about

[Zope-CMF] Re: CachingPolicyManager improvements

2005-09-08 Thread Florent Guillaume
whit wrote: Agreed. Nevertheless we should focus on lowering the barrier of entry for new CMF contributors. People used to write tests for Zope or Plone will have less trouble if they can use ZopeTestCase. And ZopeTestCase tests are definitely better than no tests at all. and it's

[Zope-CMF] Small CMFCatalogAware refactoring

2005-09-08 Thread Julien Anguenot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I did a small refactoring on the CMFCatalogAware in changesets [38390] (1.5) and [38391] (trunk) The CMFCatalogAware class definition defines now 2 new methods, _getCatalogTool() and _getWorkflowTool(), that are used internaly while looking up

[Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Geoff Davis
On Thu, 08 Sep 2005 12:08:23 +0200, yuppie wrote: - Please make sure your checkins show up on the CMF-checkins list. Don't know if Tres can fix that for you or if you've got to register for that list. Ok, I will look into it. - Please don't forget to set svn:eol-style and svn:keywords Id

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Jens Vagelpohl
On 8 Sep 2005, at 16:48, Geoff Davis wrote: bin/zopectl test --dir Products/CMFCore/tests I get a bunch of errors like the following: == ERROR: test_z3interfaces (CMFCore.tests.test_ActionInformation.ActionInfoTests)

[Zope-CMF] Re: Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Geoff Davis
On Thu, 08 Sep 2005 17:45:54 +0100, Jens Vagelpohl wrote: All those tests run fine for me using your branch and a vanilla Zope 2.7.6. I'd make a wild guess and say it's your setup. Could be. Did you try removing the lines in test_Template304Handling.py that clean up the profile_registry?

Re: [Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread Sidnei da Silva
| The z3interfaces tests are based on the assumption that Five is | available if zope.interface is available. Five creates IActionInfo | dynamically on startup. | | That's obviously not true in your setup. Looking again at these tests it | would be more robust to include the interface imports

[Zope-CMF] Re: CachingPolicyManager improvements checked in to svn

2005-09-08 Thread yuppie
Sidnei da Silva wrote: | The z3interfaces tests are based on the assumption that Five is | available if zope.interface is available. Five creates IActionInfo | dynamically on startup. | | That's obviously not true in your setup. Looking again at these tests it | would be more robust to