Re: [Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-06 Thread yuppie
Dieter Maurer wrote: yuppie wrote at 2005-4-4 20:59 +0200: ... 2.) I prefer to see the correct import in each file and to use utils just for the fallback. But, then you get a nasty "try: ... except:" in hundred of files rather than just a single one. Eight files in CMF, not hundreds of files for

Re: [Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-05 Thread Dieter Maurer
yuppie wrote at 2005-4-4 20:59 +0200: > ... >2.) I prefer to see the correct import in each file and to use utils >just for the fallback. But, then you get a nasty "try: ... except:" in hundred of files rather than just a single one. -- Dieter ___ Zop

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread yuppie
Sidnei da Silva wrote: | Good question ;) | [...] Sorry, I meant instead of the try: except, just import from Products.CMFCore.tests.utils as there's another try:except in there. Also a good question ;) 1.) I just want to add the except part to utils, not the try/except 2.) I prefer to see the c

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread Sidnei da Silva
| Good question ;) | | All I know is that | | - CMF uses that pattern in all test files | | - 'Products.CMFCore.foo' seems to work with any testing setup | | - with my setup 'CMFCore.foo' doesn't work if I run tests outside test.py Sorry, I meant instead of the try: except, just import from Pr

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread yuppie
Sidnei da Silva wrote: | 2.) adding BBBTransaction to CMFCore.tests.base.utils and using this in | tests: | | try: | import transaction | except ImportError: | # BBB: for Zope 2.7 | from Products.CMFCore.tests.base.utils import transaction Why not just import from CMFCore.test.base.u

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread yuppie
Hi Florent! Florent Guillaume wrote: yuppie <[EMAIL PROTECTED]> wrote: 2.) test_DiscussionReply.py - while most test modules include tests for a corresponding module of the product, these are tests for a single collector issue - the tests are not really unit tests, more something like integratio

Re: [Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread Sidnei da Silva
| 1.) fixing the bugs in BBBTransaction ;) | | 2.) adding BBBTransaction to CMFCore.tests.base.utils and using this in | tests: | | try: | import transaction | except ImportError: | # BBB: for Zope 2.7 | from Products.CMFCore.tests.base.utils import transaction Why not just import f

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread yuppie
Hi Florent! Florent Guillaume wrote: yuppie <[EMAIL PROTECTED]> wrote: 3.) Zope 2.8 warnings 'Zope2' is not available in Zope 2.7 and 'Zope' is deprecated in Zope 2.8. Same with 'transaction' and 'get_transaction'. Has anybody a better idea to resolve it than this way: [...] I was thinking of: t

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > 1.) CMFStaging tests > > For a while now, I see 6 CMFStaging tests failing. Can anybody confirm > they are broken? Does anybody use CMFStaging and knows how to fix these > tests? We use it. I don't actually consider it to be part of

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > Lennart Regebro wrote: > >>> 3.) Zope 2.8 warnings >>> >>> 'Zope2' is not available in Zope 2.7 and 'Zope' is deprecated in Zope >>> 2.8. Same with 'transaction' and 'get_transaction'. >>> >>> Has anybody a better idea to resolve it th

[Zope-CMF] Re: [dev] failing tests and other unit test issues

2005-04-04 Thread yuppie
Lennart Regebro wrote: 3.) Zope 2.8 warnings 'Zope2' is not available in Zope 2.7 and 'Zope' is deprecated in Zope 2.8. Same with 'transaction' and 'get_transaction'. Has anybody a better idea to resolve it than this way: Well, the deprecation procedures and warning is there to tell you that you a