Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
I'd like some review before merging the fix into trunk.
I do not know for sure that I can remove the type check.
Thanks
Gotcha
Le 13/01/11 12:00, Godefroid Chapelle a écrit :
Log message for revision 119561
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Aren't you risking double encoding now? That patch looks like it makes
things worse, not better.
I am not sure I
Le 13/01/11 14:02, Wichert Akkerman a écrit :
On 1/13/11 14:01 , Godefroid Chapelle wrote:
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see tests in revision
119560.
Aren't you risking
Le 13/01/11 14:17, Godefroid Chapelle a écrit :
Le 13/01/11 14:02, Wichert Akkerman a écrit :
On 1/13/11 14:01 , Godefroid Chapelle wrote:
Le 13/01/11 12:07, Wichert Akkerman a écrit :
On 1/13/11 12:04 , Godefroid Chapelle wrote:
Hi,
I have fixed an exportimport bug on branch 2.2 : see
but, yes, I
suspect the problem you are experiencing is Plone and not CMF related.
I am still not convinced.
Charlie
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman
Le 13/01/11 17:03, Godefroid Chapelle a écrit :
Le 13/01/11 15:04, Tres Seaver a écrit :
This change should be reverted -- you now double-encode any
already-encoded UTF=8 strings. We should probably add a test for that
condition.
Change reverted, test added in 119566.
After having tuned
Le 13/01/11 17:50, yuppie a écrit :
Godefroid Chapelle wrote:
One buildout per package is the practice in ZTK world.
I have come to really appreciate it; it really lowers the barrier for
contributions.
checkout
bootstrap
buildout
run tests to check state before changes
fix
run tests
?
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Hi,
Python2.6 has deprecated string exceptions.
However, I find about 15 string exceptions in CMF 2.2
I guess this is just something that was forgotten.
Can we consider this as a critical issue for next release ?
Regards
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
spoke before thinking deep
enough.
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature
_export_step_registry.getStepMetadata(step, default)
Can someone confirm ?
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports
Le 02/03/11 14:59, Godefroid Chapelle a écrit :
IOW, it seems it should be :
def getExportStep(self, step, default=None):
Simple wrapper to query both the global and local step
registry.
res=self._export_step_registry.getStep(step, default)
if res
-utilitiesnew=120738
If I get no comment within 1 week, I'll assume I can merge and will do so.
TIA ;-)
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
Le 08/03/11 17:26, Wichert Akkerman a écrit :
On 2011-3-8 17:08, Godefroid Chapelle wrote:
Hello,
GenericSetup has global registries for profiles and steps.
They are a PITA when testing.
For instance, plone.app.testing has to make a complicated dance to
record and restore
into a new 1.6.x GenericSetup release...
... which next Plone 4.0.x and 4.1 can both use (AFAIK they use the same
version of GenericSetup).
This way, plone.testing (which is still not final) can be cleaned up.
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
Hi Yvo,
Thanks for reviewing my work !
Le 11/03/11 10:43, yuppie a écrit :
Hi Godefroid!
A few questions:
Godefroid Chapelle wrote:
Log message for revision 120850:
Refactored global registries to use global named utilities.
merge of branch gotcha-registries-use-utilities
after merge ?
Thanks
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Le 26/04/11 12:04, Hanno Schlichting a écrit :
On Tue, Apr 26, 2011 at 11:53 AM, Godefroid Chapelle
got...@bubblenet.be wrote:
I had made changes to GS registries (use ZCA instead of own registries)
which got released in 1.6.3.
I backported those changes to 1.4.
http://zope3.pov.lt/trac
Le 26/05/11 17:15, Hanno Schlichting a écrit :
On Thu, May 26, 2011 at 4:46 PM, Godefroid Chapellegot...@bubblenet.be
wrote:
Would anyone see an issue that I release a Products.GenericSetup 1.4.20
(or any other big integer) with ZCA registries ?
Smaller 1.4.x numbers could be kept for bug
Le 27/05/11 10:03, Hanno Schlichting a écrit :
On Thu, May 26, 2011 at 10:39 PM, Godefroid Chapelle
got...@bubblenet.be wrote:
Le 26/05/11 17:15, Hanno Schlichting a écrit :
Smaller 1.4.x numbers could be kept for bug fix releases for CMF 2.1 and
Plone 3.
That's a really weird way of doing
for the
majority of users
Using a dev release does the same without the need for debugging broken
cases where the user did not know.
and adding a tiny little bit of extra work for the
few that want to run your backport. I think that is a very sane
approach.
Hanno
Constructively ;-)
--
Godefroid
21 matches
Mail list logo
