Re: [Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-18 Thread yuppie
Hi! Charlie Clark wrote: > Am 17.11.2009, 14:41 Uhr, schrieb yuppie : > >> getIcon() is an alias of icon() and could become deprecated. I don't >> know if it's worth the effort to mark the 'relative_to_portal' argument >> of icon() as well as deprecated. >> I already started implementing these c

Re: [Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-18 Thread Charlie Clark
Am 17.11.2009, 14:41 Uhr, schrieb yuppie : > getIcon() is an alias of icon() and could become deprecated. I don't > know if it's worth the effort to mark the 'relative_to_portal' argument > of icon() as well as deprecated. > I already started implementing these changes. Hi Yuppie, now that I hav

Re: [Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-17 Thread Charlie Clark
Am 17.11.2009, 14:41 Uhr, schrieb yuppie : > AFAICS we need 2 of them in DynamicType: > icon() is part of OFS.interfaces.IItem and should return the URL > relative to BASEPATH1. This is required to show the icons correctly in > the ZMI. > getIconURL() should become part of IDynamicType and return

Re: [Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-17 Thread yuppie
Hi! Charlie Clark wrote: > Am 16.11.2009, 18:24 Uhr, schrieb yuppie : > >> In CMF we always need the absolute URL. Since getIcon() and icon() >> already have a different meaning and something like >> getIcon(absolute=True) looks too complicated for the default, I propose >> to add a new method:

Re: [Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-17 Thread Charlie Clark
Am 16.11.2009, 18:24 Uhr, schrieb yuppie : > In CMF we always need the absolute URL. Since getIcon() and icon() > already have a different meaning and something like > getIcon(absolute=True) looks too complicated for the default, I propose > to add a new method: getIconURL() > getIcon() and icon(

Re: [Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-16 Thread Hanno Schlichting
Hi. On Mon, Nov 16, 2009 at 6:24 PM, yuppie wrote: > CMF 2.2.0-alpha has some getIcon changes based on what I proposed here: > https://mail.zope.org/pipermail/zope-cmf/2009-January/028059.html > > Unfortunately the issue is more complicated than I thought and some > things are now broken in CMF 2

[Zope-CMF] CMF 2.2.0-alpha: getIcon

2009-11-16 Thread yuppie
Hi! CMF 2.2.0-alpha has some getIcon changes based on what I proposed here: https://mail.zope.org/pipermail/zope-cmf/2009-January/028059.html Unfortunately the issue is more complicated than I thought and some things are now broken in CMF 2.2.0-alpha: The return values of getIcon() and icon()