[Zope-dev] Zope Tests: 6 OK
Summary of messages to the zope-tests list. Period Sun Dec 13 12:00:00 2009 UTC to Mon Dec 14 12:00:00 2009 UTC. There were 6 messages: 6 from Zope Tests. Tests passed OK --- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Sun Dec 13 20:38:20 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013191.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Sun Dec 13 20:40:20 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013192.html Subject: OK : Zope-2.12 Python-2.6.4 : Linux From: Zope Tests Date: Sun Dec 13 20:42:20 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013193.html Subject: OK : Zope-2.12-alltests Python-2.6.4 : Linux From: Zope Tests Date: Sun Dec 13 20:44:20 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013194.html Subject: OK : Zope-trunk Python-2.6.4 : Linux From: Zope Tests Date: Sun Dec 13 20:46:20 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013195.html Subject: OK : Zope-trunk-alltests Python-2.6.4 : Linux From: Zope Tests Date: Sun Dec 13 20:48:20 EST 2009 URL: http://mail.zope.org/pipermail/zope-tests/2009-December/013196.html ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] windows newslines in doctests
Hi All, I've run into problems with Windows newlines in doctests a couple of times now and so thought I'd ask what people do in general to work around this... Do you: - make sure .txt that ends up being doctested only has \n line endings in it? - use zope.testing.renormalizing to replace \r\n with \n? - something else I'm not aware of :-) cheers, Chris -- Simplistix - Content Management, Batch Processing Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] windows newslines in doctests
On Mon, Dec 14, 2009 at 9:02 AM, Chris Withers ch...@simplistix.co.uk wrote: I've run into problems with Windows newlines in doctests a couple of times now and so thought I'd ask what people do in general to work around this... I don't think line ending problems happen very often. I'd be interested in seeing a doctest that has problems. Do you: ... - something else I'm not aware of :-) Maybe NORMALIZE_WHITESPACE would help. -- Benji York ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] zope.testing for Python 3.1
The py3k branch for zope.testing now mostly passes the tests as well: svn+ssh://rege...@svn.zope.org/repos/main/zope.testing/branches/regebro-python3-reloaded Two tests fail. One is for unicode, and doesn't make sense under Python 3. We can either remove it completely, but it does test a bugfix that was done in the custom doctest.py, and which I moved to a monkey-patch when I got rid of the doctest.py. We should probably make bugreports in the pythontracker for those monkey-patches to, but they still need to be there for current python versions, and should be tested. The other option is to extract it to a separate test, but since it's a doctest of a doctest that's a pain in the böm, so I haven't done that. The other test is the same obscure failure that exist under Python 2.7, indicating that this is an actual change in how Python behaves. Again it needs somebody who understands the Python internals involved and how they changed. -- Lennart Regebro: Python, Zope, Plone, Grok http://regebro.wordpress.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Possible Zope 2.12 regression - Five page templates use restrictedTraverse for TAL
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Martin Aspeli wrote: On 13/12/09 16:49, Martin Aspeli wrote: On 13/12/09 10:52, Tres Seaver wrote: Doesn't smell like a regression to me: the code there hasn't changed in a good long while. Can you write a test case for it, so that we can test against earlier versions? Aha! http://codespeak.net/pipermail/z3-five/2007q2/002185.html This is the same problem. You said: This is becuase 'Products.PageTemplates.Expression.createTrustedZopeEngine' only trusts 'python:' expressions; path traversal is still governed by 'boboAwareZopeTraverse', which uses 'restrictedTraverse'. and then: As it turns out, it is only partially trusted. The attached patch should make them really trusted, at least for path expressions; does it help? I haven't added any tests, although my 2.10 branch checkout does pass all tests with this change The attachment is here: http://codespeak.net/pipermail/z3-five/attachments/20070506/7f8a9ea8/attachment.bin I'm going to poke around a Zope 2.12 checkout for a bit to see what sense I can make of this. Okay, so it turns out your patch has gotten lost from Zope 2.10 to Zope 2.12. This is the revision where it went in: http://zope3.pov.lt/trac/changeset/77064/Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py I think that by accident this got committed with an unrelated change, since the commit message says Use Five 1.5.5 and there's a change in svn:externals. Perhaps that's why this wasn't merged to trunk. The latest merge I can see is at r71802. This also makes me worry about http://zope3.pov.lt/trac/browser/Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py?rev=78766 and http://zope3.pov.lt/trac/browser/Zope/branches/2.10/lib/python/Products/PageTemplates/Expressions.py?rev=93506, which may not have been merged, but I'm too far down the rabbit hole now to see clearly. Anyway, I re-applied your patch to the Zope 2.12 branch. This broke one test, in Products.Five: self.assertEqual(engine.types['standard'], ZopePathExpr) I'd argue that this test is testing for precisely the wrong thing, so I updated this assertion and the ones to follow to check for: self.assertEqual(engine.types['standard'], TrustedZopePathExpr) This fixes the original issue I was seeing. All Zope 2.12 and Plone 4 tests pass with this as well. I also think the fixed test in Five is now correct and sufficient, since it checks that we get the trusted engine for ViewPageTemplateFile's. Maybe we should have a functional test too, but I'm not sure how to set that up. I've committed this in r106436 and merged to trunk in r106437. OK, sounds fine to me. Can you merge to the 2.11 branch as well? I think Andreas will be releasing 2.9.x through 2.12.x fairly soon. If anyone objects, please let me know and I'll back it out. Otherwise, I'm hopeful for a 2.12.2 soon, as this breaks a few things in Plone. :-/ Heh, and after you have been just posting about using SVN develop eggs on your blog. ;) Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksmshYACgkQ+gerLs4ltQ4BNwCfctztlQ5F2uVVSPawCQ/sli2X hpYAoNSveWbE+NUx6G6BYxSEDsFjaa2v =wwi6 -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope2 book: who ripped out the docs on using ExternalMethods?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There used to be a section in the Advanced Zope Scripting chapter which documented using External Methods: why is it gone now? Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksmvG8ACgkQ+gerLs4ltQ55hQCfS2MPCetOILU7JS5ce0PBZCJb GVQAoIFv63t2UtMXeci4lUTmru+Dv1gV =CofU -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope2 book: who ripped out the docs on using ExternalMethods?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tres Seaver wrote: There used to be a section in the Advanced Zope Scripting chapter which documented using External Methods: why is it gone now? Looks like Hanno did this in r96569, 2009-02-15. I'm planning to revert the parts of that change which ripped out perfectly good documentation of a sometimes-useful tool. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksmwRIACgkQ+gerLs4ltQ6anQCdGfkq6qkEjy5MDCW4PpYC7dgD KOEAoK3Ve8xierbzui67z9h2DPeBU4hw =Ulyw -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope2 book: who ripped out the docs on using ExternalMethods?
On Mon, Dec 14, 2009 at 11:49 PM, Tres Seaver tsea...@palladion.com wrote: There used to be a section in the Advanced Zope Scripting chapter which documented using External Methods: why is it gone now? Looks like Hanno did this in r96569, 2009-02-15. I'm planning to revert the parts of that change which ripped out perfectly good documentation of a sometimes-useful tool. I don't remember the details anymore. I did lots of cleanup during that time, trying to no longer encourage outdated practices. But the scope of the book didn't turn out to be about new practices, so it's probably fine to leave all the old stuff in it. Hanno ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Possible Zope 2.12 regression - Five page templates use restrictedTraverse for TAL
On 15/12/09 5:45, Tres Seaver wrote: I've committed this in r106436 and merged to trunk in r106437. OK, sounds fine to me. Can you merge to the 2.11 branch as well? I think Andreas will be releasing 2.9.x through 2.12.x fairly soon. Sure, I'd forgotten about that one. If anyone objects, please let me know and I'll back it out. Otherwise, I'm hopeful for a 2.12.2 soon, as this breaks a few things in Plone. :-/ Heh, and after you have been just posting about using SVN develop eggs on your blog. ;) Right. I can run from a develop egg in this project, but I wouldn't want to ask everyone who uses Plone to do that. :) Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
