[Zope-dev] Re: [Zope-Checkins] SVN: Zope/trunk/lib/python/Shared/DC/ZRDB/ Collector #556: sqlvar now returns 'null' rather than 'None'.
This change breaks Gadfly which doesn't seem to like 'null' at all. I
poked around in ZGadflyDA/gadfly a bit, but it's not obvious to me
how to fix the parser (*.mar files anyone?).
Stefan
[snip]
File /usr/local/Zope-2_8-branch/lib/python/Products/ZGadflyDA/
gadfly/kjParser.py, line 826, in ParseError
raise SyntaxError, 'unexpected token sequence.' + data
SyntaxError: unexpected token sequence.near ::
dca437824c3b0',* null, '', '
***
current state = 252
expects:
'?', 'numeric_literal', 'character_string_literal', '-', '+',
('nomatch1',)
current token = ((-8, 'user_defined_name'), 'NULL')
On 3. Sep 2005, at 01:20, Tres Seaver wrote:
Log message for revision 38276:
Collector #556: sqlvar now returns 'null' rather than 'None'.
Changed:
U Zope/trunk/lib/python/Shared/DC/ZRDB/sqlvar.py
A Zope/trunk/lib/python/Shared/DC/ZRDB/tests/test_sqlvar.py
-=-
Modified: Zope/trunk/lib/python/Shared/DC/ZRDB/sqlvar.py
===
--- Zope/trunk/lib/python/Shared/DC/ZRDB/sqlvar.py2005-09-02
23:15:46 UTC (rev 38275)
+++ Zope/trunk/lib/python/Shared/DC/ZRDB/sqlvar.py2005-09-02
23:20:49 UTC (rev 38276)
@@ -98,6 +98,9 @@
raise
raise ValueError, 'Missing input variable, em%s/
em' % name
+if v is None:
+return 'null'
+
if t=='int':
try:
if type(v) is StringType:
--
Anything that happens, happens. --Douglas Adams
___
Zope-Dev maillist - Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope-Checkins] SVN: Zope/trunk/lib/python/Shared/DC/ZRDB/ Collector #556: sqlvar now returns 'null' rather than 'None'.
--On 8. Oktober 2005 15:41:57 +0200 Stefan H. Holek [EMAIL PROTECTED] wrote: This change breaks Gadfly which doesn't seem to like 'null' at all. I poked around in ZGadflyDA/gadfly a bit, but it's not obvious to me how to fix the parser (*.mar files anyone?). No idea about the specific error but I think we should now officially deprecate Gadfly for Zope 2.9 and get rid of it in Zope 2.11 (:-)). It really provides no functionality to the Zope core. We could rip it of as external product...but it should go away from the core. -aj pgpDAmQrjh0Bx.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope-Checkins] SVN: Zope/trunk/lib/python/Shared/DC/ZRDB/ Collector #556: sqlvar now returns 'null' rather than 'None'.
--On 8. Oktober 2005 16:04:46 +0200 Andreas Jung [EMAIL PROTECTED] wrote: --On 8. Oktober 2005 15:41:57 +0200 Stefan H. Holek [EMAIL PROTECTED] wrote: This change breaks Gadfly which doesn't seem to like 'null' at all. I poked around in ZGadflyDA/gadfly a bit, but it's not obvious to me how to fix the parser (*.mar files anyone?). No idea about the specific error but I think we should now officially deprecate Gadfly for Zope 2.9 and get rid of it in Zope 2.11 (:-)). It really provides no functionality to the Zope core. We could rip it of as external product...but it should go away from the core. Argh...there is also a gadfly package coming from Zope 3. So when we remove it from the Zope 2 core we get it back with Zope 3 :-) -aj pgpw0LBFqEtXw.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Decoding of source for text/xml ZPTs
Hi All, During complication, the XML parser that processes non-HTML mode ZPT's decodes the string of the source into unicode instructions. In HTML mode, the parse does no decoding and so we get string instructions. My question as a result is: what characterset does the XML parser in non-HTML mode assume and can it be controlled in any way? cheers, Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] default encoding used in ZPublisher.
Hi All, I'd like to backport the change I made to fix: http://www.zope.org/Collectors/Zope/1490 ...to the 2.8 branch, would anyone have any objections to this? cheers, Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Decoding of source for text/xml ZPTs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chris Withers wrote: During complication, the XML parser that processes non-HTML mode ZPT's ^ +- compilation, I'm guessing, but see below ;) decodes the string of the source into unicode instructions. In HTML mode, the parse does no decoding and so we get string instructions. My question as a result is: what characterset does the XML parser in non-HTML mode assume and can it be controlled in any way? XML is UTF-8, unless specified in the top-level processing-directive-like thingy the xml declaration), e.g.: ?xml version=1.0 encoding=iso-8859-1b? *or* unless the transmission channel spells the encoding (the HTTP Content-type header, for instance). See Mark Pilrgrim's rant[1] on the insanely compilated interactions between the Content-type header and the document encoding. XML files on the filesystem *must* be encoded as UTF-8, or have an explicity encoding in the declaration. [1] http://diveintomark.org/archives/2004/02/13/xml-media-types Tres. - -- === Tres Seaver +1 202-558-7113 [EMAIL PROTECTED] Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDSA0C+gerLs4ltQ4RAhj+AJ0YVYNJVCmS5Nm7aYm3LMLiq0QUjACdHZge 8S/aikU+0/ZCcBrEZu2fV70= =0O2y -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] default encoding used in ZPublisher.
--On 8. Oktober 2005 19:15:57 +0100 Chris Withers [EMAIL PROTECTED] wrote: Hi All, I'd like to backport the change I made to fix: http://www.zope.org/Collectors/Zope/1490 ...to the 2.8 branch, would anyone have any objections to this? The 2.8 branch is closed for new features. With the time-based schedule new features should appear regularly with new major releases. So only bug fixes should go into minor releases. Andreas pgpPKQ2Bn6iBj.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] default encoding used in ZPublisher.
Andreas Jung wrote: I'd like to backport the change I made to fix: http://www.zope.org/Collectors/Zope/1490 ...to the 2.8 branch, would anyone have any objections to this? The 2.8 branch is closed for new features. With the time-based schedule new features should appear regularly with new major releases. So only bug fixes should go into minor releases. Well, this is arguably a bug fix and I incorrectly filed it as a new feature on the trunk. Yes, it adds a new zope.conf option, and that's why I filed this as a feature, but this is to fix the fact that the hard coded value has left me having to patch Zope for customers to get around the fact that it wrongly encodes strings sent to it by Plone's PlacelessTranslationService as latin-1. The problem is even worse when serving XML generated by a ZPT, which is encoded as latin-1 when it REALLY should be encoded as utf-8... (See Tres' email from earlier this evening) Especially given the near zero risk of this bug (about 6 lines of code changed, and about 7 added) and the 100% backwards compatability (if the new zope.conf option is not included in zope.conf, the default is used and the default is identical to what it was: latin-1), I'd really like to merge this to the 2.8 branch in time for the 2.8.2 release... Can anyone give me any good reasons not to? ;-) Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] default encoding used in ZPublisher.
Andreas Jung wrote: The 2.8 branch is closed for new features. With the time-based schedule new features should appear regularly with new major releases. So only bug fixes should go into minor releases. In fact, just noticing other mails, I'd also like to merge this to the 2.7 branch, I just wasn't aware there was going to be a 2.7.8 release... This would stop the customers in question from having to make the huge leap to 2.8.x, which I was fearing they'd have to in order to get this specific change... cheers, Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] default encoding used in ZPublisher.
Am Samstag, den 08.10.2005, 19:15 +0100 schrieb Chris Withers: Hi All, I'd like to backport the change I made to fix: http://www.zope.org/Collectors/Zope/1490 ...to the 2.8 branch, would anyone have any objections to this? Surely not, but what fix? :-) Nice to see some movement on this issue ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] default encoding used in ZPublisher.
--On 8. Oktober 2005 20:10:21 +0100 Chris Withers [EMAIL PROTECTED] wrote: Andreas Jung wrote: I'd like to backport the change I made to fix: http://www.zope.org/Collectors/Zope/1490 ...to the 2.8 branch, would anyone have any objections to this? The 2.8 branch is closed for new features. With the time-based schedule new features should appear regularly with new major releases. So only bug fixes should go into minor releases. Well, this is arguably a bug fix and I incorrectly filed it as a new feature on the trunk. If you can justify it as a bugfix before god and the world,go ahead :-) Andreas pgprjHrFsbeBu.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] default encoding used in ZPublisher.
Andreas Jung wrote: Well, this is arguably a bug fix and I incorrectly filed it as a new feature on the trunk. If you can justify it as a bugfix before god and the world,go ahead :-) Cool, will do so to the 2.7 and 2.8 branches tomorrow :-) cheers, Chris PS: I'll mark it as a bug fix in the relevent CHANGES.txt ;-) -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
