Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-03 Thread Fred Drake
2009/4/2 Marius Gedminas : > looks like a mistaken assignment of a tuple to a name, while > >  setup( >   >    foo=bar, >   >  ) > > looks like a function call. Agreed; the common use of spaces around the equal signs in setup.py is a holdover from Greg Ward's coding style (Greg being the original

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-02 Thread Marius Gedminas
On Wed, Apr 01, 2009 at 11:44:03PM +0200, Jacob Holm wrote: > If this whitespace fix is based on the current style guide, I think the > guide needs to be fixed. I find the fixed version much less readable. A > function that takes this many arguments should have an exception to the > PEP 8 rule o

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-02 Thread Jim Fulton
On Apr 1, 2009, at 5:44 PM, Jacob Holm wrote: > If this whitespace fix is based on the current style guide, I think so. > I think the > guide needs to be fixed. Me too, but I don't think it will happen. :( > I find the fixed version much less readable. A > function that takes this many argumen

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-02 Thread Benji York
On Thu, Apr 2, 2009 at 9:37 AM, Zvezdan Petkovic wrote: > This would be more consistent, is sorted, and ensures easy addition/ > removal of each line including the first, and the last line in the > lists. > >     install_requires=[ >         'setuptools', >         'zope.component', >         'zop

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-02 Thread Zvezdan Petkovic
On Apr 1, 2009, at 5:44 PM, Jacob Holm wrote: > If this whitespace fix is based on the current style guide, I think > the guide needs to be fixed. I find the fixed version much less > readable. A function that takes this many arguments should have an > exception to the PEP 8 rule of no white

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-02 Thread Jacob Holm
Michael Howitz wrote: > Am 01.04.2009 um 23:44 schrieb Jacob Holm: > >> Hi Baiju >> >> If this whitespace fix is based on the current style guide, I think the >> guide needs to be fixed. I find the fixed version much less readable. A >> function that takes this many arguments should have an excepti

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-02 Thread Michael Howitz
Am 01.04.2009 um 23:44 schrieb Jacob Holm: > Hi Baiju > > If this whitespace fix is based on the current style guide, I think > the > guide needs to be fixed. I find the fixed version much less > readable. A > function that takes this many arguments should have an exception to > the > PEP 8

Re: [Zope-dev] [Checkins] SVN: zope.annotation/trunk/setup.py Whitespace fixes

2009-04-01 Thread Jacob Holm
Hi Baiju If this whitespace fix is based on the current style guide, I think the guide needs to be fixed. I find the fixed version much less readable. A function that takes this many arguments should have an exception to the PEP 8 rule of no whitespace around the equals sign used for keyword a