[Zope-dev] commit(1) in ZCatalog
Hi All, ZCatalog still contains a commit(1) at around line 589 of ZCatalog.py, which is causing the familiar 'Savepoints unsupported' error for us :-( Would there be any problem changing this to a savepoint(optimistic=True) on the 2.8 branch and trunk? cheers, Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] commit(1) in ZCatalog
[Chris Withers] ZCatalog still contains a commit(1) at around line 589 of ZCatalog.py, which is causing the familiar 'Savepoints unsupported' error for us :-( Would there be any problem changing this to a savepoint(optimistic=True) on the 2.8 branch and trunk? There shouldn't be any problem -- go for it. I see that the 2.8 branch already uses transaction.savepoint() here, but should probably use transaction.savepoint(optimistic=True) instead. In the other direction, I see that zope/app/file/file.py still contains two subtxn commits on 2.8 branch, but not anymore on the trunk. That should also be changed on 2.8 branch. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] commit(1) in ZCatalog
Tim Peters wrote: [Chris Withers] ZCatalog still contains a commit(1) at around line 589 of ZCatalog.py, which is causing the familiar 'Savepoints unsupported' error for us :-( Would there be any problem changing this to a savepoint(optimistic=True) on the 2.8 branch and trunk? There shouldn't be any problem -- go for it. I see that the 2.8 branch already uses transaction.savepoint() here, but should probably use transaction.savepoint(optimistic=True) instead. Done. In the other direction, I see that zope/app/file/file.py still contains two subtxn commits on 2.8 branch, but not anymore on the trunk. That should also be changed on 2.8 branch. Hmm, that smells Zope 3-ish to me, and my Zope checkout links that in by svn:externals, so I'll leave that for someone more Zope 3-savy... Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] commit(1) in ZCatalog
[Chris Withers] ZCatalog still contains a commit(1) at around line 589 of ZCatalog.py, which is causing the familiar 'Savepoints unsupported' error for us :-( Would there be any problem changing this to a savepoint(optimistic=True) on the 2.8 branch and trunk? [Tim Peters] There shouldn't be any problem -- go for it. I see that the 2.8 branch already uses transaction.savepoint() here, but should probably use transaction.savepoint(optimistic=True) instead. [Chris] Done. Looks good. Thanks! In the other direction, I see that zope/app/file/file.py still contains two subtxn commits on 2.8 branch, but not anymore on the trunk. That should also be changed on 2.8 branch. Hmm, that smells Zope 3-ish to me, and my Zope checkout links that in by svn:externals, so I'll leave that for someone more Zope 3-savy... Ah, yes. That should go away by magic then if/when someone stitches in a newer version of whichever Zope3 2.8 branch is using. Or not wink. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] commit(1) in ZCatalog
Tim Peters wrote: Ah, yes. That should go away by magic then if/when someone stitches in a newer version of whichever Zope3 2.8 branch is using. Or not wink. ...which can then cause svn:externals to blow up all our checkouts when we update ;-) *wry grinz* Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
