RE: [Zope-dev] dtml-in batching improved

2001-06-19 Thread Jean Lagarde

Ivo, somehow I had missed the very start of the thread. I think that my
change pretty much implements the third alternative you describe in your
post, but for which you provided no patch (the one which defines the
variables at the top and bottom only, because I leave the "if
index==first or index==last" test). You are right that my change could
break existing code, but I think not as badly as defining the variables for
every
iteration.

In any case, I will keep the change in my version until I notice a side
effect that I don't like.

Cheers,

Jean

> -Original Message-
> From: Ivo van der Wijk
> Sent: Monday, June 18, 2001 7:31 AM
>
> This is basically my patch #1. It makes previous-sequence-* and
> next-sequence-* available throughout the entire dtml-in loop.
>
> This sounds like a good fix, but people may rely on these variables
> being only set at resp. the start and end of the iteration.
>
> So this patch may break existing dtml code.
>
> That's why I suggested patch #2, which introduces new variables. Old
> code will continue to work, but people who want the problem fixed can
> use the newly introduced variables, which are available throughout the
> iteration.
>
>   Ivo


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-06-18 Thread Ivo van der Wijk

On Wed, Jun 13, 2001 at 04:28:12PM -0700, Jean Lagarde wrote:
> Good day all,
> 
> 
> Here is the original code, with my annotated change (I deleted an if test in
> two places):
> 
>  for index in range(first,end):
> # preset
> kw['previous-sequence']= 0
> kw['next-sequence']= 0 # now more often defined then
> previously
> #
> if index==first or index==last:
> # provide batching information
> if first > 0:
> pstart,pend,psize=opt(0,first+overlap,
>   sz,orphan,sequence)
>  deleted this test -->  if index==first: kw['previous-sequence']=1
> kw['previous-sequence-start-index']=pstart-1
> kw['previous-sequence-end-index']=pend-1
> kw['previous-sequence-size']=pend+1-pstart

(more similar code removed)

This is basically my patch #1. It makes previous-sequence-* and
next-sequence-* available throughout the entire dtml-in loop.

This sounds like a good fix, but people may rely on these variables
being only set at resp. the start and end of the iteration.

So this patch may break existing dtml code.

That's why I suggested patch #2, which introduces new variables. Old 
code will continue to work, but people who want the problem fixed can
use the newly introduced variables, which are available throughout the 
iteration.

Ivo

-- 
Drs. I.R. van der Wijk  -=-
Brouwersgracht 132  Amaze Internet Services V.O.F.
1013 HA Amsterdam   -=-
Tel: +31-20-4688336  Linux/Web/Zope/SQL
Fax: +31-20-4688337   Network Solutions
Web: http://www.amaze.nl/Consultancy
Email:   [EMAIL PROTECTED]   -=-

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-06-13 Thread Jean Lagarde

Good day all,

I wouldn't consider myself as a Zope developper, but since that's where the
thread was...

I've read the thread with interest but so far all I've read in it are
workarounds that I do not find particularly nice. I did find a bug w/patch
in the collector (#1317), which I thought was meant to correct the problem,
but the patch has been applied to my version (2.3.2), and dtml-in evidently
still did not behave as expected. So I've looked at it more closely and
found what I think is a fix, but given my inexperience, I would like to know
if others think that I'm doing something wrong. I've tested the change for a
while on my application, and everything seems to work so far.

Here is the original code, with my annotated change (I deleted an if test in
two places):

 for index in range(first,end):
# preset
kw['previous-sequence']= 0
kw['next-sequence']= 0 # now more often defined then
previously
#
if index==first or index==last:
# provide batching information
if first > 0:
pstart,pend,psize=opt(0,first+overlap,
  sz,orphan,sequence)
 deleted this test -->  if index==first: kw['previous-sequence']=1
kw['previous-sequence-start-index']=pstart-1
kw['previous-sequence-end-index']=pend-1
kw['previous-sequence-size']=pend+1-pstart
try:
# The following line is a sneaky way to
# test whether there are more items,
# without actually computing a length:
sequence[end]
pstart,pend,psize=opt(end+1-overlap,0,
  sz,orphan,sequence)
 deleted this test -->  if index==last: kw['next-sequence']=1
kw['next-sequence-start-index']=pstart-1
kw['next-sequence-end-index']=pend-1
kw['next-sequence-size']=pend+1-pstart
except: pass

if index==last: kw['sequence-end']=1

Cheers,

Jean


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



RE: [Zope-dev] dtml-in batching improved

2001-06-05 Thread Adrian Hungate
Title: RE: [Zope-dev] dtml-in batching improved





Back before the zope.org product directory became so easy to navigate I wrote an index
that I used to use which has batch links top and bottom:


http://www.zope.org/Members/haqa/productlist/view_source


Dunno if this helps...


Adrian...


-Original Message-
From: Chris Withers [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, 30 May 2001 22:03
To: Ivo van der Wijk; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Simon Coles
Subject: Re: [Zope-dev] dtml-in batching improved



> When using batching in dtml-in, why is 'previous-sequence' only defined at
> the first iteration of the current batch? And why is 'next-sequence' only
> defined at the last iteration of the current batch?


I know this problem ;-)


I had it too, and stuck something in the collector about it. I did manage to
get the layout you're after without modifying Zope though (see the search
page on www.nipltd.com)


If you want the code, maybe someone at NIP could fish it out, if you can
wait until next Thursday, I'll grab it myself :-)


cheers,


Chris




___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )





Re: [Zope-dev] dtml-in batching improved

2001-06-03 Thread Chris Withers

> > > Nope, my solution used only one dtml-in and maybe a dtml-let, no
REQUEST
> > > munging :-)
> > >
> > Ok, show me :)
>
> Hurm... gimme a shout next Thursday when I have access to the code again
;-)

Actually, scratch that, check out the folder_contents.dtml file in
CMFDefault/skins of the CMF.
It does some cunning REQUEST variable setting that eliminates the need for
the fanciness I used...

cheers,

Chris


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-06-02 Thread Chris Withers

> > Nope, my solution used only one dtml-in and maybe a dtml-let, no REQUEST
> > munging :-)
> >
> Ok, show me :)

Hurm... gimme a shout next Thursday when I have access to the code again ;-)

cheers,

Chris


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-06-01 Thread Ivo van der Wijk

On Thu, May 31, 2001 at 05:36:21PM +0100, Chris Withers wrote:
> > I've done it myself as well using (as described in the posting) two
> > dtml-in's (the second one purely for displaying the prev/next links).
> >
> > Is your solution any different? (The only one I can think of is storing
> > the info in your REQUEST object and using it later, but that's really
> > ugly.)
> 
> Nope, my solution used only one dtml-in and maybe a dtml-let, no REQUEST
> munging :-)
> 

Ok, show me :)

Ivo

-- 
Drs. I.R. van der Wijk  -=-
Brouwersgracht 132  Amaze Internet Services V.O.F.
1013 HA Amsterdam   -=-
Tel: +31-20-4688336  Linux/Web/Zope/SQL
Fax: +31-20-4688337   Network Solutions
Web: http://www.amaze.nl/Consultancy
Email:   [EMAIL PROTECTED]   -=-

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-05-31 Thread Chris Withers

> I've done it myself as well using (as described in the posting) two
> dtml-in's (the second one purely for displaying the prev/next links).
>
> Is your solution any different? (The only one I can think of is storing
> the info in your REQUEST object and using it later, but that's really
> ugly.)

Nope, my solution used only one dtml-in and maybe a dtml-let, no REQUEST
munging :-)

cheers,

Chris


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-05-31 Thread Casey Duncan

Ivo van der Wijk wrote:
> 
> On Wed, May 30, 2001 at 10:02:31PM +0100, Chris Withers wrote:
> > > When using batching in dtml-in, why is 'previous-sequence' only defined at
> > > the first iteration of the current batch? And why is 'next-sequence' only
> > > defined at the last iteration of the current batch?
> >
> > I know this problem ;-)
> >
> > I had it too, and stuck something in the collector about it. I did manage to
> > get the layout you're after without modifying Zope though (see the search
> > page on www.nipltd.com)
> >
> 
> I've done it myself as well using (as described in the posting) two
> dtml-in's (the second one purely for displaying the prev/next links).
> 
> Is your solution any different? (The only one I can think of is storing
> the info in your REQUEST object and using it later, but that's really
> ugly.)
> 

AFAIK that is what the next and previous options for dtml-in are for.
Usually
I just store the sequence (if it is a query) in a variable using a let
around
three (or more) dtml-ins. Two of which use the next or previous option
to create
the batching links.

-- 
| Casey Duncan
| Kaivo, Inc.
| [EMAIL PROTECTED]
`-->

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-05-31 Thread Ivo van der Wijk

On Wed, May 30, 2001 at 10:02:31PM +0100, Chris Withers wrote:
> > When using batching in dtml-in, why is 'previous-sequence' only defined at
> > the first iteration of the current batch? And why is 'next-sequence' only
> > defined at the last iteration of the current batch?
> 
> I know this problem ;-)
> 
> I had it too, and stuck something in the collector about it. I did manage to
> get the layout you're after without modifying Zope though (see the search
> page on www.nipltd.com)
> 

I've done it myself as well using (as described in the posting) two
dtml-in's (the second one purely for displaying the prev/next links).

Is your solution any different? (The only one I can think of is storing
the info in your REQUEST object and using it later, but that's really
ugly.)

Ivo

-- 
Drs. I.R. van der Wijk  -=-
Brouwersgracht 132  Amaze Internet Services V.O.F.
1013 HA Amsterdam   -=-
Tel: +31-20-4688336  Linux/Web/Zope/SQL
Fax: +31-20-4688337   Network Solutions
Web: http://www.amaze.nl/Consultancy
Email:   [EMAIL PROTECTED]   -=-

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching improved

2001-05-31 Thread Chris Withers

> When using batching in dtml-in, why is 'previous-sequence' only defined at
> the first iteration of the current batch? And why is 'next-sequence' only
> defined at the last iteration of the current batch?

I know this problem ;-)

I had it too, and stuck something in the collector about it. I did manage to
get the layout you're after without modifying Zope though (see the search
page on www.nipltd.com)

If you want the code, maybe someone at NIP could fish it out, if you can
wait until next Thursday, I'll grab it myself :-)

cheers,

Chris



___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )



Re: [Zope-dev] dtml-in batching

2001-01-24 Thread Chris Withers

[EMAIL PROTECTED] wrote:

> Well that's odd - I searched the collector for "dtml-in" and got no
> matches. 

that's because of the - in dtml-in being treated as a stop character by
ZCatalog.

Ironically, ZCatalog is not very good at indexing stuff that contains
documentation about Zope, stripping out characters like _ - and . :-S

cheers,

Chris

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-23 Thread Brad Clements

On 24 Jan 2001, at 11:15, [EMAIL PROTECTED] wrote:


> Brad Clements wrote:

> > I posted this same bug AND a patch as bug # 1566 on Aug 28th, 2000.
> > 
> > http://classic.zope.org:8080/Collector/1566/view
> > 
> > Sad to see its *still* pending
> 
> Well that's odd - I searched the collector for "dtml-in" and got no
> matches. A search for "renderwb" (which is in the title) works. Looks like
> it doesn't search the description after all. Boo to the search engine.
> 
> Just curious: why specify the browser/platform/python version stuff when
> the problem is independant of those things?
> 

Because I'm Anal Retentive.

Also figured perhaps my entry would be ignored without that information.

Or worse the form would be rejected on submit because those fields 
where blank AND it wouldn't remember what I'd put in AND back would 
fail.

So, I filled out the form entirely.


Brad Clements,[EMAIL PROTECTED]   (315)268-1000
http://www.murkworks.com  (315)268-9812 Fax
netmeeting: ils://ils.murkworks.com   AOL-IM: BKClements

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-23 Thread richard

Brad Clements wrote:
> On 24 Jan 2001, at 9:43, [EMAIL PROTECTED] wrote:
> > Tres Seaver wrote:
> 
> > > Please post this as a "Bug w/ patch" to the Collector:
> > >
> > >  http://classic.zope.org:8080/Collector
> > >
> > > That way we don't lose your fix in the list traffic (losing it
> > > along with our marbles is another problem :)
> >
> >Someone else responded to the list saying that he'd already done it.
> > There was no match to my search of dtml-in though, so I've submitted a new
> > bug report.
> 
> I posted this same bug AND a patch as bug # 1566 on Aug 28th, 2000.
> 
> http://classic.zope.org:8080/Collector/1566/view
> 
> Sad to see its *still* pending

Well that's odd - I searched the collector for "dtml-in" and got no
matches. A search for "renderwb" (which is in the title) works. Looks like
it doesn't search the description after all. Boo to the search engine.

Just curious: why specify the browser/platform/python version stuff when
the problem is independant of those things?


Richard

ps. Brad, sorry I referred to you as "someone else" - I lost the email with
your name in it ;)

-- 
Richard Jones
[EMAIL PROTECTED]
Senior Software Developer, Bizar Software (www.bizarsoftware.com.au)

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-23 Thread Brad Clements

On 24 Jan 2001, at 9:43, [EMAIL PROTECTED] wrote:

> Tres Seaver wrote:

> > Please post this as a "Bug w/ patch" to the Collector:
> > 
> >  http://classic.zope.org:8080/Collector
> > 
> > That way we don't lose your fix in the list traffic (losing it
> > along with our marbles is another problem :)
> 
>Someone else responded to the list saying that he'd already done it.
> There was no match to my search of dtml-in though, so I've submitted a new
> bug report.


I posted this same bug AND a patch as bug # 1566 on Aug 28th, 2000.


http://classic.zope.org:8080/Collector/1566/view

Sad to see its *still* pending



Brad Clements,[EMAIL PROTECTED]   (315)268-1000
http://www.murkworks.com  (315)268-9812 Fax
netmeeting: ils://ils.murkworks.com   AOL-IM: BKClements

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-23 Thread Tres Seaver

On Wed, 24 Jan 2001 [EMAIL PROTECTED] wrote:

> Tres Seaver wrote:
>
> > Please post this as a "Bug w/ patch" to the Collector:
> > 
> >  http://classic.zope.org:8080/Collector
> > 
> > That way we don't lose your fix in the list traffic (losing it
> > along with our marbles is another problem :)
> 
> Someone else responded to the list saying that he'd already
> done it.  There was no match to my search of dtml-in though, so
> I've submitted a new bug report.

Thanks very much!

Tres.
-- 
===
Tres Seaver[EMAIL PROTECTED]
Digital Creations "Zope Dealers"   http://www.zope.org


___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-23 Thread richard

Tres Seaver wrote:
> 
> [EMAIL PROTECTED] wrote:
> > [EMAIL PROTECTED] wrote:
> > >
> > > The dtml-in batching mechanisms are quite difficult to debug - the DTML
> > > documentation I have has examples which break it and there's no indication
> > > of why. It turns out the DT_In renderwb() code gobbles all exceptions from
> > > the rendering of the previous and next blocks. I've hacked my code so that
> > > there's no try/except clause any more. I'm not sure what exception it's
> > > trying to catch, but could it perhaps be made a little more picky?
> >
> > And here's a diff - I'm pretty sure this was the intended behaviour...
> 
> Please post this as a "Bug w/ patch" to the Collector:
> 
>  http://classic.zope.org:8080/Collector
> 
> That way we don't lose your fix in the list traffic (losing it
> along with our marbles is another problem :)

   Someone else responded to the list saying that he'd already done it.
There was no match to my search of dtml-in though, so I've submitted a new
bug report.


  Richard

-- 
Richard Jones
[EMAIL PROTECTED]
Senior Software Developer, Bizar Software (www.bizarsoftware.com.au)

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-23 Thread Tres Seaver

[EMAIL PROTECTED] wrote:
> [EMAIL PROTECTED] wrote:
> > 
> > The dtml-in batching mechanisms are quite difficult to debug - the DTML
> > documentation I have has examples which break it and there's no indication
> > of why. It turns out the DT_In renderwb() code gobbles all exceptions from
> > the rendering of the previous and next blocks. I've hacked my code so that
> > there's no try/except clause any more. I'm not sure what exception it's
> > trying to catch, but could it perhaps be made a little more picky?
> 
> And here's a diff - I'm pretty sure this was the intended behaviour...

Please post this as a "Bug w/ patch" to the Collector:

 http://classic.zope.org:8080/Collector

That way we don't lose your fix in the list traffic (losing it
along with our marbles is another problem :)

Tres.
-- 
===
Tres Seaver[EMAIL PROTECTED]
Digital Creations "Zope Dealers"   http://www.zope.org

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-22 Thread Brad Clements

This was submitted to the collect quite a while ago as a bug..

Also I submitted a patch about 2 months ago for this, about the same 
patch as yours.

On 22 Jan 2001, at 12:03, [EMAIL PROTECTED] wrote:

From:   [EMAIL PROTECTED]
Date sent:  Mon, 22 Jan 2001 12:03:14 +1100
To: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
Subject:            Re: [Zope-dev] dtml-in batching

> [EMAIL PROTECTED] wrote:
> > 
> > The dtml-in batching mechanisms are quite difficult to debug - the DTML
> > documentation I have has examples which break it and there's no
> > indication of why. It turns out the DT_In renderwb() code gobbles all
> > exceptions from the rendering of the previous and next blocks. I've
> > hacked my code so that there's no try/except clause any more. I'm not
> > sure what exception it's trying to catch, but could it perhaps be made a
> > little more picky?
> 
> And here's a diff - I'm pretty sure this was the intended behaviour...
> 
> 
> *** /tmp/DT_In.py.origMon Jan 22 12:00:53 2001
> --- DT_In.py  Mon Jan 22 12:00:58 2001
> ***
> *** 561,566 
> --- 561,570 
>   # there are more items, without actually
>   # computing a length:
>   sequence[end]
> + except IndexError:
> + if self.elses: result=render(self.elses, md)
> + else: result=''
> + else:
>   pstart,pend,psize=opt(end+1-overlap,0,
>  sz,orphan,sequence)
>   kw['next-sequence']=1
> ***
> *** 568,576 
>   kw['next-sequence-end-index']=pend-1
>   kw['next-sequence-size']=pend+1-pstart
>   result=render(section,md)
> - except:
> - if self.elses: result=render(self.elses, md)
> - else: result=''
>   else:
>   result = []
>   append=result.append
> --- 572,577 
> 
> 
> -- 
> Richard Jones
> [EMAIL PROTECTED]
> Senior Software Developer, Bizar Software (www.bizarsoftware.com.au)
> 



Brad Clements,[EMAIL PROTECTED]   (315)268-1000
http://www.murkworks.com  (315)268-9812 Fax
netmeeting: ils://ils.murkworks.com   AOL-IM: BKClements

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-21 Thread richard

[EMAIL PROTECTED] wrote:
> 
> The dtml-in batching mechanisms are quite difficult to debug - the DTML
> documentation I have has examples which break it and there's no indication
> of why. It turns out the DT_In renderwb() code gobbles all exceptions from
> the rendering of the previous and next blocks. I've hacked my code so that
> there's no try/except clause any more. I'm not sure what exception it's
> trying to catch, but could it perhaps be made a little more picky?

And here's a diff - I'm pretty sure this was the intended behaviour...


*** /tmp/DT_In.py.orig  Mon Jan 22 12:00:53 2001
--- DT_In.pyMon Jan 22 12:00:58 2001
***
*** 561,566 
--- 561,570 
  # there are more items, without actually
  # computing a length:
  sequence[end]
+ except IndexError:
+ if self.elses: result=render(self.elses, md)
+ else: result=''
+ else:
  pstart,pend,psize=opt(end+1-overlap,0,
sz,orphan,sequence)
  kw['next-sequence']=1
***
*** 568,576 
  kw['next-sequence-end-index']=pend-1
  kw['next-sequence-size']=pend+1-pstart
  result=render(section,md)
- except:
- if self.elses: result=render(self.elses, md)
- else: result=''
  else:
  result = []
  append=result.append
--- 572,577 


-- 
Richard Jones
[EMAIL PROTECTED]
Senior Software Developer, Bizar Software (www.bizarsoftware.com.au)

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )




Re: [Zope-dev] dtml-in batching

2001-01-21 Thread richard

[EMAIL PROTECTED] wrote:
> 
> The dtml-in batching mechanisms are quite difficult to debug - the DTML
> documentation I have has examples which break it and there's no indication
> of why. It turns out the DT_In renderwb() code gobbles all exceptions from
> the rendering of the previous and next blocks. I've hacked my code so that
> there's no try/except clause any more. I'm not sure what exception it's
> trying to catch, but could it perhaps be made a little more picky?

   Re-glancing at the code shows me that this is only the case for the next
block. Sorry about that.

-- 
Richard Jones
[EMAIL PROTECTED]
Senior Software Developer, Bizar Software (www.bizarsoftware.com.au)

___
Zope-Dev maillist  -  [EMAIL PROTECTED]
http://lists.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://lists.zope.org/mailman/listinfo/zope-announce
 http://lists.zope.org/mailman/listinfo/zope )