Re: [Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
Philipp von Weitershausen wrote: Wichert Akkerman wrote: Previously Philipp von Weitershausen wrote: Jim Fulton wrote: Uh, why are we parsing the entries file? To get the current revision of the Zope 3 checkout... Why not use svn info --xml? or even just svn info... I think we (Christian Theune and I) chose to poke at CVS/Tag and .svn/entries later because you may not know where the cvs/svn executable is installed (it may not be on your $PATH). Ugh, it was me. I switched ZopeVersion from CSV to SVN, moreover the first revision (25322) used 're' module to parse .svn/entries and later (41452) has been switched to use 'xml.dom.minidom'. I think extract information from .svn/entries is more safe way than use svn info/svnversion but however it require more maintaining effort. So I'll change the parser to make it more robust if no one objects. -- Dmitry Vasiliev (dima at hlabs.spb.ru) http://hlabs.spb.ru ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
Previously Dmitry Vasiliev wrote: Ugh, it was me. I switched ZopeVersion from CSV to SVN, moreover the first revision (25322) used 're' module to parse .svn/entries and later (41452) has been switched to use 'xml.dom.minidom'. I think extract information from .svn/entries is more safe way than use svn info/svnversion but however it require more maintaining effort. So I'll change the parser to make it more robust if no one objects. I would suggest using svnversion first if that exists, and possibly doing a fallback to parsing things by hand. The output of svnversion is much more accurate than a single revision number. Wichert. -- Wichert Akkerman [EMAIL PROTECTED]It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
Wichert Akkerman wrote: Previously Dmitry Vasiliev wrote: Ugh, it was me. I switched ZopeVersion from CSV to SVN, moreover the first revision (25322) used 're' module to parse .svn/entries and later (41452) has been switched to use 'xml.dom.minidom'. I think extract information from .svn/entries is more safe way than use svn info/svnversion but however it require more maintaining effort. So I'll change the parser to make it more robust if no one objects. I would suggest using svnversion first if that exists, and possibly doing a fallback to parsing things by hand. The output of svnversion is much more accurate than a single revision number. Current implementation of ZopeVersion also extracts tag/branch information so I guess it's better to use 'svn info' instead of 'svnversion'. -- Dmitry Vasiliev (dima at hlabs.spb.ru) http://hlabs.spb.ru ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
On Sep 22, 2006, at 7:40 PM, Philipp von Weitershausen wrote: Jim Fulton wrote: Uh, why are we parsing the entries file? To get the current revision of the Zope 3 checkout... That seems excessive to me. Let's stop. Jim -- Jim Fulton mailto:[EMAIL PROTECTED]Python Powered! CTO (540) 361-1714 http://www.python.org Zope Corporationhttp://www.zope.com http://www.zope.org ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
Previously Philipp von Weitershausen wrote: Jim Fulton wrote: Uh, why are we parsing the entries file? To get the current revision of the Zope 3 checkout... Why not use svn info --xml? Wichert. -- Wichert Akkerman [EMAIL PROTECTED]It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
Wichert Akkerman wrote: Previously Philipp von Weitershausen wrote: Jim Fulton wrote: Uh, why are we parsing the entries file? To get the current revision of the Zope 3 checkout... Why not use svn info --xml? or even just svn info... I think we (Christian Theune and I) chose to poke at CVS/Tag and .svn/entries later because you may not know where the cvs/svn executable is installed (it may not be on your $PATH). ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
On Sat, Sep 23, 2006 at 11:21:38AM +0200, Philipp von Weitershausen wrote: | Wichert Akkerman wrote: | Previously Philipp von Weitershausen wrote: | Jim Fulton wrote: | Uh, why are we parsing the entries file? | To get the current revision of the Zope 3 checkout... | | Why not use svn info --xml? | | or even just svn info... Or svnversion! -- Sidnei da Silva Enfold Systemshttp://enfoldsystems.com Fax +1 832 201 8856 Office +1 713 942 2377 Ext 214 ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] Re: Subversion 1.4 breaks mkzopeinstance.py
Jim Fulton wrote: Uh, why are we parsing the entries file? To get the current revision of the Zope 3 checkout... mkzopeinstance.py fails with; ... File C:\Python24\Lib\site-packages\zope3\src\zope\app\applicationcontrol\zope version.py, line 68, in __setSVNVersion doc = parse(entriesfile) File C:\Python24\lib\site-packages\xml\dom\minidom.py, line 1915, in parse return expatbuilder.parse(file) File C:\Python24\lib\site-packages\xml\dom\expatbuilder.py, line 926, in par se result = builder.parseFile(fp) File C:\Python24\lib\site-packages\xml\dom\expatbuilder.py, line 207, in par seFile parser.Parse(buffer, 0) xml.parsers.expat.ExpatError: syntax error: line 1, column 0 from http://subversion.tigris.org/svn_1.4_releasenotes.html; The way in which the Subversion client manages your working copy has undergone radical changes. The .svn/entries file is no longer XML, and the client has become smarter about the way it manages and stores property metadata. ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
