Re: [Zope3-dev] uniformly configurable request factories: bugfix or proposal?
On Aug 4, 2005, at 11:17 PM, Stephan Richter wrote: On Thursday 04 August 2005 22:40, Gary Poster wrote: When trying to determine a plug point for some functionality we were contemplating, Fred Drake and I were surprised to see that zope.app.publication.httpfactory.HTTPPublicationRequestFactory allowed for specifying the SOAP request factory, but not any of the other request factories (HTTPRequest, BrowserRequest, XMLRPCRequest). This smells like an oversight/bug. I'd like to fix this for 3.1. Shrug, this is a risky change. If something goes wrong there, a lot of code will be screwed. I agree it is fairly trivial to fix, but I would prefer it to be done right. I plan to address the entire HTTPRequest/ Publication/... issue with the Twisted integration work. Shrug. :-) OK. I hope the Request is pluggable then, and that it still uses (a descendent of) the current Zope 3 request object. For a specific application it would be as easy to write your custom HTTPPublicationRequestFactory. Right, but currently that means you have to define your own server-- and instantiate it in zope.conf rather than the standard HTTP server in order for it to be hooked in. That's relatively easy, but *way* heavier feeling than I wanted. I wanted to add some functionality to the request, not declare a new server type. :-/ Gary ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] uniformly configurable request factories: bugfix or proposal?
On Thursday 04 August 2005 22:40, Gary Poster wrote: > When trying to determine a plug point for some functionality we were > contemplating, Fred Drake and I were surprised to see that > zope.app.publication.httpfactory.HTTPPublicationRequestFactory > allowed for specifying the SOAP request factory, but not any of the > other request factories (HTTPRequest, BrowserRequest, > XMLRPCRequest). This smells like an oversight/bug. I'd like to fix > this for 3.1. Shrug, this is a risky change. If something goes wrong there, a lot of code will be screwed. I agree it is fairly trivial to fix, but I would prefer it to be done right. I plan to address the entire HTTPRequest/Publication/... issue with the Twisted integration work. For a specific application it would be as easy to write your custom HTTPPublicationRequestFactory. Regards, Stephan -- Stephan Richter CBU Physics & Chemistry (B.S.) / Tufts Physics (Ph.D. student) Web2k - Web Software Design, Development and Training ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] uniformly configurable request factories: bugfix or proposal?
When trying to determine a plug point for some functionality we were contemplating, Fred Drake and I were surprised to see that zope.app.publication.httpfactory.HTTPPublicationRequestFactory allowed for specifying the SOAP request factory, but not any of the other request factories (HTTPRequest, BrowserRequest, XMLRPCRequest). This smells like an oversight/bug. I'd like to fix this for 3.1. The fix should be fairly innocuous--follow the same pattern as the soap request factory, but default to the standard request factories (I could not do any default and just require the factory registration, but that seems too big of a change for this stage of 3.1: """zapi.queryUtility(IBrowserRequest, BrowserRequest)""" feels to be a much gentler change). Does anyone object? If so, do you object for 3.1, or generally? Gary ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
