Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1090083-deepEqual/+merge/158509
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug1090083-deepEqual into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1090083-deepEqual/+merge/158509
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1090083-deepEqual-2013-04-15T13-13-51.893Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1090083-deepEqual/+merge/158509
Your team Zorba Coders is subscribed to branch lp:zorba.
Validation queue job bug1090083-deepEqual-2013-04-15T13-13-51.893Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1090083-deepEqual/+merge/158509
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/hof-next into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your
The proposal to merge lp:~zorba-coders/zorba/bug1090083-deepEqual into lp:zorba
has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1090083-deepEqual/+merge/158509
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-next-2013-04-15T13-40-26.669Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/hof-next into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job hof-next-2013-04-15T13-40-26.669Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/hof-next into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your
The proposal to merge lp:~zorba-coders/zorba/hof-next into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-next-2013-04-15T14-23-55.986Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/hof-next into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job hof-next-2013-04-15T14-23-55.986Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/hof-next into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-15T16-55-56.486Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/bug1123835 into
lp:zorba.
Commit message:
Fixes for FOTS errors in fn:unparsed-text* functions
Requested reviews:
Chris Hillery (ceejatec)
Related bugs:
Bug #1123835 in Zorba: fn-unparsed-text* failures (at least 20 failures)
This branch doesn't solve all the errors yet this is the list of errors missing
solution with a brief description of the current problem.
The missing errors are caused by 3 problems
* utf-8 encoding: missing the stream suggested to Paul that can handle errors
when invalid utf-8 are found.
*
The attempt to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
Hi regarding the issue of not using the flag for INF values.
The thing is the following whenever you ask for the value of a INF or -INF
number you will get the highest positive or negative number available
9223372036854775807 or -9223372036854775807 being the case for 32 bits.
So I though of
I made some modifications and the current solution uses 1 less check which will
make it 3 and 4 and the numeric solution would have 0 extra flag checks but it
still has the problem that with INF values it will do extra operations.
--
I apologize I made a mistake the numeric Value for INF and -INF is the same
-9223372036854775808 (0x8000) which would make solving this issue
with flags more complex than what I described.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-15T21-01-08.051Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/hof-next into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your
The attempt to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into
lp:zorba has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-next-2013-04-15T21-24-58.908Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
I agree with your logic, Juan; thanks for spelling it out. I hadn't realized
that your new flag were not checked in the inner loop of fn:subsequence(), but
looking at the implementation it appears that is the case. So I have no problem
with it.
Voting Approve now, although
The attempt to merge lp:~zorba-coders/zorba/hof-next into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job hof-next-2013-04-15T21-24-58.908Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/hof-next into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
--
https://code.launchpad.net/~zorba-coders/zorba/hof-next/+merge/158213
Your
Chris Hillery has proposed merging lp:~zorba-coders/zorba/bug-1169191 into
lp:zorba.
Commit message:
Only attempt to resolve a base URI against the entity-retrieval URI if said
entity-retrieval URI itself absolute.
Requested reviews:
Chris Hillery (ceejatec)
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/bug-1169191 into lp:zorba has been
updated.
Commit Message changed to:
Only attempt to resolve a base URI against the entity-retrieval URI if said
entity-retrieval URI itself absolute.
For more details, see:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1169191/+merge/159035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485
--
https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1147563-2013-04-15T23-46-04.439Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug1147563-2013-04-15T23-46-04.439Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485
--
https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485
Review: Needs Fixing
1. It looks like you didn't check in some changes? sequences_impl.cpp refers to
a method URI::get_encoded_fragment() that doesn't exist.
2. sequences_impl.cpp now shows up on my system as ISO-8859 English text
rather than ASCII English text when I use the file command. My
Ok, maybe ignore point #1 - that function is there after all. I'm not sure how
I missed it; must have been a typo in my search. Anyway, I'll review the code
more thoroughly a bit later tonight. Points #2 and #3 still need to be fixed.
--
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/bug1103819-catchAll
into lp:zorba.
Commit message:
Fix catch ( ... ) in XML loaders.
Requested reviews:
Cezar Andrei (cezar-andrei)
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1103819 in Zorba: Use of catch (...) should be reduced
The proposal to merge lp:~zorba-coders/zorba/bug1103819-catchAll into lp:zorba
has been updated.
Commit Message changed to:
Fix catch ( ... ) in XML loaders.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug1103819-catchAll-2013-04-16T00-51-56.543Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job bug1103819-catchAll-2013-04-16T00-51-56.543Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053
Your team Zorba Coders is subscribed to
The proposal to merge lp:~zorba-coders/zorba/bug1103819-catchAll into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053
--
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/bug-1085408 into
lp:zorba.
Commit message:
Fixed signed integer overflow bug.
Requested reviews:
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1085408 in Zorba: xs:date(): casting large year values
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1085408/+merge/159063
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~paul-lucas/zorba/bug-1085408 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1085408/+merge/159063
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1085408/+merge/159063
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1085408-2013-04-16T02-33-43.66Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/bug-1085408/+merge/159063
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Commit message:
1. Added atoll( char const *buf, char const *end, char const **last );
2. Added more aton() functions.
3. Fixed handling of integer overflow.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team
The attempt to merge lp:~paul-lucas/zorba/bug-1085408 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1085408-2013-04-16T02-33-43.66Z is finished. The
final
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-04-16T02-57-42.841Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba failed. Below
is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job pjl-misc-2013-04-16T02-57-42.841Z is finished. The
final status
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-04-16T03-53-40.529Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job pjl-misc-2013-04-16T03-53-40.529Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve.
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/159064
Your team
62 matches
Mail list logo
