> Also, you have at least one typo in archive.xq.
>
> Always remember to run
>
> ctest -R moduleDocumentation
>
> before committing, to be sure that your XQDoc is syntactically correct and
> that you didn't forget to document any parameters, etc.
Done.
--
https://code.launchpad.net/~zorba-c
> In archive_module.cpp:
>
> 1. Please don't leave commented-out code. Just delete it; it's in the version
> history if we ever need to refer back to it. For example, remove these lines:
>
> +//Item lNameItem = theFactory->createString(lName);
> +//lMemberName = theFactory->createString("
Review: Needs Information
I have no idea what problem this MP is supposed to solve; nor do I know what a
"data guide" is.
--
https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.ne
Review: Needs Fixing
The following query crashes:
xquery version "3.0";
import module namespace ddl =
"http://www.zorba-xquery.com/modules/store/dynamic/collections/ddl";;
import module namespace dml =
"http://www.zorba-xquery.com/modules/store/dynamic/collections/dml";;
import module namespac
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/58/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/jdbc-maria
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
:
Votes: {'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
Your team Zorba Coders is subscribed to branch lp
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
You
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://lau
The proposal to merge lp:~zorba-coders/zorba/jdbc-mariadb-driver into
lp:zorba/jdbc-module has been updated.
Commit Message changed to:
Additional expected result when using MariaDB JDBC driver.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177
Chris Hillery has proposed merging lp:~zorba-coders/zorba/jdbc-mariadb-driver
into lp:zorba/jdbc-module.
Commit message:
Additional expected result when using MariaDB JDBC driver.
Requested reviews:
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba
Review: Needs Information
> > - In the following query, no dataguide seems to be pushed into the parser.
> > Why?
>
> The count() function is marked with the %explores-json annotation, because
> pruning objects that reach the function will modify the returned result. That
> is why the dataguide i
Apparently the Expath HTTP Client queries 2 and 3 fail on the zorba demo website
(http://zorbawebsite2.my28msec.com/html/demo)
This does not seem to depend on the latest http client merge which apparently
is not there yet.
Is this a known problem?
--
https://code.launchpad.net/~zorba-coders/zor
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba
has been updated.
Commit Message changed to:
HTTP client request/response conversion in a separate module
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
--
ht
Ready for review.
This is updates the expath http client to be based on the wrapper module
introduced in lp:~zorba-coders/zorba/http-client-wrapper
The comments of the previous branch (outdated links, wrapper conversion module)
have been addressed.
--
https://code.launchpad.net/~zorba-coders/
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module.
Requested reviews:
Cezar Andrei (cezar-andrei)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+m
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
--
https://code.laun
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module.
Requested reviews:
Cezar Andrei (cezar-andrei)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+m
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/56/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/1
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
:
Votes: {'Pending': 2, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Your team Zorba Coders
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723 :
Votes: {'Needs Information': 1, 'Approve': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coders is subscribed to bran
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/57/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/http-clien
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
You
To avoid replicating conversion code (600-700 lines) between the core XML http
client and the Expath http client as discussed in:
https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578
I introduced a wrapper module for doing all conversions.
--
https:
Depends on lp:~zorba-coders/zorba/http-client-wrapper
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coder
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Stage "TestZorbaUbuntu" failed.
1 tests failed (8415 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/123/testReport/ to view the
results.
--
https://code.la
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723
Your team Zorba Coder
> - In ZorbaCollectionIterator::initCollection lines 307 and 326, you eventually
> add skipCount twice. Something smells spooky here.
Yes, it seems it was added twice. I've fixed it.
I've also added the skip() function to the EvalIterator.
--
--
https://code.launchpad.net/~zorba-coders/zorba/s
> I have tried some basic queries and there is a huge performance improvement.
> This is great.
> However, I detected a memory leak and have one question.
>
> - memory leak in translator.cpp:4823
I've fixed it.
>
> - In the following query, no dataguide seems to be pushed into the parser.
> Why
Is the code replication exact, or very nearly exact? If so I think I'd go with
option 2. (If it was only 50-100 lines of code I'd pick option 1, but 600 lines
seems like rather a lot.) I suspect that the XML http-client will be with us
for quite some time.
I agree that option 3, while clean, pr
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+m
Review: Needs Information
> 1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the
> public API exactly the same, as defined by EXpath? I understand the
> implementation is different, but I don't believe that's relevant for module
> versioning.
>
> 2. (Possibly the same ques
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/54/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-mod
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Commit Message changed to:
Added JSON HTTP client module.
Fixed initialization, error reporting and encoding bugs in the XML HTTP client.
Reimplemented XML HTTP client on top of the JSON HTTP client mod
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579 :
Votes: {'Approve': 2, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is sub
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
39 matches
Mail list logo
