Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-05 Thread Cezar Andrei
Review: Needs Information We, David and I, found that Juans imap package that includes libc-client.a is not compiling on latest Ubuntu, 12.04 Precise. But there is a fix: - if (!logged++) syslog (LOG_ERR,tmp); + if (!logged++) syslog (LOG_ERR, "%s", tmp); found at http://bugs.debian.or

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-05 Thread Cezar Andrei
It looks to me that you have found a fix but we're not fully understanding why these dependencies are required. How come it works on my box without your fix? This is my cclient symbol, see crypt is missing: cezar@i7:~/dev/misc/jniStream/cpp$ nm /usr/lib/libc-client.a | grep crypt

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-05 Thread Cezar Andrei
Review: Needs Fixing Please add at least a warning if it doesn't exist, so somebody that doesn't have it would not run into your problem. -- https://code.launchpad.net/~davidagraf/zorba/email-module-crypt/+merge/113366 Your team Zorba Coders is subscribed to branch lp:zorba/email-module. -- Ma

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-05 Thread David Graf
You mean if the crypt library doesn't exist? But the crypt library is only needed if it exists. Otherwise it's not needed -> it doesn't make sense to show a warning, I think. -- https://code.launchpad.net/~davidagraf/zorba/email-module-crypt/+merge/113366 Your team Zorba Coders is subscribed to

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-04 Thread David Graf
Maybe, some additional explanation is needed: On Ubuntu 64Bit, we (28msec) are compiling c-client ourselves. Otherwise, the email modules do not compile (we created a ppa repository for this: https://launchpad.net/~28msec/+archive/cclient). When I build the c-client library myself, I discovered

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-04 Thread David Graf
Honestly, I do not really know with this additional dependency is needed. But it helps fixing the problem. -- https://code.launchpad.net/~davidagraf/zorba/email-module-crypt/+merge/113366 Your team Zorba Coders is subscribed to branch lp:zorba/email-module. -- Mailing list: https://launchpad.ne

[Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-04 Thread David Graf
The proposal to merge lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module has been updated. Commit Message changed to: If system library crypt is available on the system, the email module needs to be linked against it. For more details, see: https://code.launchpad.net/~davidagra

[Zorba-coders] [Merge] lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module

2012-07-04 Thread David Graf
David Graf has proposed merging lp:~davidagraf/zorba/email-module-crypt into lp:zorba/email-module. Requested reviews: Chris Hillery (ceejatec) Cezar Andrei (cezar-andrei) For more details, see: https://code.launchpad.net/~davidagraf/zorba/email-module-crypt/+merge/113366 Fixing crypt depen