Hi Markos,
Thanks a lot!
2. and 3. should be fixed.
About 1: invariant 3 checks that the tree does not contain a type under certain
circumstances, so it requires getType() to fail in a gracious manner. The
asserts that were in getType() are actually relocated to the element and
attribute
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-971782-2012-06-26T10-11-07.167Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Hi Markos,
Thanks a lot!
2. and 3. should be fixed.
About 2, the problem is still there, because setTree now calls getNodeKind(),
which is also a virtual method. But this is a more general problem; basically,
we need a non-virtual getNodeKindInternal() method to be used everywhere
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue job bug-971782-2012-06-26T10-11-07.167Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
1. Why are the asserts in XmlTree::getType() converted to ifs? Did th asserts
actually trigger ever?
2. The setTree() methods has been made virtual. This si not good, because the
method is used rather often.
3. The 6 lines:
#ifndef EMBEDED_TYPE
#ifndef NDEBUG
ATTRIBUTE_ELEMENT_INVARIANT1;
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I think that the existing code could lead the tree structure (attribute/element
types) to an inconsistent state that led to windows crashes. As far as I can
remember, it was originally because of QName comparison using == instead of
equals.
This merge proposal (i) brings more encapsulation to
I think that this bug was marked as Fix Released because it was raised
against Sausalito, and this code is already in Sausalito.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
looks good to me.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Information
The bug has already been marked as Fix Released. Which problem does this
commit fix?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Ghislain and I did some cleanup. And I think this was a problem that appeared
only on windows. I don't know if we ever added a bug report for it. Ghislain,
do you remember more than I do?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-971782-2012-05-30T12-00-03.104Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-971782-2012-05-30T12-00-03.104Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 3 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-971782 into
lp:zorba.
Requested reviews:
Dennis Knochenwefel (dennis-knochenwefel)
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Cleaning up
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Merged = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-971782-2012-04-04T15-36-09.028Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job bug-971782-2012-04-04T15-36-09.028Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been
updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788
--
https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge
28 matches
Mail list logo
